Received-SPF: pass (google.com: domain of linux-kernel+bounces-112046-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Sender: Guenter Roeck <groeck7@gmail.com>
Date: Fri, 22 Mar 2024 14:41:02 -0700
From: Guenter Roeck <linux@roeck-us.net>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, x86@kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [patch 1/4] x86/cpu: Ensure that CPU info updates are propagated
 on UP
Message-ID: <7f08850c-6ddb-42f1-b2c9-0057e175b6e1@roeck-us.net>
References: <20240322184944.141421692@linutronix.de>
 <20240322185305.127642785@linutronix.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240322185305.127642785@linutronix.de>

On Fri, Mar 22, 2024 at 07:56:35PM +0100, Thomas Gleixner wrote:
> The boot sequence evaluates CPUID information twice:
> 
>   1) During early boot
> 
>   2) When finalizing the early setup right before
>      mitigations are selected and alternatives are patched.
> 
> In both cases the evaluation is stored in boot_cpu_data, but on UP the
> copying of boot_cpu_data to the per CPU info of the boot CPU happens
> between #1 and #2. So any update which happens in #2 is never propagated to
> the per CPU info instance.
> 
> Consolidate the whole logic and copy boot_cpu_data right before applying
> alternatives as that's the point where boot_cpu_data is in it's final state
> and not supposed to change anymore.
> 
> This also removes the voodoo mb() from smp_prepare_cpus_common() which had
> absolutely no purpose.
> 
> Fixes: 71eb4893cfaf ("x86/percpu: Cure per CPU madness on UP")
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

Tested-by: Guenter Roeck <linux@roeck-us.net>

Guenter