Received-SPF: pass (google.com: domain of linux-kernel+bounces-112053-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Fri, 22 Mar 2024 22:52:29 +0100
From: Pavel Machek <pavel@ucw.cz>
To: Daniel Hodges <hodges.daniel.scott@gmail.com>
Cc: ast@kernel.org, lee@kernel.org, linux-leds@vger.kernel.org,
	daniel@iogearbox.net, bpf@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] leds: trigger: legtrig-bpf: Add ledtrig-bpf module
Message-ID: <Zf39nYJVOH9/J8cs@duo.ucw.cz>
References: <cover.1711113657.git.hodges.daniel.scott@gmail.com>
 <ac8e77881212e18d117059a698affd6afc2607af.1711113657.git.hodges.daniel.scott@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="N4DJvJWOynbcHMAs"
Content-Disposition: inline
In-Reply-To: <ac8e77881212e18d117059a698affd6afc2607af.1711113657.git.hodges.daniel.scott@gmail.com>


--N4DJvJWOynbcHMAs
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi!

> This patch adds a led trigger that interfaces with the bpf subsystem. It
> allows for BPF programs to control LED activity through calling bpf
> kfuncs. This functionality is useful in giving users a physical
> indication that a BPF program has performed an operation such as
> handling a packet or probe point.
>=20
> Signed-off-by: Daniel Hodges <hodges.daniel.scott@gmail.com>

> +static int init_bpf(void)
> +{
> +	int ret;
> +
> +	ret =3D register_btf_kfunc_id_set(BPF_PROG_TYPE_UNSPEC,
> +			&ledtrig_bpf_kfunc_set);
> +	ret =3D register_btf_kfunc_id_set(BPF_PROG_TYPE_TRACING,
> +			&ledtrig_bpf_kfunc_set);

Should have ret ?: here, too?

> +static int ledtrig_bpf_init(void)
> +{
> +	led_trigger_register_simple("bpf", &ledtrig_bpf);
> +
> +	return init_bpf();
> +}

Is it somehow possible to have multiple LEDs hooked to bpf
functionality? I guess someone will want that...

Best regards,
								Pavel
--=20
People of Russia, stop Putin before his war on Ukraine escalates.

--N4DJvJWOynbcHMAs
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCZf39nQAKCRAw5/Bqldv6
8s0/AJ4ggTuHhsWQVEaesd844GKZQZ9mwgCgvsVcXdfViLuzhTNkVoM55R3JpwE=
=JQmB
-----END PGP SIGNATURE-----

--N4DJvJWOynbcHMAs--