Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp1448309lqp; Fri, 22 Mar 2024 15:43:27 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUNfC2WByBVi1dn8OWCHXhLYgTDlbdJRkXaTZaIk0l6KkIxihbw8LdT8MoGl6sVPkHMq7mBej/svEzmVgYyKRKwjX4OnV0Qu/57tHnQFg== X-Google-Smtp-Source: AGHT+IG8i8KLK+b88YGX/bgmdi4ejZP1N+EijQ/JnDe0/ebXWMGJDtwaiJ/QCFwSPo1qoNcvHBwj X-Received: by 2002:a50:f61e:0:b0:56b:b46d:9299 with SMTP id c30-20020a50f61e000000b0056bb46d9299mr508947edn.27.1711147407667; Fri, 22 Mar 2024 15:43:27 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711147407; cv=pass; d=google.com; s=arc-20160816; b=yThz/nEk+Y3hEtxxUU1OWukXwR3ERRlZvesEXbyXOsRAJnT78nWC7vymyFsPrXaN4b EjhDRgH641dIQ53Z9bS/NiKSVCm2NxOXgfcGxR3Nn/svoPF0LebJH4yq+S0RiC6i+xCg G679WLAjOY+ABCPWBJf4774kxIDavLZKZAv/rxZPCkDL6kRFJZuOa75DwiDVfxcgm94y OYZ982CUebLiy3s3NChKwuzT4h2/ZjrX9A2azrFFkDEnyBh8v/+LkbkO6XItQu8lIstT 3nZxQzJWvZgSz/I2Dc7M5E84TwL5x4/rmQqhguTgKZXXaSZS5dHgi3OpVCVbt+sh6vvH Tb2w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=VVFo6dx+J2GGwdIkM/+LYqSBKD/oZj40BePXQUkmfIc=; fh=fHhbvXgCev/wpffLVpfaAi8pPyv7hrTyhVPgsZ7HNrs=; b=TmjFFfYCrtWcDHuF2cJOPUPhtvNGXV95EpD3PPmOEiVHk5BQ3fKDjUIHI/swTy/wPa H2IiyW6SMqxmNwyM2vW2D5JR+G415cqOGqV1Bbv2/HMJfMZe0T2do7R4SGTT0bnUJml6 IIhIsIMys0kKQfpURcHvgctdaqTVbBLr6v0u51hqdjB3r+3bocKG65fLgU8U11wLffrG Fl0bGjVu6l3OQ7K4jNNWsN9Wwsye+zmkie5y3aSzjuX3qtuKY9LCc30Ez7IBjOTHJiXb QppypWksBHoOpuVSrhd/nx3HeIoeqrkFmKdctZrIX/qStg6Yd0sxf3gtwxbuKeY6pQmc MOLA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=UqM3YORh; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-112074-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-112074-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id dg23-20020a0564021d1700b00568b98d006csi243948edb.634.2024.03.22.15.43.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Mar 2024 15:43:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-112074-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=UqM3YORh; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-112074-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-112074-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 5D5591F23465 for ; Fri, 22 Mar 2024 22:43:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D63E582892; Fri, 22 Mar 2024 22:43:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UqM3YORh" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04CB71CD00; Fri, 22 Mar 2024 22:43:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711147395; cv=none; b=nnh+hHq+NTJOjf3s4MdMKScHvrTJNBLLcgGiuwuU1pcDLBDJAVyBo1geheb4tXk/5++k8UpRSUHDENxA20y3kgNZIx/K7Bvn+T8TcOjEKqbEdClVFu31kA6Ki/VlyMiFVxAwyt/nwPQR5ERIUW7AfGEEccNBGWbBR1UNrdP6ObM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711147395; c=relaxed/simple; bh=b4WPQIYm0LiVsWLdyPz+BXKQNcM2GtF3moecr3y79iQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=rEQah8QFa1TP4LjstCAReOgONxk8DaRrP8o8adxwAIMKXd2Ajm9LC7Y9giXXqs7o8rqkGFy9Cl7OIYahWiwRiQtolMvlXFQItT9M0iAfHFek5uLitv5EHLjN38YMBxnsMK74CmbPkgpJf1X1th84S9pJPqAMWZhxNfBZspOEpnA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=UqM3YORh; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1992DC433F1; Fri, 22 Mar 2024 22:43:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711147394; bh=b4WPQIYm0LiVsWLdyPz+BXKQNcM2GtF3moecr3y79iQ=; h=From:To:Cc:Subject:Date:From; b=UqM3YORhM0DAWz5OLfdhBqBCy4JtQLKQ3luQMCcLB3qMTVK/abbT2QsJh5PMETJIT iNkXGFT2LKy/tEqZ46T1uBBtyle3AOFJMsbW+E2Nf9k0ViEh89OpKERyDh/LbuIiNZ SObGXY6WP1zLv/nr2BytR6y58w4mkEICc/BnkLWoLPF8pB2fIZuunf6Eze+Tu5K3/q uQ6jW324TPDWbbdU+E+BtadeZhBBDMFBF3ANU8eMAH3BcHYLdh/u+qvM/9HV2mXk5b FN0Zo27IZiaOfsBCQa437ADWtQ6zV+jrhvo+JxZrGH+B2qpOXMJGa3Kb814qM63zMx pOgOZpQ/sA0dw== From: Namhyung Kim To: Arnaldo Carvalho de Melo , Ian Rogers , Kan Liang Cc: Jiri Olsa , Adrian Hunter , Peter Zijlstra , Ingo Molnar , LKML , linux-perf-users@vger.kernel.org Subject: [PATCH 1/2] perf annotate: Get rid of duplicate --group option item Date: Fri, 22 Mar 2024 15:43:12 -0700 Message-ID: <20240322224313.423181-1-namhyung@kernel.org> X-Mailer: git-send-email 2.44.0.396.g6e790dbe36-goog Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The options array in cmd_annotate() has duplicate --group options. It only needs one and let's get rid of the other. $ perf annotate -h 2>&1 | grep group --group Show event group information together --group Show event group information together Fixes: 7ebaf4890f63 ("perf annotate: Support '--group' option") Signed-off-by: Namhyung Kim --- tools/perf/builtin-annotate.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tools/perf/builtin-annotate.c b/tools/perf/builtin-annotate.c index f677671409b1..3e9f7e0596e8 100644 --- a/tools/perf/builtin-annotate.c +++ b/tools/perf/builtin-annotate.c @@ -810,8 +810,6 @@ int cmd_annotate(int argc, const char **argv) "Enable symbol demangling"), OPT_BOOLEAN(0, "demangle-kernel", &symbol_conf.demangle_kernel, "Enable kernel symbol demangling"), - OPT_BOOLEAN(0, "group", &symbol_conf.event_group, - "Show event group information together"), OPT_BOOLEAN(0, "show-total-period", &symbol_conf.show_total_period, "Show a column with the sum of periods"), OPT_BOOLEAN('n', "show-nr-samples", &symbol_conf.show_nr_samples, -- 2.44.0.396.g6e790dbe36-goog