Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp1514488lqp; Fri, 22 Mar 2024 19:11:41 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWCtxp8yQFR+vEOXJwcj9mKId8+nn/TJ6I0yoPXmYb1l9lH/Gnnz/GVXDiAH5tMlQ1xurkwVnlcscr7RGgzx/BdcP+wg0YBeYufAKbpgQ== X-Google-Smtp-Source: AGHT+IF4tj7opwuYdX+MgX38/D5/usUykbz313joGQCBwOaBA0ryM9P8amTZxHjVJT4ZlUt6hfhb X-Received: by 2002:a05:6808:38c5:b0:3c3:976a:42db with SMTP id el5-20020a05680838c500b003c3976a42dbmr2010244oib.17.1711159901383; Fri, 22 Mar 2024 19:11:41 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711159901; cv=pass; d=google.com; s=arc-20160816; b=gccKbQNSKTubb1Zo/hA6bjnXglpzGhz87NJTUelh8SS8GD5V+rLSzCfpPzF+pIVJV9 JqIJgJa6Wolc9D9PsvO/wmK+uDDUytFAGwCkdPYCW1vV+sDnn7te4rqfK9wFzHIou4Nn MXkzYYKi8FQApHCT1Zxxp34Xzms4Ci41MCn6cDae2KX7839LAYPYSDOlZ75Z3CSH4uyA v0YX5Sscc7wE5gvW0QQqy3dq5WOpcnJ4Cdjes29z98trSxQhoLO9yAHbdB1Y3yAnmk4k xdUN7PpvvthAhy8Kj5JnZzeW/y6qKbhVmWTrexrhPJEZNQPoWLyPRj+51w6LIkyLeDla uCeA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=KAfLrzuTcBA/cgTB1QzmsE3F7asDmea2BZTVVcOLx44=; fh=AhOTKAnl7MWcxGeMoE4kozfeloMZ8h2/O3RLDTmeauU=; b=cF7DLPqLyh6TCJ9b4KHoWyK7e9ZVg0wYP6oDpjOhm/5g4fclBguPQtjMA+RslJfwbW uGqgELmjDzJeExMjRqC6tc8pxKG4YjV57sm8XGqKwPVxUf9p6SiLdUWxRSJm1nLT0Qs7 KrF2rDMzUEYQYccO5dzSEwxwptAqLHAtuLStl/WO983oClxiSVvYjbPI77+F3kMKQULY vPnW/fTZxDBVN+ZPHWftWO6yIATgefsuK7kUvHqlTYXsIPadsJT70Y5w3EoWbdkIVBi2 YVNcO3h/XlTMnCX2m1eF5kTMQPYpdlD5/7SqrBU382s7oPBAuO4n9XbGCaIGJ5GKP529 tjdA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WfaNECkT; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-112179-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-112179-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id 21-20020a631155000000b005dc3e746573si3136961pgr.826.2024.03.22.19.11.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Mar 2024 19:11:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-112179-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WfaNECkT; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-112179-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-112179-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 0AAAF28272D for ; Sat, 23 Mar 2024 02:11:41 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6CEC446B5; Sat, 23 Mar 2024 02:11:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WfaNECkT" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 868031A38DB for ; Sat, 23 Mar 2024 02:11:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711159887; cv=none; b=n7+ZrcfUlQZ36Te2K5JQTRgOLzDOcr+jnVQjU9iJuKG8CoMy4fzU7ERBvfKmY76nA5pJdLsRftYc5sm7XrvFddfPCZdYQerzAnFWnkJG6MwiilLwlIjsZJZo5kicOeqtecsbEER2Rre400p6FRNukg8ceCwTQHEjGzaCwF/b+7A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711159887; c=relaxed/simple; bh=AZBuJoYGPORqk3ClXZRSdCW5KtfizlTcBSYe7IFEB1I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fIqyxv64LajyvmQ47EVAyNnuoemaVAAaIaKv0IUWUdRnhOeT76ScnK/ZHKQpmOlUM9hoW9ECEJwyuPI/SuYSijTMH7+9UKo0fvCAIGJpT0QAO6nBAuUz2wXB8hNy/h6IsabX7ybvhGGlW3G+mn1rNAL9CExxUQKFYLjPdX9sguo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WfaNECkT; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF7D1C433C7; Sat, 23 Mar 2024 02:11:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711159887; bh=AZBuJoYGPORqk3ClXZRSdCW5KtfizlTcBSYe7IFEB1I=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=WfaNECkTCDZL3Jf6XPGJLufCwt8BdrBIMGjIGmAxMVEZY0no25EfwG++MMM6XCMcJ fecGmXOc+pLwIwD492yWTjFZDSVVrX9uHYDW4PPgEz9uhMGySeDy9wHP3zWSb0+0u0 /L/zcnOS4hEnsXKwlrcksXaGIJrq7cAUEhnfeum+Nt5duowwqg7USk/5NDzZAIwJ4N ipGaU5S+0ZIpANgK9jsy2PFka60xEx4vIaCh3FV0nohUzwjzfE67AOONqbnPwjih2B 11SAuSnuOh9L5kJPaRREKjrM0VPlwBYUzIMo8cJdklw3dwRsNbKZvlc/cfjCdnGW56 tQ0LwxqgU6X4g== Message-ID: <89414a3a-5d1a-45d3-a00b-199fa3d3ca78@kernel.org> Date: Sat, 23 Mar 2024 10:11:26 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] f2fs: Prevent s_writer rw_sem count mismatch in f2fs_evict_inode Content-Language: en-US To: Yeongjin Gil , jaegeuk@kernel.org Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Sungjong Seo , Sunmin Jeong References: <20240322041639.23144-1-youngjin.gil@samsung.com> From: Chao Yu Autocrypt: addr=chao@kernel.org; keydata= xsFNBFYs6bUBEADJuxYGZRMvAEySns+DKVtVQRKDYcHlmj+s9is35mtlhrLyjm35FWJY099R 6DL9bp8tAzLJOMBn9RuTsu7hbRDErCCTiyXWAsFsPkpt5jgTOy90OQVyTon1i/fDz4sgGOrL 1tUfcx4m5i5EICpdSuXm0dLsC5lFB2KffLNw/ZfRuS+nNlzUm9lomLXxOgAsOpuEVps7RdYy UEC81IYCAnweojFbbK8U6u4Xuu5DNlFqRFe/MBkpOwz4Nb+caCx4GICBjybG1qLl2vcGFNkh eV2i8XEdUS8CJP2rnp0D8DM0+Js+QmAi/kNHP8jzr7CdG5tje1WIVGH6ec8g8oo7kIuFFadO kwy6FSG1kRzkt4Ui2d0z3MF5SYgA1EWQfSqhCPzrTl4rJuZ72ZVirVxQi49Ei2BI+PQhraJ+ pVXd8SnIKpn8L2A/kFMCklYUaLT8kl6Bm+HhKP9xYMtDhgZatqOiyVV6HFewfb58HyUjxpza 1C35+tplQ9klsejuJA4Fw9y4lhdiFk8y2MppskaqKg950oHiqbJcDMEOfdo3NY6/tXHFaeN1 etzLc1N3Y0pG8qS/mehcIXa3Qs2fcurIuLBa+mFiFWrdfgUkvicSYqOimsrE/Ezw9hYhAHq4 KoW4LQoKyLbrdOBJFW0bn5FWBI4Jir1kIFHNgg3POH8EZZDWbQARAQABzRlDaGFvIFl1IDxj aGFvQGtlcm5lbC5vcmc+wsF3BBMBCgAhBQJWLOm1AhsDBQsJCAcDBRUKCQgLBRYCAwEAAh4B AheAAAoJEKTPgB1/p52Gm2MP/0zawCU6QN7TZuJ8R1yfdhYr0cholc8ZuPoGim69udQ3otet wkTNARnpuK5FG5la0BxFKPlazdgAU1pt+dTzCTS6a3/+0bXYQ5DwOeBPRWeFFklm5Frmk8sy wSTxxEty0UBMjzElczkJflmCiDfQunBpWGy9szn/LZ6jjIVK/BiR7CgwXTdlvKcCEkUlI7MD vTj/4tQ3y4Vdx+p7P53xlacTzZkP+b6D2VsjK+PsnsPpKwaiPzVFMUwjt1MYtOupK4bbDRB4 NIFSNu2HSA0cjsu8zUiiAvhd/6gajlZmV/GLJKQZp0MjHOvFS5Eb1DaRvoCf27L+BXBMH4Jq 2XIyBMm+xqDJd7BRysnImal5NnQlKnDeO4PrpFq4JM0P33EgnSOrJuAb8vm5ORS9xgRlshXh 2C0MeyQFxL6l+zolEFe2Nt2vrTFgjYLsm2vPL+oIPlE3j7ToRlmm7DcAqsa9oYMlVTTnPRL9 afNyrsocG0fvOYFCGvjfog/V56WFXvy9uH8mH5aNOg5xHB0//oG9vUyY0Rv/PrtW897ySEPh 3jFP/EDI0kKjFW3P6CfYG/X1eaw6NDfgpzjkCf2/bYm/SZLV8dL2vuLBVV+hrT1yM1FcZotP WwLEzdgdQffuQwJHovz72oH8HVHD2yvJf2hr6lH58VK4/zB/iVN4vzveOdzlzsFNBFYs6bUB EADZTCTgMHkb6bz4bt6kkvj7+LbftBt5boKACy2mdrFFMocT5zM6YuJ7Ntjazk5z3F3IzfYu 94a41kLY1H/G0Y112wggrxem6uAtUiekR9KnphsWI9lRI4a2VbbWUNRhCQA8ag7Xwe5cDIV5 qb7r7M+TaKaESRx/Y91bm0pL/MKfs/BMkYsr3wA1OX0JuEpV2YHDW8m2nFEGP6CxNma7vzw+ JRxNuyJcNi+VrLOXnLR6hZXjShrmU88XIU2yVXVbxtKWq8vlOSRuXkLh9NQOZn7mrR+Fb1EY DY1ydoR/7FKzRNt6ejI8opHN5KKFUD913kuT90wySWM7Qx9icc1rmjuUDz3VO+rl2sdd0/1h Q2VoXbPFxi6c9rLiDf8t7aHbYccst/7ouiHR/vXQty6vSUV9iEbzm+SDpHzdA8h3iPJs6rAb 0NpGhy3XKY7HOSNIeHvIbDHTUZrewD2A6ARw1VYg1vhJbqUE4qKoUL1wLmxHrk+zHUEyLHUq aDpDMZArdNKpT6Nh9ySUFzlWkHUsj7uUNxU3A6GTum2aU3Gh0CD1p8+FYlG1dGhO5boTIUsR 6ho73ZNk1bwUj/wOcqWu+ZdnQa3zbfvMI9o/kFlOu8iTGlD8sNjJK+Y/fPK3znFqoqqKmSFZ aiRALjAZH6ufspvYAJEJE9eZSX7Rtdyt30MMHQARAQABwsFfBBgBCgAJBQJWLOm1AhsMAAoJ EKTPgB1/p52GPpoP/2LOn/5KSkGHGmdjzRoQHBTdm2YV1YwgADg52/mU68Wo6viStZqcVEnX 3ALsWeETod3qeBCJ/TR2C6hnsqsALkXMFFJTX8aRi/E4WgBqNvNgAkWGsg5XKB3JUoJmQLqe CGVCT1OSQA/gTEfB8tTZAGFwlw1D3W988CiGnnRb2EEqU4pEuBoQir0sixJzFWybf0jjEi7P pODxw/NCyIf9GNRNYByUTVKnC7C51a3b1gNs10aTUmRfQuu+iM5yST5qMp4ls/yYl5ybr7N1 zSq9iuL13I35csBOn13U5NE67zEb/pCFspZ6ByU4zxChSOTdIJSm4/DEKlqQZhh3FnVHh2Ld eG/Wbc1KVLZYX1NNbXTz7gBlVYe8aGpPNffsEsfNCGsFDGth0tC32zLT+5/r43awmxSJfx2P 5aGkpdszvvyZ4hvcDfZ7U5CBItP/tWXYV0DDl8rCFmhZZw570vlx8AnTiC1v1FzrNfvtuxm3 92Qh98hAj3cMFKtEVbLKJvrc2AO+mQlS7zl1qWblEhpZnXi05S1AoT0gDW2lwe54VfT3ySon 8Klpbp5W4eEoY21tLwuNzgUMxmycfM4GaJWNCncKuMT4qGVQO9SPFs0vgUrdBUC5Pn5ZJ46X mZA0DUz0S8BJtYGI0DUC/jAKhIgy1vAx39y7sAshwu2VILa71tXJ In-Reply-To: <20240322041639.23144-1-youngjin.gil@samsung.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2024/3/22 12:16, Yeongjin Gil wrote: > If f2fs_evict_inode is called between freeze_super and thaw_super, the > s_writer rwsem count may become negative, resulting in hang. > > CPU1 CPU2 > > f2fs_resize_fs() f2fs_evict_inode() > f2fs_freeze > set SBI_IS_FREEZING > skip sb_start_intwrite > f2fs_unfreeze > clear SBI_IS_FREEZING > sb_end_intwrite > > To solve this problem, the call to sb_end_write is determined by whether > sb_start_intwrite is called, rather than the current freezing status. > > Reviewed-by: Sungjong Seo > Reviewed-by: Sunmin Jeong > Signed-off-by: Yeongjin Gil Reviewed-by: Chao Yu Thanks,