Received-SPF: pass (google.com: domain of linux-kernel+bounces-112192-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Subject: Re: [RFC PATCH v2 5/5] ubifs: Introduce ACLs mount options
To: Li Zetao <lizetao1@huawei.com>, <richard@nod.at>, <corbet@lwn.net>,
	<kent.overstreet@linux.dev>, <agruenba@redhat.com>
CC: <linux-mtd@lists.infradead.org>, <linux-doc@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
References: <20240322154812.215369-1-lizetao1@huawei.com>
 <20240322154812.215369-6-lizetao1@huawei.com>
From: Zhihao Cheng <chengzhihao1@huawei.com>
Message-ID: <e10b4182-a6b6-25f5-b04d-92bc20fa56d4@huawei.com>
Date: Sat, 23 Mar 2024 10:55:26 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.5.0
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <20240322154812.215369-6-lizetao1@huawei.com>
Content-Type: text/plain; charset="gbk"; format=flowed
Content-Transfer-Encoding: 8bit

?? 2024/3/22 23:48, Li Zetao д??:
> Implement the ability to enable or disable the ACLs feature through
> mount options. "-o acl" option means enable and "-o noacl" means disable
> and it is enable by default.
> 
> Signed-off-by: Li Zetao <lizetao1@huawei.com>
> ---
> v1 -> v2:
>    * Remove redundant assignments to mount.acl.
>    * Added the description of acl mount options in ubifs.rst.
> 
> v1: https://lore.kernel.org/all/20240319161646.2153867-5-lizetao1@huawei.com/
> 
>   Documentation/filesystems/ubifs.rst |  4 +++
>   fs/ubifs/super.c                    | 41 +++++++++++++++++++++++++++++
>   fs/ubifs/ubifs.h                    |  2 ++
>   3 files changed, 47 insertions(+)
> 
> diff --git a/Documentation/filesystems/ubifs.rst b/Documentation/filesystems/ubifs.rst
> index ced2f7679ddb..f9615104d7a3 100644
> --- a/Documentation/filesystems/ubifs.rst
> +++ b/Documentation/filesystems/ubifs.rst
> @@ -105,6 +105,10 @@ auth_key=		specify the key used for authenticating the filesystem.
>   auth_hash_name=		The hash algorithm used for authentication. Used for
>   			both hashing and for creating HMACs. Typical values
>   			include "sha256" or "sha512"
> +noacl			This option disables POSIX Access Control List support. If ACL support
> +			is enabled in the kernel configuration (CONFIG_EXT4_FS_POSIX_ACL), ACL
> +			is enabled by default on mount. See the acl(5) manual page for more
> +			information about acl.
Also add acl description?
Split documentation into a new patch?