Received-SPF: pass (google.com: domain of linux-kernel+bounces-112194-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Fri, 22 Mar 2024 19:59:02 -0700
From: Alison Schofield <alison.schofield@intel.com>
To: Chandra Pratap <chandrapratap3519@gmail.com>
Cc: sudipm.mukherjee@gmail.com, dan.carpenter@linaro.org,
	teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org,
	linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org, outreachy@lists.linux.dev
Subject: Re: [PATCH v3] staging: sm750fb: Replace comparisons with NULL and 0
Message-ID: <Zf5FdsiaVPQ6iz2r@aschofie-mobl2>
References: <2024032208-blunt-ferocity-22f4@gregkh>
 <20240322151633.16485-1-chandrapratap3519@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240322151633.16485-1-chandrapratap3519@gmail.com>

On Fri, Mar 22, 2024 at 08:46:33PM +0530, Chandra Pratap wrote:
> Replace '(opt != NULL)' with '(opt)' and '(*opt != 0)'
> with '(*opt != '\0')' to adhere to the coding standards.
> 
> Signed-off-by: Chandra Pratap <chandrapratap3519@gmail.com>
> ---
> 
> Please ignore the other v3 patch I sent, I forgot to write
> the change log in that patch. Apologies for any incovenienece
> caused.

Hi Chandra,

No need to apologize, but you do need to send a v4. Any change
in the patch is a new rev - even if that change is to the
changelog. Maintainers are using automated tooling to grab
the latest revisions and two patches with the same version 
number will be disregarded. 

Please send a v4 with:

Changes in v4:
  - Include the changelog.

While you're at it, reverse the order of this changelog.
Put most recent revisions first - ie 4,3,2 order.

Also, post the patch as a new message, not a reply to prior
patches.

Thanks,
Alison


> 
> Changes in v2:
>   - Update the commit message to reflect the changes better
>   - Replace (*opt) with (*opt != '\0')
> 
> Changes in v3:
>   - Remove unncessary spacing
> 
>  drivers/staging/sm750fb/sm750.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
> index 04c1b32a22c5..c4b944f82fb9 100644
> --- a/drivers/staging/sm750fb/sm750.c
> +++ b/drivers/staging/sm750fb/sm750.c
> @@ -926,7 +926,7 @@ static void sm750fb_setup(struct sm750_dev *sm750_dev, char *src)
>  		goto NO_PARAM;
>  	}
>  
> -	while ((opt = strsep(&src, ":")) != NULL && *opt != 0) {
> +	while ((opt = strsep(&src, ":")) && *opt != '\0') {
>  		dev_info(&sm750_dev->pdev->dev, "opt=%s\n", opt);
>  		dev_info(&sm750_dev->pdev->dev, "src=%s\n", src);
>  
> @@ -1147,7 +1147,7 @@ static int __init lynxfb_setup(char *options)
>  	 * strsep() updates @options to pointer after the first found token
>  	 * it also returns the pointer ahead the token.
>  	 */
> -	while ((opt = strsep(&options, ":")) != NULL) {
> +	while ((opt = strsep(&options, ":"))) {
>  		/* options that mean for any lynx chips are configured here */
>  		if (!strncmp(opt, "noaccel", strlen("noaccel"))) {
>  			g_noaccel = 1;
> -- 
> 2.34.1
> 
>