Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp1534758lqp; Fri, 22 Mar 2024 20:30:37 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWI4PHVDI2WDKSykgJO4CCL6iMMBB8cPfHEbQ94xPxQg4NUs4qAp1GEywHNMdQRPEnndmI2jsrQzbOp6P4q9dPsvldljGezQqP0h7gW+g== X-Google-Smtp-Source: AGHT+IEBy8pGtp4X15rXaI6aA3EJYKah6k+JNXdaI7XSlUhqfaqYhh4EvtSKqzYZWrx19dSlhWLl X-Received: by 2002:a17:90b:108c:b0:2a0:3df6:55fc with SMTP id gj12-20020a17090b108c00b002a03df655fcmr1445922pjb.9.1711164637349; Fri, 22 Mar 2024 20:30:37 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711164637; cv=pass; d=google.com; s=arc-20160816; b=h4KIGXnhVawtG0CywsybBL6zdVyfJTlzGwCq0p7Q2yQ60yUuKMK5i4m9QBqqM3ZlZ1 Z/HdxbDHBkqYmWm/ZqiGSNRE6qFhKHSCenIb7mg5gDwIXz6WLue1ypu8cWT9CalMnDUq qiH6cKg31YWAhxSkKNlgprKdOr8ZrTm+XjWi3rLrfHX+6gV7yKmQIXalq48U03rSNBnU jqCkxHhl/3KvQuPj2Rpo8YrbNn3YdxIo9IlEYE0PKRwZoHGyY81enQyO532iySIrfZ0M Ad0p9gDLu8tbDaqMlN8AF2vS1U8ZrmimVzyFPDfISLG2sWnQJlryRm1153rFZH44CoDX G6Fg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:date:message-id:from:subject :content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=D8WRTjPkTx7auQxLc+WtSoeBEF5NDIGwFrNL9Wuq/4A=; fh=jnvK70nHPboUYMoV/RVJU2H7Xl5mupB+3ZhXLvpjW0U=; b=cU/LXMcM3r/HOUij6Jq7KYjK7zFg8jXziXmdWBKn8Vh7w+6g6LI2beJljXQ24YSUBT qOnAf/jHKvJKIR/y+iji9lS7MwKTA7N02/BHvD8Pk3rlLk4GuBU3FlPz5aQ2kX0mJE0I lI08t6ocIaf8ox2cLI+13FClwJ+sIFSZDrNx65Cux1waShB/ViXQQlZUJaaDXvA4xTTY prWgKPnbui9nHGPWAz/YtzAxLrahbAygSZEzB1uxQbaUfaSCS3fdyuuwXtD2beS2yphN Epvo41JHgvqRdaxNwfVSZMEa7M5+KTxXawSkhmxuoTxJPmycIg7ideydvrIAMDOdSLma 4/Vg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=uUqIvMdB; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-112202-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-112202-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id l11-20020a170903120b00b001e09dff4f75si783831plh.224.2024.03.22.20.30.37 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Mar 2024 20:30:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-112202-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=uUqIvMdB; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-112202-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-112202-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 0310C281F9A for ; Sat, 23 Mar 2024 03:30:37 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9981B443D; Sat, 23 Mar 2024 03:30:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="uUqIvMdB" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBFA7372; Sat, 23 Mar 2024 03:30:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711164627; cv=none; b=pgKl7hOHsdkvoY6xbfIMXLEZDum7Nbbcx5ODUGxN3WD1wwMDFsoSh4NvtyaRiEI1U9vO3K0bi1D5c4fK192Z1H2Nm65altd2FxiHx4MznphPJ6Pl+F8YcYhygnrzqj996RfvpJdMoDULVcdTSGtVnBMEGAARfyNRjMljbHC5nKc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711164627; c=relaxed/simple; bh=+tGRBpJ9JnSVUiVKm52veEsP2Jzvsh+vYHAwZIZia/o=; h=Content-Type:MIME-Version:Subject:From:Message-Id:Date:References: In-Reply-To:To:Cc; b=lPitpt+tVv11a7cmx1cHpp6EUOogLFZI/86Vk5ol11gyYnU2VRa4mm6X0gHrcT59UVptBbQYa4F5N2jUMOf1h57gKdLrrAIXmnEd2MgT8xrSRrt/yy9kzRwxf5of8T74fhqmKHoRGJUf9d6QRkIi4Rbp/oO1VE1Xx4EXd987+Ps= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=uUqIvMdB; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPS id 268C6C43390; Sat, 23 Mar 2024 03:30:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711164627; bh=+tGRBpJ9JnSVUiVKm52veEsP2Jzvsh+vYHAwZIZia/o=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=uUqIvMdB8deXAEMqq8YkQWpfVhM5Cgb4sgst2WIM3tqcdaDAbccbDaQ8XNLjdaKbh KcQBLi92WFTmDpDIjn1zrMcD3T92olNIEDrThZTEsb6Ba/fciLgLdbgZXBMw06+wgN PMZIif7RFIA/Ar5K8pBcXgfJdbzL4wD1dNPEJvtZuzMN17fO6r2HhnxZ37DqDl8rgj LJ0p9qMW0wVKVlLrEj61tMF9QFKY+6t4nY2t3i0t+17bMD/8oFTaMcXOZgSyGKq1Rm XIv4kyAv5pQ7MGnGFk2EYedRbRfxMJPl4zBgaxhccwquLgWWfhOJz/FckVOuN+B66q IpV9PQMaEjIDg== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 141F5D8BCE7; Sat, 23 Mar 2024 03:30:27 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [RESEND PATCH bpf] bpf: verifier: fix addr_space_cast from as(1) to as(0) From: patchwork-bot+netdevbpf@kernel.org Message-Id: <171116462707.20726.11825470378202448490.git-patchwork-notify@kernel.org> Date: Sat, 23 Mar 2024 03:30:27 +0000 References: <20240321153939.113996-1-puranjay12@gmail.com> In-Reply-To: <20240321153939.113996-1-puranjay12@gmail.com> To: Puranjay Mohan Cc: ast@kernel.org, daniel@iogearbox.net, john.fastabend@gmail.com, andrii@kernel.org, martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org, yonghong.song@linux.dev, kpsingh@kernel.org, sdf@google.com, haoluo@google.com, jolsa@kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org Hello: This patch was applied to bpf/bpf.git (master) by Alexei Starovoitov : On Thu, 21 Mar 2024 15:39:39 +0000 you wrote: > The verifier currently converts addr_space_cast from as(1) to as(0) that > is: BPF_ALU64 | BPF_MOV | BPF_X with off=1 and imm=1 > to > BPF_ALU | BPF_MOV | BPF_X with imm=1 (32-bit mov) > > Because of this imm=1, the JITs that have bpf_jit_needs_zext() == true, > interpret the converted instruction as BPF_ZEXT_REG(DST) which is a > special form of mov32, used for doing explicit zero extension on dst. > These JITs will just zero extend the dst reg and will not move the src to > dst before the zext. > > [...] Here is the summary with links: - [RESEND,bpf] bpf: verifier: fix addr_space_cast from as(1) to as(0) https://git.kernel.org/bpf/bpf/c/c49cdf5b88aa You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html