Received-SPF: pass (google.com: domain of linux-kernel+bounces-112222-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Subject: Re: [PATCH -next RFC] blk-throttle: remove
 CONFIG_BLK_DEV_THROTTLING_LOW
To: Randy Dunlap <rdunlap@infradead.org>, Yu Kuai <yukuai1@huaweicloud.com>,
 axboe@kernel.dk, tj@kernel.org, hch@lst.de, ming.lei@redhat.com,
 josef@toxicpanda.com
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
 cgroups@vger.kernel.org, yi.zhang@huawei.com, yangerkun@huawei.com,
 "yukuai (C)" <yukuai3@huawei.com>
References: <20240323025322.1310935-1-yukuai1@huaweicloud.com>
 <bf3715e1-bf44-44e6-8877-4bbcfe5f3f98@infradead.org>
From: Yu Kuai <yukuai1@huaweicloud.com>
Message-ID: <faa30b1d-7f0d-40cb-a911-f6214785d8ab@huaweicloud.com>
Date: Sat, 23 Mar 2024 12:09:59 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <bf3715e1-bf44-44e6-8877-4bbcfe5f3f98@infradead.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi !

在 2024/03/23 11:17, Randy Dunlap 写道:
> Hi--
> 
> On 3/22/24 19:53, Yu Kuai wrote:
>> From: Yu Kuai <yukuai3@huawei.com>
>>
>> One the one hand, it's marked EXPERIMENTAL since 2017, and looks like
>> there are no users since then, and no testers and no developers, it's
>> just not active at all.
>>
>> On the other hand, even if the config is disabled, there are still many
>> fields in throtl_grp and throtl_data and many functions that are only
>> used for throtl low.
>>
>> At last, currently blk-throtl is initialized during disk initialization,
>> and destroyed during disk removal, and it exposes many functions to be
>> called directly from block layer. Hence I'm planning to optimize
>> blk-throtl and finially support building it as kernel module. Remove
>> throtl low will make the work much easier.
>>
>> Signed-off-by: Yu Kuai <yukuai3@huawei.com>
>> ---
>>   block/Kconfig        |  11 -
>>   block/bio.c          |   1 -
>>   block/blk-stat.c     |   3 -
>>   block/blk-sysfs.c    |   7 -
>>   block/blk-throttle.c | 901 ++-----------------------------------------
>>   block/blk-throttle.h |  26 +-
>>   block/blk.h          |  11 -
>>   7 files changed, 45 insertions(+), 915 deletions(-)
> 
> Here are 2 more places to patch:
> 
> Documentation/ABI/stable/sysfs-block:           CONFIG_BLK_DEV_THROTTLING_LOW is enabled.
> arch/loongarch/configs/loongson3_defconfig:CONFIG_BLK_DEV_THROTTLING_LOW=y

Thanks for the notice, I'll update the patch if people agree to remove
throttle low.

Thanks,
Kuai

> 
>