Received-SPF: pass (google.com: domain of linux-kernel+bounces-112279-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Sat, 23 Mar 2024 10:31:08 +0100
Message-ID: <87jzltxpk3.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: LuMingYin <lumingyindetect@163.com>
Cc: linux-sound@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	perex@perex.cz,
	tiwai@suse.com,
	minhuadotchen@gmail.com
Subject: Re: [PATCH] sound:Fix a memory leak in snd_ctl_elem_add_compat function
In-Reply-To: <20240323092712.685675-1-lumingyindetect@163.com>
References: <20240323092712.685675-1-lumingyindetect@163.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
Precedence: bulk
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII

On Sat, 23 Mar 2024 10:27:12 +0100,
LuMingYin wrote:
> 
> In the function snd_ctl_elem_add_compat defined in /linux/sound/core/control_compat.c, a pointer named data is declared. This pointer allocates a block of dynamic memory using the kzalloc function at line 354. When the if statement at line 355 returns false, it indicates successful allocation of the dynamic memory area pointed to by data. However, when the if statements at lines 359 or 362 are true, the program will not execute the snd_ctl_elem_add(file, data, replace); operation at line 389 and will return directly. During this process, the dynamic memory area pointed to by data is neither freed nor used, leading to a memory leak bug. This commit fixes the aforementioned memory leak issue.
> 
> Signed-off-by: LuMingYin <lumingyindetect@163.com>

Ditto as another mail, it's automatically freed.


Takashi