Received-SPF: pass (google.com: domain of linux-kernel+bounces-112284-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Avri Altman <Avri.Altman@wdc.com>
To: Avri Altman <Avri.Altman@wdc.com>, "James E . J . Bottomley"
	<jejb@linux.ibm.com>, "Martin K . Petersen" <martin.petersen@oracle.com>
CC: Bart Van Assche <bvanassche@acm.org>, Bean Huo <beanhuo@micron.com>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v3 0/4] Re-use device management code fragments
Thread-Topic: [PATCH v3 0/4] Re-use device management code fragments
Thread-Index: AQHacflatx7QX3r03U2kfjTRNTABIrFFLyzA
Date: Sat, 23 Mar 2024 10:06:17 +0000
Message-ID:
 <DM6PR04MB6575210C413DDBA9E5E3C7BFFC302@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <20240309081104.5006-1-avri.altman@wdc.com>
In-Reply-To: <20240309081104.5006-1-avri.altman@wdc.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?gjJ26l5E0gNF5jEZw5Du5ksD2xuyeAaACMkwmMOBaly4if5D3JFY2YPv4EYX?=
 =?us-ascii?Q?qCmbtkf44zVQDMZGCEQKUaE6UBBQPHljQ9/SW86zgz0RyjlhpJ+Xm24/xpo6?=
 =?us-ascii?Q?QrkO9l6g4hKWBjn9rjjQVnT5I/EETFohdwnLwML21cJ6v85UW6Fh8Wl9AV15?=
 =?us-ascii?Q?qQk5ZJAv+ohN9DKq3L5bC1/32lFd5bVm1EKmxoA4SzvveIryXnbKzlJBM7Hz?=
 =?us-ascii?Q?PhuUmnGB39JTnx1d5Zf+t/5W/B9IFSjaRDWKf4P6sMipGTDg5JnGAHc3SLgs?=
 =?us-ascii?Q?GzzpSxmMgtUEd26jmRx3qnmcRSD2to7GQVRfgmfIJBX8+yyjlUrJvSfc4Bh1?=
 =?us-ascii?Q?IrSEPt+3HuzDs8OiLC8M3kj4mFQHlQtM9dSrdNHLmvbq7l4cZbkFNS7WMpIm?=
 =?us-ascii?Q?rdue6DSvrasfkIBNPu/bSWU1g2UZqAwIIJy/CdxGiR7/mFwDQIJBCXGtx87/?=
 =?us-ascii?Q?et9qhJf9MHUuWT0mi1DoR3DTDH3FzV8TGWny2inZ+xQa5uykNrURxI8jhHvp?=
 =?us-ascii?Q?4bF/OZ6vUUiBcs8eLgYQeQtbgt4nHS94jI9cmSjROUBlRhCHklSZxIUP2TdG?=
 =?us-ascii?Q?vnJNwIzsB6XiWuGPrcavoGUcljhtPtALrpLE9eZjW2a62ROY2j9SJ5B3/mdA?=
 =?us-ascii?Q?eRREFI9iqiWjLVK9iNGM6jMd62lti8Y8/RQ0ryvEvRuDElv8Pja1tNkLAHeB?=
 =?us-ascii?Q?b76ABi6WUYe4cczE2gnetEe0RdI1F8HbaM41heUSq959OZpDUSN3neOKbrMy?=
 =?us-ascii?Q?KUTSIEWXuHdn6RFtSUWKNZEMPG57kstGIfr/ksjr5FOwyF6xlig7YSdRoISW?=
 =?us-ascii?Q?eiMI+8iICRtOC6sSbt5sjr0hbjO0o6ypFLDZ2wSheD4Jg7xOyaOX4joJFGRi?=
 =?us-ascii?Q?3uHyUFO/zv55mKGFINQ//6PFmxLPaw29BdqLLUIudX5CwUZirPTIfHPCsUys?=
 =?us-ascii?Q?ZiJhTKdusOBkVdJ7n00OvPFaneag6CxySVnDxKsRB9Oj2EnJ1by/rlJpTO+Z?=
 =?us-ascii?Q?+sEp/s75/37QUgmkTSZNv1ffxA+ILM0Rv+qRPSzFO9PT4eyfNBCw9wFAKR3z?=
 =?us-ascii?Q?rraVIrw7hhnyD1mSAoxAh3dyaTiWQvrUq0Ogue9Hu3XmF4kM3nKOAUwjxXVz?=
 =?us-ascii?Q?oXWJLlK4YQuk3vycMYnqyqa5q/KwUsbDVjqD4ohAgFtQh/aGm2Bt49S3fgKb?=
 =?us-ascii?Q?9Of615GfLa6LmtHEOnTbSZ7ISgzcLLEgVKK0H+xWNICkSxHpjF/2dxSmnS/G?=
 =?us-ascii?Q?ZAWBolvLZMsQi3zp0iekBu8tjvoyX6X7xz2UgSfK8GXQRoXIX+Fhm8z3WuC/?=
 =?us-ascii?Q?oXc2FX74a7dydTOmeyZnq5y1XnEoyWW+AkiJ+Sbu691CRYBn993ELYUKNQyW?=
 =?us-ascii?Q?wFPUMGwXWUuVJ0IheKExj6oHSKIF2+BxA3ImDHKOEEJ8ndMZ2BFJ/HZT213x?=
 =?us-ascii?Q?SbOOHF9hqUxnKaWyugdCteSDbeU32dQ+2v/dxYl06EwjzqgDyNzpa3jGFyyd?=
 =?us-ascii?Q?XRLuyk/UnvHDbY6u+3zo4dCcrCYQFVsf4UZO1VlOLiQKsZe6R9EpePWbcfqI?=
 =?us-ascii?Q?UWeXv20fUr0GTxabqzBRZ8d5+NL0zusuosVBE/Is?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0:
	59wmv4W6pTTElkLCHITQTB2X+TGEMuGtONS+v2w16bS8SmidOgd4y+G/E4wtn65+arKt2J0fyKQLtU7xUY2OpeNswnbfHswQaAsEyCbMmH1nfAv8uYZxt+I/UhFgxhGjuwxSVNt7T4fROpyQmN/1CLZjd5NzRUM9S4tDxaUE49DBDLCvgydXFHe8nZ93PxyYvkYeVdXe3wrSsC5w0bPrEy327C9J7f8p5NEniGGpCK5GrPLpeQGuHH+2sf3JGRDTQCryQmp5SAcf59yctaZJWh/Kr7xXp6rT/CbgNF8jyd1D69cF4a0lODGQAva9tICRcc7marOnAoL3b6ahCcMUa2aTYZ0VLzitTkT0qt+Cigu9eOp02wH1qbEKatliqsTCWWBTnCKkJXC7cB2nHwsvBfVePSkk8pPXP8Y3ur3cEF3kHsF1UwKfu+Y9cBrCy28XrkP5xWgwxBAkOElswtN8mLn2quf/C9+v7IHp1RGTn2u9tSyzHNId95TSM1QZ3FY94RazofQfSWgrteVUXnZiDYGVyO0CET6NBHEKH+zmvvBNPlbVPsaYg3/+Bq9w35/BkLDhSsf1Y1//Kv99i7V70gBtTBZVcBh7a3wcRCGN4ju97Xq5P/or7/Cxjg/DXun1
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6575.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0ca4859a-608c-4292-e4bd-08dc4b20e1cc
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Mar 2024 10:06:17.8826
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: i0UiGLOQDIFUcXInNTIA/bq79iEdYXB16YaDMtWLATRnojlXQMRM+TiHD92H6pg14aJ3Vx7nDV/9/2eJ8lp3hw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB6444

Martin,
Can you take a look at this?
I have a follow-up series waiting.

Thanks,
Avri

> v2->v3:
>  - 2/4 - Clarify commit log (Bean)
>  - 4/4 - pass cmd_type to ufshcd_prepare_req_desc_hdr (Bean)
>=20
> v1->v2:
>  - Attend Bart's comments
>=20
>=20
> Device management commands are constructed for query commands that are
> being issued by the driver, but also for raw device management commands
> originated by the bsg module, and recently, by the advanced rpmb handler.
> Thus, the same code fragments, e.g. locking, composing the command,
> composing the upiu etc., appear over and over. Remove those duplications.
> Theoretically, there should be no functional change.
>=20
> Avri Altman (4):
>   scsi: ufs: Re-use device management locking code
>   scsi: ufs: Re-use exec_dev_cmd
>   scsi: ufs: Re-use compose_dev_cmd
>   scsi: ufs: Re-use compose_devman_upiu
>=20
>  drivers/ufs/core/ufshcd.c | 204 ++++++++++++++++----------------------
>  include/ufs/ufshci.h      |   2 +-
>  2 files changed, 87 insertions(+), 119 deletions(-)
>=20
> --
> 2.42.0