Subject: Re: [RFC PATCH 20/22 -v2] Add latency_trace format tor tracer
From: Daniel Walker <dwalker@mvista.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
       Linus Torvalds <torvalds@linux-foundation.org>,
       Andrew Morton <akpm@linux-foundation.org>,
       Peter Zijlstra <a.p.zijlstra@chello.nl>,
       Christoph Hellwig <hch@infradead.org>,
       Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
       Gregory Haskins <ghaskins@novell.com>,
       Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
       Thomas Gleixner <tglx@linutronix.de>, Tim Bird <tim.bird@am.sony.com>,
       Sam Ravnborg <sam@ravnborg.org>, "Frank Ch. Eigler" <fche@redhat.com>,
       Steven Rostedt <srostedt@redhat.com>
In-Reply-To: <20080109233045.411814804@goodmis.org>
References: <20080109232914.676624725@goodmis.org>
	 <20080109233045.411814804@goodmis.org>
Content-Type: text/plain
Date: Wed, 09 Jan 2008 19:41:45 -0800
Message-Id: <1199936505.18203.18.camel@imap.mvista.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 791
Lines: 22


On Wed, 2008-01-09 at 18:29 -0500, Steven Rostedt wrote:
> +enum trace_flag_type {
> +       TRACE_FLAG_IRQS_OFF             = 0x01,
> +       TRACE_FLAG_NEED_RESCHED         = 0x02,
> +       TRACE_FLAG_NEED_RESCHED_DELAYED = 0x04,
> +       TRACE_FLAG_HARDIRQ              = 0x08,
> +       TRACE_FLAG_SOFTIRQ              = 0x10,
> +       TRACE_FLAG_IRQS_HARD_OFF        = 0x20,
> +};

You've got some errant flags here .. TRACE_FLAG_NEED_RESCHED_DELAYED is
-rt only , and TRACE_FLAG_IRQS_HARD_OFF is unsed (and sort of a
relic) ..

Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/