Received-SPF: pass (google.com: domain of linux-kernel+bounces-112391-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Frank Li <Frank.Li@nxp.com>
Date: Sat, 23 Mar 2024 11:34:51 -0400
Subject: [PATCH v3 2/5] dmaengine: fsl-edma: add safety check for 'srcid'
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <20240323-8ulp_edma-v3-2-c0e981027c05@nxp.com>
References: <20240323-8ulp_edma-v3-0-c0e981027c05@nxp.com>
In-Reply-To: <20240323-8ulp_edma-v3-0-c0e981027c05@nxp.com>
To: Vinod Koul <vkoul@kernel.org>, Rob Herring <robh@kernel.org>, 
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, 
 Conor Dooley <conor+dt@kernel.org>, Peng Fan <peng.fan@nxp.com>
Cc: imx@lists.linux.dev, dmaengine@vger.kernel.org, 
 linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, 
 Frank Li <Frank.Li@nxp.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RDlwY3k5T05BQVpzU0FKOVY0N2N0dWJNeDZlTXJoSHhRQy9CK01lMGgxM3FS?=
 =?utf-8?B?WlNNWmRUL3hXZ3IxU1RlVjJ2VmRjL1FQWExJdkJMa0hDTTMxSys0SzNrVE8x?=
 =?utf-8?B?TDg1K1hYcE5rbzRyMC9ta29ZZTNYcnQ3NzJrcFlqSGtuOUEvVmRJSTVGcFdv?=
 =?utf-8?B?cnpUcTFlVGU3WVVPei8vY3FGcTBxUGNxNStNY2wyWkhSZnREVHpmQi9rR0ha?=
 =?utf-8?B?eVBaYWswWDc4bXVycCtkbWtyUUVVOE1QbXR5eitMQnZqZVNINVEzQWVGQnZU?=
 =?utf-8?B?UStNWnZVWU9XR1lVeDM0c0hwNnRJM2ZEN1o2MTJXM3VQNmpmVXBLZFcxOGRj?=
 =?utf-8?B?ZTRXK2laRDVRbXc0bmtJelJtZERmZFVVc1IrV2hocmFiS0NwMkVSSkRYMnIx?=
 =?utf-8?B?NlhjSnRxa2RTd3gwcTZPbHZpRW5vRWtvc0locjI5eUtXcm5HdG9mdlVkeHVZ?=
 =?utf-8?B?YWN3QkFGb3BFaG5YaDZyV3Zybkp3YmlxN0hjVWR6WTlwUXh4ajZLZVc5N29o?=
 =?utf-8?B?UGUzYTJCdkgzc3lEQmhHRW9aaW9UWUJTT0g1amRtdUZPMUFuYThaTU1tQkx6?=
 =?utf-8?B?TFZBQzkzU2Z2bllMK1hVUjhMb0puWG5OOVh0c0dDcVNKMHhiTVR4THY2K0pk?=
 =?utf-8?B?SnZRSVVUM3NySWk4eFdEK2x3VUtPNnlySmNtdGNjeGxKQTZtNTBFbTFJeFhL?=
 =?utf-8?B?OXBvRHNLK2wwekVsSHN3Y3ZpT0VhMVBjRGlEQ1NFK2hFVDJVZ0I4dFBXd1Nw?=
 =?utf-8?B?NFRCc0pUeFJGVkg0NW9JZVhjYWRuUUNMNHNMZlhFM0kvL0x1dW1pbks3RUky?=
 =?utf-8?B?K005YmYxOXdHbENzclJNaGxyTkFRM3hHNVVoYk5RYmNDanJ2MmhZZ0VLS0ND?=
 =?utf-8?B?ZGNvTXdMaWRucTRNUkxEbWtwNHhPWTd1WFZ6NHlybm9XODI4QkJWM3hzWkpN?=
 =?utf-8?B?LzI4RjZidG12clNHLzY1RnNLTUllWHl5QjhlNk5YYWRGZ214UFUrQit6RW8w?=
 =?utf-8?B?LzROajJaOEFHdmluV21XNVJ3ZUNzc1BVLzVJMWdkZU1xbWpoaC9LRkx3RUQy?=
 =?utf-8?B?cUdqRWVjL3J2YUc0K2JxNjA1czlrb0hIVHlBUUtncGxtQnB4Vk9yUTMvVGVF?=
 =?utf-8?B?b3JVVmYyR0pOWGhQcmpzU3pIcktxUVl4eDl6WFZRdElTbDhQYUVabE9sVmNG?=
 =?utf-8?B?WDZqRmV1WG9OUmZuRVVHRm15RjdadXdjS3NwRDFvUkdEYWVWWTlydGNGb1Fs?=
 =?utf-8?B?NEZnT3FPOUs5YW5aUWtoUDlLeWJxWWZaYXA0TFVuOTMza2xsNlFuOWFPdnd5?=
 =?utf-8?B?WHhTMGVkdVkrRDlreUNDbDFpbnpoSVdQQm8zVWpkUHQ3bks5dm9jYzNxMEpE?=
 =?utf-8?B?a1U2enNQYzJWL01WcXcrODFXdXVocmV0NmFEV1huVmFlR3VFd3Yybks1MUpJ?=
 =?utf-8?B?YmpwK3V1V1g1cHhUTjZWaC9WT0djR0dWTHNoN1FxN0M1OHBWU3Z6aGk3SlRG?=
 =?utf-8?B?aFpXYiswVHV6LythK2RvVjA5ZEdnbGFJMlRBazBpNWJEU0packtiV0s5YVdz?=
 =?utf-8?B?T3c2QS8yd1NDTy9GbXc5SGcyc0wxemxQN2RYa0EwcUo3Wm83UlNSZkUrYVJG?=
 =?utf-8?B?K2pCK05OcURSSkRWTlR2NUNmMlliZ0xveCt0WTArRGlqb2t2RzZ4Qys1TWFr?=
 =?utf-8?B?TXkvSkhIcXV3V1hjVkRqQU9aZEhXVy9TTVUwQzBVZHdqaUFEL2p4Zm05V2xW?=
 =?utf-8?B?V1N6d2cwK2ZZREgyMHRIMVo1RlNjaTRUVFpsSzlaTDdQOXJFbDByWnFBNzVF?=
 =?utf-8?B?aXRKOWUzRERINThpT1ArdDQzbVNkNHh5TUV0RDJ3R25ubDZ1dS9pYkdKQnpm?=
 =?utf-8?B?UUxLdkFCNlFIN040WGUwVVF1QlFTTFFYUHF5bXcvbGpGdUx5VGYvWEpIdmVO?=
 =?utf-8?B?VHkzeko4aXk4bFNqOWdiVkJFTndiaFF3dWFVdk5JWmxYVmJlNnFaenJ4Mml5?=
 =?utf-8?B?UDc0UWZ4TFVNdDFEWlQ0ZDVVMEZ3R0pEUDZTU3g5aFJFbEJTVm51MG03SXZN?=
 =?utf-8?B?VHB3dGxrS1lFdHF6eXI5NkFtVm9HRFRNa1l2Snp1eHFETHRyWUpOWUl1WDI2?=
 =?utf-8?Q?u0blqYIynPT9MwajJHkNwEWQS?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7fb7e83f-8cbd-4363-7c28-08dc4b4ed945
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2024 15:35:20.5287
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OWyf9jPAKBFI3CoMW+af96DdHvE2fKLsF8a2mBnSEcaFUkQHvTgZaqwSNANUy79UVTm+KpXgxLSQlpLvy6B1+A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7981

Ensure that 'srcid' is a non-zero value to avoid dtb passing invalid
'srcid' to the driver.

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 drivers/dma/fsl-edma-main.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/dma/fsl-edma-main.c b/drivers/dma/fsl-edma-main.c
index 0a6e0c4040274..2148a7f1ae843 100644
--- a/drivers/dma/fsl-edma-main.c
+++ b/drivers/dma/fsl-edma-main.c
@@ -115,6 +115,13 @@ static struct dma_chan *fsl_edma_xlate(struct of_phandle_args *dma_spec,
 				chan->device->privatecnt++;
 				fsl_chan = to_fsl_edma_chan(chan);
 				fsl_chan->srcid = dma_spec->args[1];
+
+				if (!fsl_chan->srcid) {
+					dev_err(&fsl_chan->pdev->dev, "Invalidate srcid %d\n",
+						fsl_chan->srcid);
+					return NULL;
+				}
+
 				fsl_edma_chan_mux(fsl_chan, fsl_chan->srcid,
 						true);
 				mutex_unlock(&fsl_edma->fsl_edma_mutex);

-- 
2.34.1