Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp1817774lqp; Sat, 23 Mar 2024 09:57:28 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUOlKGLA3GslB6HpgaRXw1J/i+/xYaXXkCrNwRlf6hKfeTR7RZl6MOJQBNGhIRNL3mBDPqDRumr71X0EbHas2GIZlkdxKM2WOXx9XDG1Q== X-Google-Smtp-Source: AGHT+IF5umidtx4CUR89oCU1aFbck6eoXtW2yqxxWVCe/TroMBU7Sh5gHQsrDoXTd5Ydi0q/I8V+ X-Received: by 2002:a05:620a:385:b0:789:ec27:d478 with SMTP id q5-20020a05620a038500b00789ec27d478mr2565764qkm.75.1711213048519; Sat, 23 Mar 2024 09:57:28 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711213048; cv=pass; d=google.com; s=arc-20160816; b=h1NWdJAqZba2mkYpQ8YmMalDRgiReV4jytZ+0rBL03eyqxw9U9Z0CXGMreRJY46fEC at5BUjg2z/LRiNseNcHucAo9Un+D1FGSdYNwn53QBhJXaPwSPQVD2kfyfRTBGRvLHQ5Y JP1yHtq1tDQtmlATp0ows2QjXKvmRUETmQVG3X2O7YGfX67TIp9bif5aeNLO9Vt1M5Pc zXuk7Kkdeuq3HmR8BbBrhilkWmEJx+KbuXZd0ZWm508vmjw3lNx8rL80FQffdKgJhLGy WICVudc3641MWY0/A2iqSpO8QYnKY8pflu9FQ2UsHajTP0OnOERY9voPou+7luAFxznP qfsQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=ui-outboundreport:content-transfer-encoding:in-reply-to:from :content-language:subject:references:cc:to:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=Mm4VZjgznOtn+DsFuQ/+wbzhd9T3mnnR8PtcFlTVgYU=; fh=msQX0bXlpXU8dvt23xjX2Xh1f8oZzsH4tUVrPMc2hbg=; b=UftWmwYQNX1oX4erXTi4YxPe9KlUbiqGTGQzf4dV5Jbrb0ZELYZXV7wmTD0pyQP4le 96qXM7fXQOWCmVqizryxM3SGxXXOQwUFnIcHB+MuBrVN7MeWcPGbWY63gqsWgT7fmbNl 2n5wlmIGSoOVLH+QXKnEANi1N2kpsyIvRZaWzDNZ2aSyv9JK6J/5icQ23O0ysCcs3fLL aEEuP1fXAJqdSZLRN0FMn3u3/67WSvYFkSJ6ty2dD/HMwFVD/qolbkab35/kcohOfVGF DwNqC1ftxvo4GgPPqkVKZ7lC33umbpdVCx/fm1RxexNRDfpH/VLqLEwKS8fcNlZW171m 0F2w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=lIVm9CBQ; arc=pass (i=1 spf=pass spfdomain=web.de dkim=pass dkdomain=web.de dmarc=pass fromdomain=web.de); spf=pass (google.com: domain of linux-kernel+bounces-112417-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-112417-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id h4-20020a05620a21c400b0078a1cb844a1si2015052qka.733.2024.03.23.09.57.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Mar 2024 09:57:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-112417-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=lIVm9CBQ; arc=pass (i=1 spf=pass spfdomain=web.de dkim=pass dkdomain=web.de dmarc=pass fromdomain=web.de); spf=pass (google.com: domain of linux-kernel+bounces-112417-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-112417-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 3973F1C20BC5 for ; Sat, 23 Mar 2024 16:57:28 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5E5EC51C49; Sat, 23 Mar 2024 16:57:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="lIVm9CBQ" Received: from mout.web.de (mout.web.de [212.227.15.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DCCAB3A1A3; Sat, 23 Mar 2024 16:57:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.15.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711213036; cv=none; b=HIbxia3dmr+R48cUTXB86uX6CW3RwaILMZje098ulDY78k2y1Yti4fKKQNSsvTaJ0I+RIu8SGVTUOhgPoQo85T/pyd+iU+BOi5/7g58xPwG1CRrZKzlNJB9TrUn0/MCcQcJnJ6dtT7ySCi+IojegJPct+u8xyD/yrDB2GufHzOU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711213036; c=relaxed/simple; bh=95s1LxwD46f3RtcC8PeuotIjmcLiiX0ljaeHhJykyOM=; h=Message-ID:Date:MIME-Version:To:Cc:References:Subject:From: In-Reply-To:Content-Type; b=aOuKaaf8Sa7k25Z6EW+4QCmlTIJ9GcFS2QNH0lD0MwM6cQ4AP5pIxgb31XEi2keOJWcW6tatrylDbhtn53E8ToZYaP0iczlpyvynqwJfqTFbveRjmoQTGevw+wZ3nGmuDBoqkmnVfy/TGg7sr0PRPbPJlTpXQEYNdyMv64eyUeE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de; spf=pass smtp.mailfrom=web.de; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b=lIVm9CBQ; arc=none smtp.client-ip=212.227.15.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1711212994; x=1711817794; i=markus.elfring@web.de; bh=Mm4VZjgznOtn+DsFuQ/+wbzhd9T3mnnR8PtcFlTVgYU=; h=X-UI-Sender-Class:Date:To:Cc:References:Subject:From: In-Reply-To; b=lIVm9CBQIGpAwxCkaZ/3KyokahHzcoIXCHe0iQFkB0bp75KLBDjin1OvQpffK7pA oLoEiZTVGh8Z+q/dQZT2v7npFVyOp/egYZEdV3zrswAapQ7SIf9SHtUTha8WSFdQy oE9TrrhEqZgJ520C2IZ1b/3t3UYIeSrSdRTz7x2cluIoZBSdeanstrgnYYXAZrjrx OvoxFZXdrCHM1d7S0zduv7Gz++qNT/j9+zXhIJbLuLt5jb/Uc/7sGxMQhRJAn7PjK I2F5jr9oVZJGJWRJYVyvgFviqygSbYDspBkSenBrcjLh2Qs72EkN7appBIXl24scR 7uNvUhm+nv/pafIxwA== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.90.95]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1M1rPI-1rlrkQ06jA-00EeCJ; Sat, 23 Mar 2024 17:56:34 +0100 Message-ID: <08c9f970-3007-461a-b9f9-9ab414024f68@web.de> Date: Sat, 23 Mar 2024 17:56:29 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Dan Carpenter , kernel-janitors@vger.kernel.org, netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, smatch@vger.kernel.org Cc: LKML , Alexander Lobakin , Andy Shevchenko , David Laight , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Jesse Brandeburg , Jiri Pirko , Jonathan Cameron , Julia Lawall , Kees Cook , Lukasz Czapnik , Paolo Abeni , Pucha Himasekhar Reddy , Dan Williams , Maciej Fijalkowski , Przemek Kitszel , Tony Nguyen References: <0efe132b-b343-4438-bb00-5a4b82722ed3@moroto.mountain> Subject: Re: [PATCH v2 net] ice: Fix freeing uninitialized pointers Content-Language: en-GB From: Markus Elfring In-Reply-To: <0efe132b-b343-4438-bb00-5a4b82722ed3@moroto.mountain> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:kiRndK7BLuqFNuvVd1HXr4cnMYe9v3VzpVM5ramyWfnyTZFlD9k jDgrNy/xc1Igrw6zJX46ksdqOAEaGXkpq//gCpiR7kVDv+sqxUcItMvJ9uF8RqEuJgG3Psc bfZ0khznwVaXT/soerN977m+mA6ciDIR3eJjMnc1Zn/5R6DorbePBTrGJBGkegEP4/45eTO zx/KKh7vxXRssW+vjn9xw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:PMFs1vMvo1c=;MP5SqoEPyH6wB6JcLKh21elBcjh ORtQoEW8RXCAUKrYrlNE59jzLNMV4ffv/gcBPaSMk2F2DY4OE3Hp4ruvt3MHqXLEq4pUgEJ7G R4BgRVjxnP4iemqB74azluTGiDDxszrrptAyBKWD1izc9Vw6I4VV73FBWutkJgFDhOnXBI/1v 0mVlZ3WG+8cMGzg3UhmdlvZRxStcd3M5Sc/1eDfsYHIij7jlpGOdkr3cMpvwaQDxht6dSV1FH LkNgX1QR8PFqHTGfY6K77hB2tRDE9cJa2jJ/1sMWjNs9mduY2PMW7fTQ0S+oAf2+O9dSa1vpt vCpvcIq9hjELeVqs0nVNPoioeO64S01tIuwJcssYpx/M/NN+RYyGXDZsa9Y5v9CEmz2jpZra0 a2YqPXAjfjmHkuqGvfZJNyb3fdcDFeY+5WXzKL36srPqdXQe6oG+iaS2KThnVjNKXjQ7Ylq83 zUfcmsZaV7PD1ralRp4lVtRSAWbVsHTvJqoTGMrNM+SWdvoWXXajbtNZficqydKbtgmPIsEgq txTFb+Dy+tXEOB9t15MZ4O5hPYSo5hOyffgbRO4w/EJZdmQQ8ruKnxGL7VShHI6viVBlB6qfW VTirBVHcSYXFWtVxxpZuYmWmC9AYJbZP+qij1k83/g/JBVjTUTQ5XjJA0BwEWwBK/ggLBS8Gm Tb/N+/ouJRfuMwuf6vXdQ+a3codQtXH2fUqW8h5qG/ocF3XK0CN2bGBvx2cpdF0FZ/Zu42R+0 yz3Z9pZgDoUzUOz6MoZGy6UCZvfNxcLFAXtbtK2nLF6W2dC+S0dKI4nQM30UhDP0u7RLarx2J KGOxkTrXY0NN10C4Z1pMBBpnffSQg/tebkWXHo8Gflr/A= > Automatically cleaned up pointers need to be initialized before exiting > their scope. In this case, they need to be initialized to NULL before > any return statement. * May we expect that compilers should report that affected variables were only declared here instead of appropriately defined (despite of attempts for scope-based resource management)? * Did you extend detection support in the source code analysis tool =E2=80= =9CSmatch=E2=80=9D for a questionable implementation detail? Regards, Markus