Received-SPF: pass (google.com: domain of linux-kernel+bounces-112444-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <38d576a3-0f4e-4410-aa9b-74e06e1fceb1@rock-chips.com>
Date: Sat, 23 Mar 2024 18:10:24 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] drm/rockchip: vop2: Remove AR30 and AB30 format support
To: Heiko Stuebner <heiko@sntech.de>, Sascha Hauer <s.hauer@pengutronix.de>
Cc: heiko@sntech.de, hjc@rock-chips.com, dri-devel@lists.freedesktop.org,
 linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
 linux-rockchip@lists.infradead.org
References: <20240304100952.3592984-1-andyshrk@163.com>
 <ZeWlAWLvlW3NdKS_@pengutronix.de>
Content-Language: en-US
From: Andy Yan <andy.yan@rock-chips.com>
In-Reply-To: <ZeWlAWLvlW3NdKS_@pengutronix.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Heiko,

Could you please  to take a look at this patch?

On 3/4/24 18:40, Sascha Hauer wrote:
> On Mon, Mar 04, 2024 at 06:09:52PM +0800, Andy Yan wrote:
>> From: Andy Yan <andy.yan@rock-chips.com>
>>
>> The Alpha blending for 30 bit RGB/BGR are not
>> functioning properly for rk3568/rk3588, so remove
>> it from the format list.
>>
>> Fixes: bfd8a5c228fa ("drm/rockchip: vop2: Add more supported 10bit formats")
>> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
>> ---
> 
> Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
> 
> Sascha
> 
>>
>>   drivers/gpu/drm/rockchip/rockchip_vop2_reg.c | 2 --
>>   1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c b/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c
>> index 48170694ac6b..18efb3fe1c00 100644
>> --- a/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c
>> +++ b/drivers/gpu/drm/rockchip/rockchip_vop2_reg.c
>> @@ -17,9 +17,7 @@
>>   
>>   static const uint32_t formats_cluster[] = {
>>   	DRM_FORMAT_XRGB2101010,
>> -	DRM_FORMAT_ARGB2101010,
>>   	DRM_FORMAT_XBGR2101010,
>> -	DRM_FORMAT_ABGR2101010,
>>   	DRM_FORMAT_XRGB8888,
>>   	DRM_FORMAT_ARGB8888,
>>   	DRM_FORMAT_XBGR8888,
>> -- 
>> 2.34.1
>>
>>
>