Received-SPF: pass (google.com: domain of linux-kernel+bounces-112445-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Sat, 23 Mar 2024 18:29:18 +0000
From: Jonathan Cameron <jic23@kernel.org>
To: David Lechner <dlechner@baylibre.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>, Michael Hennerich
 <michael.hennerich@analog.com>, Nuno =?UTF-8?B?U8Oh?= <nuno.sa@analog.com>,
 linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iio: adc: ad7944: simplify adi,spi-mode property
 parsing
Message-ID: <20240323182918.2cf624b6@jic23-huawei>
In-Reply-To: <CAMknhBETEP123=EHycGtFEJjQ+NPssLXmw9ZdDoY8CRsWiSxVQ@mail.gmail.com>
References: <20240319-ad7944-cleanups-v2-1-50e77269351b@baylibre.com>
	<CAHp75VeO_=r_pMBUTaQQYKDRAV-OVfTnPYPwV8f7KDzOhaBCvQ@mail.gmail.com>
	<CAMknhBETEP123=EHycGtFEJjQ+NPssLXmw9ZdDoY8CRsWiSxVQ@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Tue, 19 Mar 2024 10:28:31 -0500
David Lechner <dlechner@baylibre.com> wrote:

> On Tue, Mar 19, 2024 at 10:01=E2=80=AFAM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> >
> > On Tue, Mar 19, 2024 at 4:28=E2=80=AFPM David Lechner <dlechner@baylibr=
e.com> wrote: =20
> > >
> > > This simplifies the adi,spi-mode property parsing by using
> > > device_property_match_property_string() instead of two separate
> > > functions. Also, the error return value is now more informative
> > > in cases where there was problem parsing the property. =20
> >
> > a problem
> >
I'll fix that up.

> > ...
> > =20
> > > +       ret =3D device_property_match_property_string(dev, "adi,spi-m=
ode",
> > > +                                                   ad7944_spi_modes,
> > > +                                                   ARRAY_SIZE(ad7944=
_spi_modes));
> > > +       if (ret < 0) {
> > > +               if (ret !=3D -EINVAL)
> > > +                       return dev_err_probe(dev, ret,
> > > +                                            "getting adi,spi-mode pr=
operty failed\n"); =20
> > =20
> > > -               adc->spi_mode =3D ret;
> > > -       } else { =20
> >
> > Actually we may even leave these unchanged
> > =20
> > >                 /* absence of adi,spi-mode property means default mod=
e */
> > >                 adc->spi_mode =3D AD7944_SPI_MODE_DEFAULT;
> > > +       } else {
> > > +               adc->spi_mode =3D ret;
> > >         } =20
> >
> >        ret =3D device_property_match_property_string(dev, "adi,spi-mode=
",
> >                                                    ad7944_spi_modes,
> >
> > ARRAY_SIZE(ad7944_spi_modes));
> >        if (ret >=3D 0) {
> >                adc->spi_mode =3D ret;
> >        } else if (ret !=3D -EINVAL) {
> >                        return dev_err_probe(dev, ret,
> >                                             "getting adi,spi-mode
> > property failed\n");
> >        } else {
> >                /* absence of adi,spi-mode property means default mode */
> >                adc->spi_mode =3D AD7944_SPI_MODE_DEFAULT;
> >        }
> >
> > But I can admit this is not an often used approach.
> > =20
>=20
> I think Jonathan prefers to have the error path first, so I would like
> to wait and see if he has an opinion here.
I do prefer error paths first.  Thanks.

Jonathan