Received-SPF: pass (google.com: domain of linux-kernel+bounces-112470-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Thomas Gleixner <tglx@linutronix.de>
To: Tianyang Zhang <zhangtianyang@loongson.cn>, chenhuacai@kernel.org,
 jiaxun.yang@flygoat.com
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Baoqi Zhang
 <zhangbaoqi@loongson.cn>, Biao Dong <dongbiao@loongson.cn>
Subject: Re: [PATCH V3] irqchip/loongson-pch-pic: Update interrupt
 registration policy
In-Reply-To: <648e7f23-a2e0-ce8f-7c52-3bcda262de86@loongson.cn>
References: <20240319124629.23925-1-zhangtianyang@loongson.cn>
 <878r2di3ak.ffs@tglx> <648e7f23-a2e0-ce8f-7c52-3bcda262de86@loongson.cn>
Date: Sat, 23 Mar 2024 21:05:17 +0100
Message-ID: <8734sghfya.ffs@tglx>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

Tianyang!

On Fri, Mar 22 2024 at 18:14, Tianyang Zhang wrote:

Please do not top-post. See the 'Top-posting' chapter in:
https://people.kernel.org/tglx/notes-about-netiquette 

> Regarding "WHY", my understanding is that a convincing reason is needed 
> to explain the necessity of this patch.

Yes.

> If so, can the last paragraph "This will be more conducive to fully 
> utilizing existing vectors to support more devices."
>
> be considered a simple explanation?

Kinda, but ideally you describe it in a way that there is context for
the reader. Like this:

  The fixed mapping between the LS7A interrupt source and the HT
  interrupt vector prevents the utilization of the full interrupt vector
  space which limits the number of devices in a system

  Replace the fixed mapping with a dynamic mapping which allocates a
  vector when an interrupt source is set up. This avoids that unused
  sources prevent vectors from being used for other devices.

See?

Thanks,

        tglx