Received-SPF: pass (google.com: domain of linux-kernel+bounces-112490-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Sat, 23 Mar 2024 18:35:48 -0300
From: Marcelo Schmitt <marcelo.schmitt1@gmail.com>
To: David Lechner <dlechner@baylibre.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
	Marcelo Schmitt <marcelo.schmitt@analog.com>, lars@metafoo.de,
	Michael.Hennerich@analog.com, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: iio: adc: Add AD4000
Message-ID: <Zf9LNPv16wsPsZA6@debian-BULLSEYE-live-builder-AMD64>
References: <cover.1711131830.git.marcelo.schmitt@analog.com>
 <81665b5f0d37d593e6d299528de8d68da8574077.1711131830.git.marcelo.schmitt@analog.com>
 <20240323184454.201edbc3@jic23-huawei>
 <CAMknhBFRa-AwM3o-AdDDmPnwLAer8x=9TJNasSbY2bu5h9mMdQ@mail.gmail.com>
 <CAMknhBFZa4eQ1bbJQb+ESZdsbLh5xSBn+feMwmWbc58mT2UWPA@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAMknhBFZa4eQ1bbJQb+ESZdsbLh5xSBn+feMwmWbc58mT2UWPA@mail.gmail.com>

On 03/23, David Lechner wrote:
> On Sat, Mar 23, 2024 at 3:18 PM David Lechner <dlechner@baylibre.com> wrote:
> 
> ...
> 
> > Here is what I would consider a reasonably complete binding for the
> > AD40XX chips (excluding ADAQ for now as I suggested).
> 
> I missed one...
> 
> I also think it makes sense for the High-Z mode selection to be a DT
> property since needing to enable it or disable it depends entirely on
> what is connected to the analog input pins.
> 
> ---
> 
>   adi,high-z-input:
>     type: boolean
>     description:
>       High-Z mode allows the amplifier and RC filter in front of the ADC to be
>       chosen based on the signal bandwidth of interest, rather than the settling
>       requirements of the switched capacitor SAR ADC inputs.

ok, will do the suggested changes, including provide AD and ADAQ in separate patches.

Thanks,
Marcelo