Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp1922783lqp; Sat, 23 Mar 2024 15:26:07 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCX8qKg/cdIRHRnR7sAmC6McOFP0akyPf2DELQTfMryeoATIilJtZAmyHlTZqQ5NS/CtnbMlx8fIDbSz7F3gGT9+7VFJlVcqNiwajsegeA== X-Google-Smtp-Source: AGHT+IHlM9G5B5rfuKFQRlKl0KRftWQsGPF5bjzaDz5tZSvBF+uA2JlbE9A4vO+u2g0YZZdyjdDp X-Received: by 2002:a50:9984:0:b0:56b:f2d6:4be1 with SMTP id m4-20020a509984000000b0056bf2d64be1mr2298337edb.4.1711232766767; Sat, 23 Mar 2024 15:26:06 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711232766; cv=pass; d=google.com; s=arc-20160816; b=mbnQeerNWzL3I9AL66KNx5L4HMR+dZcuWKtEpsWLmgwZ1johNcb696HJev8VoaDULJ F0S8VsWyCwEYpCD+DuPRFyoL5PpMBHGaw35RHQOHuNGbQ4Vl1OAd5+vf+/JCq+/sNb8+ UD3q+sTBwnBxFTH6Mr34/9hG9Mue2CqU2Eiaey4jUzf7FkBEvTEGanr2zy9BUMztWYiv XhshHLhG8Hbv06RCMhhSTtN7wlHazyvVU2Vrq7g0zR1Q44Sj0YUyY4qpz46TG8N8xBce 6ShTDLG5vlYZXLYozLYNGnkWwwbSeh+FzGF0YIHNuYUW9BXJNmYuj52E8LTzSZJmHZZp h2pg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=S9qKN3rr+FvnUj2R5c4tNQZmaB108poPnd4hRyAjl10=; fh=KVbO9j5hDKeZuR5Jwe3JBmgV887BQU5YfnxMFC4PZwc=; b=pQoJjGPghrMYxBgg4/rfjjXCM8RysX8jOAffVfYmukgM/xt9QAntTAsFWX3vXI46mv XtSVqTsEgTogQMSUe2tnj22R23tkk9XaVxhwu+t1r/legiUQpwlep47c2jdx/eHl10/0 zLPjLyPNBNj7HvZbbkpTWR1fbKz8JvNcWD9fA4qxgriRy7hohmyvdsjZYjFAZLk0cUn0 1CFlzE0rEKgYKdivRUZ6Y9GsW60YiUefiLrsW48jxrqYA8ruQSUySatNBaz4bKUEXAQx 4IYFnn+QibCEFb9IeHSQIoKa6FWfhASTQQh4M/0s+OBXGxnnbw1NkcS3H1ZEnQgBrH7z 5UhQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=ZpKczV2m; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-112503-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-112503-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id cz8-20020a0564021ca800b0056be8b62bdfsi1145216edb.534.2024.03.23.15.26.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Mar 2024 15:26:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-112503-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=ZpKczV2m; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-112503-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-112503-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 7739C1F21300 for ; Sat, 23 Mar 2024 22:26:06 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8A2535B68F; Sat, 23 Mar 2024 22:25:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="ZpKczV2m" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E218A5A4C6; Sat, 23 Mar 2024 22:25:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711232751; cv=none; b=Z/9fQz7f1YL4Fryb3iZ+j81GJD3PJMMkk9H/MAHLy6GbzBmFEEhUj+ypK2q7qpyQmKk0qcpYJ/H0Ld1osI5j2pWDd0s7pwX2g2ZUgCH5DW9Y5fd4ZexBb44Cyj8k/s9PfcXyxM4qxwrK8rO861oqDmwYtQHmIri4f+dUGHMZFjk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711232751; c=relaxed/simple; bh=5ywmwSOANCwvmN60cHoKWbVHRtpgvPfzhKz4OyO0kz0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hOXh9VGQkQg+lz0wR5OSs7UmkAHfc2HOq7rUKczlCsCMzC/vL5E5rT8oNze0sL3d5wd+hipaZ3sOPol/6oylAmPadERRxF/b173/AfTKHhQ5XXmzxRB7eAXXlldKjS6qGU53uL8S2nCr6WLX3H8TPk/EU6FDUw7fMIsHmTA3uS0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=ZpKczV2m; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=S9qKN3rr+FvnUj2R5c4tNQZmaB108poPnd4hRyAjl10=; b=ZpKczV2m/VB39yMBjAqTJcrUvJ C56/29nH+DoG/tTV3FC8bWOVOeyUX+kI4rwjp8g5+NdBf1nBBBqW/0YwHa00OrHiuoPwGXLbuMXkH NWlhxQandRmtoRS1b5E8Y7ej+fW+h6aK0DFiAlGtd7MYvWUXYt+PKkXPqiOFpMU79M9o=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1ro9o6-00B4TF-7t; Sat, 23 Mar 2024 23:25:42 +0100 Date: Sat, 23 Mar 2024 23:25:42 +0100 From: Andrew Lunn To: Alexei Starovoitov Cc: Daniel Hodges , netfilter-devel , Network Development , Alexei Starovoitov , Pavel Machek , Lee Jones , linux-leds@vger.kernel.org, Daniel Borkmann , bpf , LKML Subject: Re: [PATCH 1/3] leds: trigger: legtrig-bpf: Add ledtrig-bpf module Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: > A new kernel module just to call this helper? > Feels like overkill. Can it be a part of generic led bits? > btw, have you looked at net/netfilter/xt_LED.c ? > netfilter had the ability to blink led for a long time. > I'm curious whether folks found it useful. This might become more useful now that we have support for PHY & MAC LEDs. You can use the netdev trigger for the usual things an RJ45 LED shows: link, rx/tx activity, link speed etc. But they are just Linux LEDs, you can also use them for heartbeat, disc IO, tty IO, or xt_LED. xt_LED would actually make sense for an LED in a RJ45 socket. Andrew