Received-SPF: pass (google.com: domain of linux-kernel+bounces-112527-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <4a81b4cc-90fd-415d-83c1-fe0f0ca7cac9@infradead.org>
Date: Sat, 23 Mar 2024 17:29:42 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] tracing: Fix documentation on tp_printk cmdline option
Content-Language: en-US
To: Vitaly Chikunov <vt@altlinux.org>, Thomas Gleixner <tglx@linutronix.de>,
 "Steven Rostedt (Red Hat)" <rostedt@goodmis.org>, linux-doc@vger.kernel.org,
 linux-kernel@vger.kernel.org
Cc: Jonathan Corbet <corbet@lwn.net>
References: <20240323231704.1217926-1-vt@altlinux.org>
From: Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20240323231704.1217926-1-vt@altlinux.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 3/23/24 16:17, Vitaly Chikunov wrote:
> kernel-parameters.txt incorrectly states that workings of
> kernel.tracepoint_printk sysctl depends on "tracepoint_printk kernel
> cmdline option", this is a bit misleading for new users since the actual
> cmdline option name is tp_printk.
> 
> Fixes: 0daa2302968c ("tracing: Add tp_printk cmdline to have tracepoints go to printk()")
> Signed-off-by: Vitaly Chikunov <vt@altlinux.org>

Reviewed-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
>  Documentation/admin-guide/kernel-parameters.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index bb884c14b2f6..623fce7d5fcd 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -6599,7 +6599,7 @@
>  			To turn off having tracepoints sent to printk,
>  			 echo 0 > /proc/sys/kernel/tracepoint_printk
>  			Note, echoing 1 into this file without the
> -			tracepoint_printk kernel cmdline option has no effect.
> +			tp_printk kernel cmdline option has no effect.
>  
>  			The tp_printk_stop_on_boot (see below) can also be used
>  			to stop the printing of events to console at

-- 
#Randy