Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp2026937lqp; Sat, 23 Mar 2024 22:57:20 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVj+sOZfOyY6xqiCPQV5Yeyfl/VfM+3/1OfNaf/yyX5aJtbaL7mKJHR8xHNFa608eewrNV/FzxPp1a/shvTxj3qeQ6giVUjRPlmWtbdkQ== X-Google-Smtp-Source: AGHT+IGO1iMoH4j3++0/QzDwg/q6LlS05NR2qwdAMYTJ2ONlfywB3PPJducCmssA6Qrt62Ib4uqS X-Received: by 2002:a05:6214:3004:b0:696:46d3:4dfd with SMTP id ke4-20020a056214300400b0069646d34dfdmr4235710qvb.37.1711259840410; Sat, 23 Mar 2024 22:57:20 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711259840; cv=pass; d=google.com; s=arc-20160816; b=dYL4Cmf6x/hHmBKO8/y9C6BK0TUYzgwbuikIX6UmCuj8ZKQJXCtZCMAmM+orY8cqjS jOoMRCRvvV1cFCCNY2MKmgYxpTlg8+v/YLgou8BL1L9xLvSFmVgTXX2lsqYzuMbn/T6d sMPShzRSe1KxSjZKXb+1I30y/tGxT3w+EH+yHIKIY8wN03tgde36Ff2tbOc4VdgBuTYr vVjaRpzVFLTiIvNo9UcqpDQgjBAYxO560XXdp8hZ9WAJOBqy8gIBlbgJxyrd8aepAU4Y WU6ZjDoeOiYHzMDCT6jt5tzGjg9XfGR18Xtm9dADkUxLFOfzvgnLouFgvUfuiMKarElV qK+g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=OXAIIcbgeJRRW587MHc7p7n/VVnxiytnklGzR/XF9Zg=; fh=+61wA1bf/xd02HJ+CLMpPNRhYo0eVwIb57M1gSRh32Q=; b=Uv8eHfQ1aeDzsEiOrRU9waJz/bv6mh1ZZooQf2beTNxSyXBiAyaM8zV+RI4eVfq79e hHmTtsECLBX2Bre5U3+543g5kTRwMnYd5jzmqhqYuul56vTTglyllkEmFUpMgvZIkdKw szcL2uptzq7rHOZx39luEk17pvBGFNHRzdyAKW1JozfIBiYKaxjx/wMRdThUB/K4n4/d AwcOXXhqstSquMP5qy9qsXH9J/Syz01Y3opTiS7wITC+ACVL9gVby6YyoH5BxrIkdn6m 5iJL4FNK5PbKUqYbldqxIy0LcFwoczTgy9EIlxUGpmGyQqWXuss+issLIhod8vd2Ajil VocA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=XPoVzkjs; arc=pass (i=1 spf=pass spfdomain=google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-112601-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-112601-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id a8-20020a0562140c2800b0069150330d51si5320567qvd.74.2024.03.23.22.57.20 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Mar 2024 22:57:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-112601-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=XPoVzkjs; arc=pass (i=1 spf=pass spfdomain=google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-112601-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-112601-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 2493F1C21206 for ; Sun, 24 Mar 2024 05:57:20 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0CD5E14A89; Sun, 24 Mar 2024 05:57:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="XPoVzkjs" Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7E4D1401B for ; Sun, 24 Mar 2024 05:57:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711259831; cv=none; b=RYmzmUx0QAk+szqZkT8KN3xwNlQc203vOUE18uCp6dUICE7bcRMs8LBkdlAp3FTnAN+drv7d3PXxSztQ3cn1PG9r3q4hcOh7UV18EhyojeRsoiKCXPF3Pfka9kQUG3ZYZdk8kLU1IwgZZLfPO51Ja4pbZGbXreG6EeiHLlL/iW0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711259831; c=relaxed/simple; bh=6IzC5f7q8Hc8Q5UlfrkfYNWS4BY11Ec+KoaESDdZrUU=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=iXx5NbhnnrgtInLv9r3ln12T7WNlZ9Xsrv1M518+hpy7rje5TPBNI1zGa3MQeVV8KZxSb8hHfMyb+MXoySpcvcSMTweBd4Gx61ZulmhI9ulVsQSd1S3ClLVG99fFo9fxNV8z9MCCsmrXxgrcCIhaN+3/eWv8OLLtNhepRfSVvrs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=XPoVzkjs; arc=none smtp.client-ip=209.85.160.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-428405a0205so202901cf.1 for ; Sat, 23 Mar 2024 22:57:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1711259829; x=1711864629; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=OXAIIcbgeJRRW587MHc7p7n/VVnxiytnklGzR/XF9Zg=; b=XPoVzkjsqhiIXeTp86bFWQ16f0/SArp1Gfiz3hzU2b/WTuyDPk9eTu07nNs9qWSXGI /9XRJ4FIBRpaTEsMWN/CCnZa4Xktf1xrkE15IAeYXjY1bvdaQ1Rrs06FEEyRl4zQq8xh i6UjGQ+nm7gjIgWPeLiN7067Pwu39gzBCKrWT9ZeKsNc/6+i7vwNcoouX5FCD2rYUhh/ MVu1a4qQaOQOKHzHnoKxBIPpW7cs/QTzeGW0qXVGNj/nXjpeAf2H6onBtS+IFFo9XEbv ivyWC8N260B7zFtSNcd+Lp3hHnWr1BH6nuTzUbJ9cSKruferSk1A7ojY03Ub45r+w/O1 98Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711259829; x=1711864629; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OXAIIcbgeJRRW587MHc7p7n/VVnxiytnklGzR/XF9Zg=; b=vagQXPZ04B0Q6+rxhjvJIzAvhZRdkjjFPT5gCZmUw0AkJoqB1wisWkv9d+pn0ptJ/h aJyvrvbolWuGo+KpUr7INn2oRVeSS1mJYDPcQ+125Zpgra7E9kGpV8iKU+dNwGiR72wq Q9/0G93LR/81fvM9W7e7kmCV1E3Y+2wfEbLW34K/RDSrMOk0k+3XKrFrKb0ztpf43U/r OQBInartwzHjKTEQkhjjui7V6vO5EF9bTbh4JUxGcUF0yRPQefeimS/68kiC0/ZNCOvu ycL6lqj+4CUYh2TyvazWCit/hkF/QQ7CGvUVV7sw9636UZNQ3ZnsRIXyAzRxmR+ZpOHs JcgA== X-Forwarded-Encrypted: i=1; AJvYcCVHhlPwxcneyQpLQ9C3/3t1a4hvrYSIYnFhBewE9jgNRxZi+pYxlhvnBZ5ilatlCB3Nbl4Jl6h8PbCiwJj1JdPH1ZOYmyJ8e29+qtFZ X-Gm-Message-State: AOJu0YyPGLJ0eVZE9ce3Wbycz53Rhji/Z1ws8kBDNoU9jVs/ZUpQbo3t gRz0/G1LQUnN1uSHSvJTKYHjsjsBEaj1qfflDGLbHjy7MeL2XWha0P03DL8G1vvmi21BzJ9ngSp rlo4FkRitob6JOOARH9mahhgt3xzLXnnWSy+o X-Received: by 2002:a05:622a:102:b0:431:20e1:a28 with SMTP id u2-20020a05622a010200b0043120e10a28mr890714qtw.22.1711259828614; Sat, 23 Mar 2024 22:57:08 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240209031441.943012-1-weilin.wang@intel.com> <20240209031441.943012-16-weilin.wang@intel.com> In-Reply-To: <20240209031441.943012-16-weilin.wang@intel.com> From: Ian Rogers Date: Sat, 23 Mar 2024 22:56:57 -0700 Message-ID: Subject: Re: [RFC PATCH v4 15/15] perf stat: Add hardware-grouping cmd option to perf stat To: weilin.wang@intel.com Cc: Kan Liang , Namhyung Kim , Arnaldo Carvalho de Melo , Peter Zijlstra , Ingo Molnar , Alexander Shishkin , Jiri Olsa , Adrian Hunter , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Perry Taylor , Samantha Alt , Caleb Biggers , Mark Rutland Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Feb 8, 2024 at 7:14=E2=80=AFPM wrote: > > From: Weilin Wang > > Add a cmd option to allow user to choose this new metric grouping method. > > $ perf stat -M TopdownL1 -a --hardware-grouping > > Signed-off-by: Weilin Wang Reviewed-by: Ian Rogers Thanks, Ian > --- > tools/perf/builtin-stat.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c > index d08a40c4bae1..e30f7a856122 100644 > --- a/tools/perf/builtin-stat.c > +++ b/tools/perf/builtin-stat.c > @@ -1257,6 +1257,8 @@ static struct option stat_options[] =3D { > "don't try to share events between metrics in a gr= oup"), > OPT_BOOLEAN(0, "metric-no-threshold", &stat_config.metric_no_thre= shold, > "disable adding events for the metric threshold ca= lculation"), > + OPT_BOOLEAN(0, "hardware-grouping", &stat_config.hardware_aware_g= rouping, > + "Use hardware aware metric grouping metho= d"), > OPT_BOOLEAN(0, "topdown", &topdown_run, > "measure top-down statistics"), > OPT_UINTEGER(0, "td-level", &stat_config.topdown_level, > -- > 2.42.0 >