Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp2109288lqp; Sun, 24 Mar 2024 03:45:26 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVG5YczVhXA0zS29GtPgFI8+aPn8gQ0fPt1EQM8ldFywn6AoKRoPPUBuT3mCGwAGWwHGrJ6TyCpqkV6cgy0twAUcFElwnlJcu9ChykxKw== X-Google-Smtp-Source: AGHT+IFfSUHX2I0ckkF7NbJojDUUUjHDu/xwwbMTu49BiPUuxdQvclsMpVP9sxmgS1AaZ2LNt9yC X-Received: by 2002:a17:906:3583:b0:a46:8daa:436f with SMTP id o3-20020a170906358300b00a468daa436fmr2384747ejb.69.1711277126492; Sun, 24 Mar 2024 03:45:26 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711277126; cv=pass; d=google.com; s=arc-20160816; b=awzZNAnMQ66M6NT5GRckvzs0NfULrlvec6RyDsW4IqSJ3Znodcl2vxZ+MHpfhqiQpZ iiI1IF59eQBkiJkwSmrmi6oSpC8Gck9DePadyD2GLNFUK+dEbe7HbKVdAvC7NlBzsfgo qo3LOsP/yMEZyd/arBpMdavvvxtrZHe701lFZfe2mky6GTnOk3wJqt+wRd+2wj4P4mSM gTaPV+zW7oyk6XxG4pXA0LZ2ykTOEaluDg9gx0zZTD6OeE3Ya3FXi6awtICZNZ+R/iCQ sw9HSeL09bXVqiM2tT3OLMYYhWQjJUCaQ09QVqa/0nxx/XxUntX5uZwMC9J2jg1louxD y25w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=CWY24m2OMeavf9ZqUqvQSQdTD4THnN/BxwjI9GZeFo8=; fh=XeLFQe+DTQaOygGFrCVLtY/wh9+SpDD5If9i8OcFBCU=; b=RLpj+KfOjBl5Y8cza+/5JnGqXm+M0w8P+EvoKlAOSAFS9NVKWpU735eMe2aALLzwHK 19972+2FuVjZC51fVtqXSUE3OR4UnQN+Qbsz3Yc9TMyYUsc5PH8LHAzW84ZAl3NxBh6D GDqhJq4Fh30siUKZuI+zTi2jcPnsvrsGllqtY697YzGdJwRsHrFkA+zgPN009/j/acrJ JGSnf1jppD0pD6kEQFzXVWTbKnf2nVXdp7djST5OmO6xwg94jQ7DsF6qDqLEm+S4a2aF 89VVSOimTuJBx8uCvnAUUHXUb11xSLKxiKVW0Ctfrv7iY7hxlTptdVL58VRWcGpgQVQt hQOQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=n887v36a; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-112636-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-112636-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id qk19-20020a1709077f9300b00a4748ca721csi1054713ejc.439.2024.03.24.03.45.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Mar 2024 03:45:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-112636-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=n887v36a; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-112636-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-112636-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 3CA921F21437 for ; Sun, 24 Mar 2024 10:45:26 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 176DE17735; Sun, 24 Mar 2024 10:45:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="n887v36a" Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8DE7417583 for ; Sun, 24 Mar 2024 10:45:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711277116; cv=none; b=KLeCj/7ohsQkiFXdfqC8BQaZAqtQ3127pabQP5BQagAa9mQUxTKSX7+q12LWb56VN7iNlE/TyIUgmsqgrzEqBXe1gddT0wFJE+9wof9G1safYsThKbeXKtDaCdPz5gf8FrKR9kARBul5i/9bNpKrry86ol3Euexd9ldozlvuZIk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711277116; c=relaxed/simple; bh=sQckmXFITy4Xkbkc59BJtYFx0lkcS3ukS9NHkCGTGSs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JfVs245Y89DFfs5uMbLvTLk6PEWwfrOTJLNDgL0qTBwrqBNMHCxjJclDVnL3jB3H6HANwb+ifWIKVpN0MCxAGMySN9R4nJebbUaKBQYQuegRjGzCzq0XMVh4sqM4+6i+cZmW1FpuNPvOFtzdrtR4Afo48YnJlvxP5N7RxcFTbcM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=n887v36a; arc=none smtp.client-ip=209.85.218.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-a46a7208eedso478941166b.0 for ; Sun, 24 Mar 2024 03:45:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1711277113; x=1711881913; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=CWY24m2OMeavf9ZqUqvQSQdTD4THnN/BxwjI9GZeFo8=; b=n887v36aoMM9NxY2Dc4wrGGIvVnmsDggw7CQmw3wdRD1SkSXGXfww8ZhfYTdI4QCG+ x9Rdk+FQ0hUw6ToYuJj12Gs4RKXBE596EDWdmLBBbpqnzpXTxQY6yIdm2ZDz/H1Ims2f BAkfmakJ0AjXCUwp4g8nhv95eZSFRNXCvpxGr9kwGl22Cj4YxmMcqYlHRXl9QePyB5j+ HubheSDXz9hZlL37VfMe/n/5kPng8KWbiKRVSMAdbB2/eCxV9NgpyWstH3pzPGpATOMV 8SP2WG2CSlmBXgMx4ZAjgtqGDSXw89D2JYs4JTpi9c+2FuhxffB3l1r/YaRUv37TTNZn X+ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711277113; x=1711881913; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CWY24m2OMeavf9ZqUqvQSQdTD4THnN/BxwjI9GZeFo8=; b=Egl3fmI5+ByslndkrRI0CRY5RqMKjzwVppl2sV8fTGdv2/NsRUkd+cVJrEyjz/1aTQ RfIlIBgYrM/LwA1ppMn1fAxzDcxwI5JqRHhBzXG76KcEGOvZMDtfHomI9++lUVxzv3KQ ZhulkoNIvjd95umioVgWxmRdGqgBHuVlAqLgt6FLg8XHGqctZOqj2qZjC2dUikvpapFw 6w4o7ztpd4MXjttBt7JUC9PCB/T0jD+JBRXZllpYoAsxG5B69HHWy9vojHE1bQDwPdnS W8FSts2cqh/bvtqRz9EWXV+iONKiELDAQ5HjjEQYcpi1UqIEZihxwf5j2oNFl9jDZR45 G+jg== X-Forwarded-Encrypted: i=1; AJvYcCUm6rl9OfMTnF+l3T19EzBIRDCM2NhNNfWxQo5qrfeezV/dr+IRpEfpgdCvylKx1Bj/cELPot1QScL1BR4+OYQIitepI7+Qc8B4M42K X-Gm-Message-State: AOJu0YyHz3An7p5J/EvZtfklt4B2GAyj6ztQQPO/G1UAW7ffsV0aq3jB LNlpFWU3gaZVk08jt0gqzYmA9Ve9zfhwi1qoIQgUjDuZ5hU6UHtGu3rMDMsXF0U= X-Received: by 2002:a17:906:a19:b0:a46:f955:3720 with SMTP id w25-20020a1709060a1900b00a46f9553720mr2593989ejf.51.1711277112766; Sun, 24 Mar 2024 03:45:12 -0700 (PDT) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id ws9-20020a170907704900b00a46caa13e67sm1832993ejb.105.2024.03.24.03.45.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Mar 2024 03:45:12 -0700 (PDT) Date: Sun, 24 Mar 2024 13:45:09 +0300 From: Dan Carpenter To: "Peng Fan (OSS)" Cc: Sudeep Holla , Cristian Marussi , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Oleksii Moisieiev , Linus Walleij , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, AKASHI Takahiro , Peng Fan Subject: Re: [PATCH v5 3/4] firmware: arm_scmi: Add SCMI v3.2 pincontrol protocol basic support Message-ID: References: <20240314-pinctrl-scmi-v5-0-b19576e557f2@nxp.com> <20240314-pinctrl-scmi-v5-3-b19576e557f2@nxp.com> <7a4a8287-1f86-4ac4-acdf-c02339ba5e1e@moroto.mountain> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7a4a8287-1f86-4ac4-acdf-c02339ba5e1e@moroto.mountain> On Thu, Mar 21, 2024 at 05:46:53PM +0300, Dan Carpenter wrote: > On Thu, Mar 14, 2024 at 09:35:20PM +0800, Peng Fan (OSS) wrote: > > +enum scmi_pinctrl_protocol_cmd { > > + PINCTRL_ATTRIBUTES = 0x3, > > + PINCTRL_LIST_ASSOCIATIONS = 0x4, > > + PINCTRL_CONFIG_GET = 0x5, > > + PINCTRL_CONFIG_SET = 0x6, > > + PINCTRL_FUNCTION_SELECT = 0x7, > > PINCTRL_FUNCTION_SELECT was removed from the spec so the other cmds were > renumbered. I'm still going through and reviewing this file. I'll > hopefully be done tomorrow. > I think the rest is okay. It's just updating to the new version of the spec. CONFIG_GET/SET need to be updated and FUNCTION_SELECT gets deleted. regards, dan carpenter