Received-SPF: pass (google.com: domain of linux-kernel+bounces-112642-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Sun, 24 Mar 2024 11:07:15 +0000
From: Jonathan Cameron <jic23@kernel.org>
To: Conor Dooley <conor@kernel.org>
Cc: Javier Carrasco <javier.carrasco.cruz@gmail.com>, Lars-Peter Clausen
 <lars@metafoo.de>, Rob Herring <robh@kernel.org>, Krzysztof Kozlowski
 <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>,
 Matt Ranostay <matt@ranostay.sg>, Jonathan Cameron
 <Jonathan.Cameron@huawei.com>, linux-iio@vger.kernel.org,
 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: iio: health: maxim,max30102: fix
 compatible check
Message-ID: <20240324110715.0832e6d6@jic23-huawei>
In-Reply-To: <20240317-bakery-numeric-a34b928efa6d@spud>
References: <20240316-max30102_binding_fix-v1-1-e8e58f69ef8a@gmail.com>
	<20240317-bakery-numeric-a34b928efa6d@spud>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Sun, 17 Mar 2024 14:37:39 +0000
Conor Dooley <conor@kernel.org> wrote:

> On Sat, Mar 16, 2024 at 11:56:57PM +0100, Javier Carrasco wrote:
> > The "maxim,green-led-current-microamp" property is only available for
> > the max30105 part (it provides an extra green LED), and must be set to
> > false for the max30102 part.
> > 
> > Instead, the max30100 part has been used for that, which is not
> > supported by this binding (it has its own binding).
> > 
> > This error was introduced during the txt to yaml conversion.
> > 
> > Fixes: 5a6a65b11e3a ("dt-bindings:iio:health:maxim,max30102: txt to yaml conversion")
> > Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>  
> 
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
Applied to the fixes-togreg branch of iio.git (which I'll rebase on rc1 once available)
and marked for stable.  Not really a critical thing to backport, but maybe it is worth
doing as risk is very low

Thanks,

Jonathan

> 
> > ---
> >  Documentation/devicetree/bindings/iio/health/maxim,max30102.yaml | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/health/maxim,max30102.yaml b/Documentation/devicetree/bindings/iio/health/maxim,max30102.yaml
> > index c13c10c8d65d..eed0df9d3a23 100644
> > --- a/Documentation/devicetree/bindings/iio/health/maxim,max30102.yaml
> > +++ b/Documentation/devicetree/bindings/iio/health/maxim,max30102.yaml
> > @@ -42,7 +42,7 @@ allOf:
> >        properties:
> >          compatible:
> >            contains:
> > -            const: maxim,max30100
> > +            const: maxim,max30102
> >      then:
> >        properties:
> >          maxim,green-led-current-microamp: false
> > 
> > ---
> > base-commit: c1f10ac840caced7a9f717d4170dcc14b3fac076
> > change-id: 20240316-max30102_binding_fix-898e7c94cce9
> > 
> > Best regards,
> > -- 
> > Javier Carrasco <javier.carrasco.cruz@gmail.com>
> >