Received-SPF: pass (google.com: domain of linux-kernel+bounces-112647-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Sun, 24 Mar 2024 11:21:38 +0000
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
From: Pratham Patel <prathampatel@thefossguy.com>
Cc: robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, heiko@sntech.de, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] arm64: dts: rockchip: disable analog audio for rock-5b
Message-ID: <TbQeSy-AWAKVHo2Alb8hXUvplVNvohDJ2ztRM1x3Fo5PMmGLMsJxtHR-OIms9FlUshfUD9x45EghBCB9gVtcUPlxeMRUJQ_C95DVhu3AJrk=@thefossguy.com>
In-Reply-To: <0005257d-8022-4a66-a802-0c920d259ccd@linaro.org>
References: <20240324062816.145858-1-prathampatel@thefossguy.com> <0005257d-8022-4a66-a802-0c920d259ccd@linaro.org>
Feedback-ID: 104309535:user:proton
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On Sunday, March 24th, 2024 at 16:15, Krzysztof Kozlowski <krzysztof.kozlow=
ski@linaro.org> wrote:

>=20
>=20
> On 24/03/2024 07:28, Pratham Patel wrote:
>=20
> > The addition of `of: property: fw_devlink: Fix stupid bug in remote-end=
point parsing`
>=20
>=20
> Please refer to commits using commit sha () syntax, as mentioned in
> submitting patches.

Noticed that in the wiki but didn't do that since the commit hash for the c=
ommit
was different in each branch (of the stable tree). Maybe I should have copi=
ed the SHA
from Linus' tree. I will do that.

> > + /*
> > + *analog-sound {
> > + * compatible =3D "audio-graph-card";
> > + * label =3D "rk3588-es8316";
>=20
>=20
> Do not comment out code. Instead disable the nodes and provide
> appropriate comment describing reason.

I tried changing the status from okay to disabled. That didn't work. The SB=
C
still locked up during boot.

> Anyway, this does not look like correct solution. DTS is independent of
> OS, so bug in fwlink does not matter for DTS. Either DTS is a correct
> hardware representation or not.

I agree, it's not the correct solution. It is a temporary workaround for th=
e regression
caused. I will send more patches once I receive a few more RK3588-based SBC=
s and investigate.

 -- Pratham Patel