Received-SPF: pass (google.com: domain of linux-kernel+bounces-112660-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Peng Fan <peng.fan@nxp.com>
To: Dan Carpenter <dan.carpenter@linaro.org>, "Peng Fan (OSS)"
	<peng.fan@oss.nxp.com>
CC: Sudeep Holla <sudeep.holla@arm.com>, Cristian Marussi
	<cristian.marussi@arm.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof
 Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley
	<conor+dt@kernel.org>, Oleksii Moisieiev <oleksii_moisieiev@epam.com>, Linus
 Walleij <linus.walleij@linaro.org>, Shawn Guo <shawnguo@kernel.org>, Sascha
 Hauer <s.hauer@pengutronix.de>, Pengutronix Kernel Team
	<kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, dl-linux-imx
	<linux-imx@nxp.com>, "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "devicetree@vger.kernel.org"
	<devicetree@vger.kernel.org>, "linux-gpio@vger.kernel.org"
	<linux-gpio@vger.kernel.org>, AKASHI Takahiro <takahiro.akashi@linaro.org>
Subject: RE: [PATCH v5 3/4] firmware: arm_scmi: Add SCMI v3.2 pincontrol
 protocol basic support
Thread-Topic: [PATCH v5 3/4] firmware: arm_scmi: Add SCMI v3.2 pincontrol
 protocol basic support
Thread-Index: AQHadhNakUhFqeH4Wkuoe629JrLZ/LFCUROAgARzdICAABkE8A==
Date: Sun, 24 Mar 2024 12:15:19 +0000
Message-ID:
 <DU0PR04MB941796214807CFF880E1A31F88372@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20240314-pinctrl-scmi-v5-0-b19576e557f2@nxp.com>
 <20240314-pinctrl-scmi-v5-3-b19576e557f2@nxp.com>
 <7a4a8287-1f86-4ac4-acdf-c02339ba5e1e@moroto.mountain>
 <b06ab1e3-c00a-444c-908f-0ac8ad4d95fc@moroto.mountain>
In-Reply-To: <b06ab1e3-c00a-444c-908f-0ac8ad4d95fc@moroto.mountain>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?R75uXC/ocBOA72J7QxcvfYY/Ks9EtGvjtujk5MUAc9cw0cdswrtfM3m2NiqO?=
 =?us-ascii?Q?qdFsqHt7+8p5Ca7squ3ng8OlQ3rirVrw3UbZf7sVYTix5XrFDjcHYCgZGeby?=
 =?us-ascii?Q?0king5r1dZ4DfrtSXek+CvO0TopVpvUdsVzQ7g4J0Hr2P5nUkIDbwMqvYTvT?=
 =?us-ascii?Q?Iw+B7Q+NqAOqJAIFyh/JL8zaJm8Di1Nz6PZWGyar+jpPdoCQ010OXKheis2U?=
 =?us-ascii?Q?QTAS8UWPfAgkYoEq99X8R+gqT6VogaPKjDMgQMFS5bI2lllsyObiIFISULp9?=
 =?us-ascii?Q?xAuxDujLAwolNByJUvgRP8rpNwajXUP3yYY5Laif0f0sR/72Fx2Ok7bImRz8?=
 =?us-ascii?Q?/2y8ywC2gMq/sqfUAGILuPUgLkvVS41sRUNSDASwVHQoRy6KPC1CPZKutQY7?=
 =?us-ascii?Q?GKz0CfXQp/APJEssQAZLwIyJpEleUmBah7iwHM0EPReI2OkLKKbaT3qiKNXh?=
 =?us-ascii?Q?6IHBGn8bqo+cUBBZ6hKCopc4N0k0F1A24G9it0WYeZ9nMdLWygS0cgxoVIPL?=
 =?us-ascii?Q?qUr5xbUksTclSPrcvwTfVnm66tfnmaTSiIfzlCmXU4o0BhGSEWiYx9Meg1rH?=
 =?us-ascii?Q?+H9USBRzdbNrvaWw1q9pd3NImV2n07BE8oL3bD0Ge6BYMM6atbRZV1amVqwW?=
 =?us-ascii?Q?XRV+kaPAntdhCqBrsHGnp2Y1al7td7pnQFYA3acubw0KlnMHr47R4XhGlL0/?=
 =?us-ascii?Q?krXnL7tLZESmLdwPUlD2fZsyOJ7C/JArjk4lsjAjrcTfpLDeyg6oqXn04kqX?=
 =?us-ascii?Q?SaawY5QNgOKf2RDLklucOv2GsdGebZUmO28a5Xmb9HH5t4YRXcFE32dYGRrX?=
 =?us-ascii?Q?BYJuGzmADfqSlu7ScwztHDUxZBrCCAAQBh8w1lvMz2wgrQK3ERoKljDZ6J8M?=
 =?us-ascii?Q?hDjkHrC1ROuIu6pnweXIjHnVguSoL9gQxwDn6L7NbCaQGAnqku30KhIlOKws?=
 =?us-ascii?Q?zARshmlCXmp7M9in6lNra7EoKIHt3epqOPS/jhnGXFwPBZWkQb0oPNaKWP43?=
 =?us-ascii?Q?eTLCAY/yHwelhZWvpvlpqsnZON1tJYSHJP2S6L2wo3l/wVyZnJhd9fiAGa85?=
 =?us-ascii?Q?PyaJeqMxXbMoRZ3Y9PRVKI7HyC4lr3NyfZQvuehLkjgcC2WneOfKeIowva+p?=
 =?us-ascii?Q?RXB+s+TgQlEhxw4OdgQhZScpsoEou82g6Bbhdh5+v4JUk/NkQVoWvBME3VWi?=
 =?us-ascii?Q?FHgD6CnkcvB1n0h2ucZnSmDd07Drov9RhkBPH69bWbCMKzlYKyfMp40VGv8M?=
 =?us-ascii?Q?8vNNehqrlJfSZBylLUgmKL8cElDwNKiDFlcVTz/2alPyiYsBatu5o33NprbY?=
 =?us-ascii?Q?SI0FZiLOSV/Tpxz4jTtBaSqiRiJuSaS7MjrhklzcHICVgePGjMHziP8Kf482?=
 =?us-ascii?Q?Z7L9b6+oDD0wXzWWFT/mOktTj/i6gB0W8PhQyreCgIuJf0L4Z3zcsciUnkWz?=
 =?us-ascii?Q?c5FyZGSPWLLVz4hZ847vxVqvPJCsMsprv0qz7W1sxPuKlsRHagyLYlFRMLL1?=
 =?us-ascii?Q?uw/To46nTQLQSJVLVN8B2rJQnnQGjUtNuLZpo8ZqcLk7zZqtWwlof4efJtOR?=
 =?us-ascii?Q?RIyusZ2Sn7hglTaBGdw=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fc82d10e-6683-455f-ff79-08dc4bfc12e1
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Mar 2024 12:15:20.0225
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: +N3TL8ellVsYTzOOA9CKoGQVl4YPgx9spoabcCpYMjcFUVtcr7KpqkhVEnfneDOEC7eTQacW9iJOAGnrmFJGTw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8768

Hi Dan,

> Subject: Re: [PATCH v5 3/4] firmware: arm_scmi: Add SCMI v3.2 pincontrol
> protocol basic support
>=20
> On Thu, Mar 21, 2024 at 05:46:53PM +0300, Dan Carpenter wrote:
> > On Thu, Mar 14, 2024 at 09:35:20PM +0800, Peng Fan (OSS) wrote:
> > > +enum scmi_pinctrl_protocol_cmd {
> > > +	PINCTRL_ATTRIBUTES =3D 0x3,
> > > +	PINCTRL_LIST_ASSOCIATIONS =3D 0x4,
> > > +	PINCTRL_CONFIG_GET =3D 0x5,
> > > +	PINCTRL_CONFIG_SET =3D 0x6,
> > > +	PINCTRL_FUNCTION_SELECT =3D 0x7,
> >
> > PINCTRL_FUNCTION_SELECT was removed from the spec so the other cmds
> > were renumbered.  I'm still going through and reviewing this file.
> > I'll hopefully be done tomorrow.
> >
>=20
> I think the rest is okay.  It's just updating to the new version of the s=
pec.
> CONFIG_GET/SET need to be updated and FUNCTION_SELECT gets deleted.

V6 has this updated. Thanks for helping reviewing this patchset.

Thanks,
Peng.

>=20
> regards,
> dan carpenter