Received-SPF: pass (google.com: domain of linux-kernel+bounces-112662-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Sun, 24 Mar 2024 12:18:53 +0000
From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: David Lechner <dlechner@baylibre.com>, Michael Hennerich
 <michael.hennerich@analog.com>, Nuno =?UTF-8?B?U8Oh?= <nuno.sa@analog.com>,
 linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iio: adc: ad7944: simplify adi,spi-mode property
 parsing
Message-ID: <20240324121853.460ba5f8@jic23-huawei>
In-Reply-To: <Zf8_NZ5cNb9TVThx@surfacebook.localdomain>
References: <20240319-ad7944-cleanups-v2-1-50e77269351b@baylibre.com>
	<CAHp75VeO_=r_pMBUTaQQYKDRAV-OVfTnPYPwV8f7KDzOhaBCvQ@mail.gmail.com>
	<CAMknhBETEP123=EHycGtFEJjQ+NPssLXmw9ZdDoY8CRsWiSxVQ@mail.gmail.com>
	<20240323182918.2cf624b6@jic23-huawei>
	<Zf8_NZ5cNb9TVThx@surfacebook.localdomain>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Sat, 23 Mar 2024 22:44:37 +0200
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:

> Sat, Mar 23, 2024 at 06:29:18PM +0000, Jonathan Cameron kirjoitti:
> > On Tue, 19 Mar 2024 10:28:31 -0500
> > David Lechner <dlechner@baylibre.com> wrote: =20
> > > On Tue, Mar 19, 2024 at 10:01=E2=80=AFAM Andy Shevchenko
> > > <andy.shevchenko@gmail.com> wrote: =20
> > > > On Tue, Mar 19, 2024 at 4:28=E2=80=AFPM David Lechner <dlechner@bay=
libre.com> wrote:   =20
>=20
> ...
>=20
> > > > > +       ret =3D device_property_match_property_string(dev, "adi,s=
pi-mode",
> > > > > +                                                   ad7944_spi_mo=
des,
> > > > > +                                                   ARRAY_SIZE(ad=
7944_spi_modes));
> > > > > +       if (ret < 0) {
> > > > > +               if (ret !=3D -EINVAL)
> > > > > +                       return dev_err_probe(dev, ret,
> > > > > +                                            "getting adi,spi-mod=
e property failed\n");   =20
> > > >   =20
> > > > > -               adc->spi_mode =3D ret;
> > > > > -       } else {   =20
> > > >
> > > > Actually we may even leave these unchanged
> > > >   =20
> > > > >                 /* absence of adi,spi-mode property means default=
 mode */
> > > > >                 adc->spi_mode =3D AD7944_SPI_MODE_DEFAULT;
> > > > > +       } else {
> > > > > +               adc->spi_mode =3D ret;
> > > > >         }   =20
> > > >
> > > >        ret =3D device_property_match_property_string(dev, "adi,spi-=
mode",
> > > >                                                    ad7944_spi_modes,
> > > >
> > > > ARRAY_SIZE(ad7944_spi_modes));
> > > >        if (ret >=3D 0) {
> > > >                adc->spi_mode =3D ret;
> > > >        } else if (ret !=3D -EINVAL) {
> > > >                        return dev_err_probe(dev, ret,
> > > >                                             "getting adi,spi-mode
> > > > property failed\n");
> > > >        } else {
> > > >                /* absence of adi,spi-mode property means default mo=
de */
> > > >                adc->spi_mode =3D AD7944_SPI_MODE_DEFAULT;
> > > >        }
> > > >
> > > > But I can admit this is not an often used approach.
> > > >   =20
> > >=20
> > > I think Jonathan prefers to have the error path first, so I would like
> > > to wait and see if he has an opinion here. =20
> > I do prefer error paths first.  Thanks. =20
>=20
> Still the above can be refactored to have one line less
>=20
> 	ret =3D device_property_match_property_string(dev, "adi,spi-mode",
>                                                     ad7944_spi_modes,
> 						    ARRAY_SIZE(ad7944_spi_modes));
> 	if (ret =3D=3D -EINVAL) {
> 		/* absence of adi,spi-mode property means default mode */
> 		adc->spi_mode =3D AD7944_SPI_MODE_DEFAULT;
> 	} else if (ret < 0) {
> 		return dev_err_probe(dev, ret, "getting adi,spi-mode property failed\n"=
);
> 	} else {
> 		adc->spi_mode =3D ret;
>         }
>=20
True.  I'll take a patch doing that, but I'm not going to tweak
it again directly.

Thanks,

Jonathan