Received-SPF: pass (google.com: domain of linux-kernel+bounces-112663-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Sun, 24 Mar 2024 12:19:10 +0000
To: Linux regressions mailing list <regressions@lists.linux.dev>
From: Pratham Patel <prathampatel@thefossguy.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, heiko@sntech.de, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] arm64: dts: rockchip: disable analog audio for rock-5b
Message-ID: <MVRWlsBI3ytGeanEiplqESaeJxicfYRfOPHHhMJTQNRzd8XWTWlOoIFc949rG06cF_DAj5EpN2vMRFt3s34Di5nzfVgTfbWAH4A9R6SfqeI=@thefossguy.com>
In-Reply-To: <db6ae45b-ff34-433f-8a31-1547423768ce@leemhuis.info>
References: <20240324062816.145858-1-prathampatel@thefossguy.com> <0005257d-8022-4a66-a802-0c920d259ccd@linaro.org> <TbQeSy-AWAKVHo2Alb8hXUvplVNvohDJ2ztRM1x3Fo5PMmGLMsJxtHR-OIms9FlUshfUD9x45EghBCB9gVtcUPlxeMRUJQ_C95DVhu3AJrk=@thefossguy.com> <XJ_dGL-0X07dJ8GOKvrXbRD2FAHN1A7keAtohcSaU41DEF0FbeWwswLEqkrYiwwulyXDwJ6SZHfWukhHO3t3tOWX7ZGM7ya9lwXfn8Xh1nU=@thefossguy.com> <db6ae45b-ff34-433f-8a31-1547423768ce@leemhuis.info>
Feedback-ID: 104309535:user:proton
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


On Sunday, March 24th, 2024 at 17:44, Linux regression tracking (Thorsten L=
eemhuis) <regressions@leemhuis.info> wrote:

>=20
>=20
> On 24.03.24 12:43, Pratham Patel wrote:
>=20
> > On Sunday, March 24th, 2024 at 16:51, Pratham Patel prathampatel@thefos=
sguy.com wrote:
> >=20
> > > On Sunday, March 24th, 2024 at 16:15, Krzysztof Kozlowski krzysztof.k=
ozlowski@linaro.org wrote:
> > >=20
> > > > > + /*
> > > > > + *analog-sound {
> > > > > + * compatible =3D "audio-graph-card";
> > > > > + * label =3D "rk3588-es8316";
> > > >=20
> > > > Do not comment out code. Instead disable the nodes and provide
> > > > appropriate comment describing reason.
> > >=20
> > > I tried changing the status from okay to disabled. That didn't work. =
The SBC
> > > still locked up during boot.
> >=20
> > I think setting the status to fail should do the trick, instead of sett=
ing it to disabled.
> > Will try that and be back with a v2.
>=20
>=20
> Please CC the author of the change that broke things when submitting v2,
> which you afaics failed to do in this thread.
> =20
> Ciao, Thorsten

Ack, will do.

 -- Pratham Patel