Received-SPF: pass (google.com: domain of linux-kernel+bounces-112685-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Sun, 24 Mar 2024 13:51:10 +0000
From: Jonathan Cameron <jic23@kernel.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Petre Rodan <petre.rodan@subdimension.ro>, Lars-Peter Clausen
 <lars@metafoo.de>, linux-kernel@vger.kernel.org,
 kernel-janitors@vger.kernel.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: pressure: hsc030pa: Use spi_read()
Message-ID: <20240324135110.1e71572d@jic23-huawei>
In-Reply-To: <8327ac591d244ac85aa83c01e559076159c7ba12.1711283728.git.christophe.jaillet@wanadoo.fr>
References: <8327ac591d244ac85aa83c01e559076159c7ba12.1711283728.git.christophe.jaillet@wanadoo.fr>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Sun, 24 Mar 2024 13:36:16 +0100
Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:

> Use spi_read() instead of hand-writing it.
> It is less verbose.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Applied to the togreg-normal branch of iio.git.

Thanks,

Jonathan

> ---
> Compile test only
> ---
>  drivers/iio/pressure/hsc030pa_spi.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/iio/pressure/hsc030pa_spi.c b/drivers/iio/pressure/hsc030pa_spi.c
> index 818fa6303454..337eecc577d2 100644
> --- a/drivers/iio/pressure/hsc030pa_spi.c
> +++ b/drivers/iio/pressure/hsc030pa_spi.c
> @@ -23,14 +23,9 @@
>  static int hsc_spi_recv(struct hsc_data *data)
>  {
>  	struct spi_device *spi = to_spi_device(data->dev);
> -	struct spi_transfer xfer = {
> -		.tx_buf = NULL,
> -		.rx_buf = data->buffer,
> -		.len = HSC_REG_MEASUREMENT_RD_SIZE,
> -	};
>  
>  	msleep_interruptible(HSC_RESP_TIME_MS);
> -	return spi_sync_transfer(spi, &xfer, 1);
> +	return spi_read(spi, data->buffer, HSC_REG_MEASUREMENT_RD_SIZE);
>  }
>  
>  static int hsc_spi_probe(struct spi_device *spi)