Received-SPF: pass (google.com: domain of linux-kernel+bounces-112815-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <d4bebe80-ade4-4b91-91e8-6d67fe4b69cd@gmail.com>
Date: Sun, 24 Mar 2024 20:05:42 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/2] dt-bindings: iio: health: maxim,max30102: add
 max30101
To: Jonathan Cameron <jic23@kernel.org>
Cc: Lars-Peter Clausen <lars@metafoo.de>, Rob Herring <robh@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>, Matt Ranostay <matt@ranostay.sg>,
 linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org
References: <20240321-max30101-v1-0-00b83e966824@gmail.com>
 <20240321-max30101-v1-1-00b83e966824@gmail.com>
 <20240324134615.0380ef81@jic23-huawei>
Content-Language: en-US, de-AT
From: Javier Carrasco <javier.carrasco.cruz@gmail.com>
In-Reply-To: <20240324134615.0380ef81@jic23-huawei>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 3/24/24 14:46, Jonathan Cameron wrote:
> On Thu, 21 Mar 2024 19:33:48 +0100
> Javier Carrasco <javier.carrasco.cruz@gmail.com> wrote:
> 
>> The Maxim max30101 irs the replacement for the max30105, which is no
>> longer recommended for future designs.
>>
>> The max30101 does not require new properties, and it can be described
>> with the existing ones for the max30105.
>>
>> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
> 
> Given there were no driver changes, is it fully compatible?
> i.e. Should we have a fallback compatible here?
> 
> properties:
>   compatible:
>     oneOf:
>        - items:
>            - const: maxim,max30101
>            - const: maxim,max30105
>        - enum:
>            - maxim,max30102
>            - maxim,max30105
> 
> So that a DTS file could use
> compatible = "maxim,max30101", "maxim,max30105"
> and work with older kernels as well as new ones that understand the new ID?
> 

According to the manufacturer, it is fully compatible, and apart from
the pinout, I could not find any difference beyond the device description.

I like the idea of having a fallback compatible for older kernels, so I
will add it to v2 as you suggested.

Thanks and best regards,
Javier Carrasco