Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp2371941lqp; Sun, 24 Mar 2024 16:19:59 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWDi3Lk43o821UiIrnRKUSJQM/21ac+HdnGiLISuzxY05LIpQOY/BhT5NLmNhW8zW/U1lLPpJEUDaWbIvh6aLIMQtDx4XJkL/FlfB8ODw== X-Google-Smtp-Source: AGHT+IF4SCZr5Rg5ndbXZmsncinqWXGVo1KcMAcZCZMwHrdzzY7sg0LT2hBWmMJABJHunqR/Wttl X-Received: by 2002:a17:906:3796:b0:a4a:3861:d63b with SMTP id n22-20020a170906379600b00a4a3861d63bmr338900ejc.71.1711322399223; Sun, 24 Mar 2024 16:19:59 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711322399; cv=pass; d=google.com; s=arc-20160816; b=SgsNJYYjnq1J/fclJC88e6GK+gwTsil/JMrFvRp3oVkLVInSpU3Bu77GBnjIhLmXCM miS77Q3jUkwqnJr6fh8lyZwUH+8Hw67sEOBLq5ZQ5YpaUBreYfqOJlrfMYIaXaF1cMDw 1bRd7fAtlfOAqyENCo9ZoVHNihSJrGQYTKAGP+GJvVmu3ZL+aHd39mWUstgPLFfbIiUG Nl3zauu0j6DLk6EVe4vacLxCq0JPOsCqJ94fG5EoL+tcUzowJHPa4tYi1HevioyTUo5d sK5njhdlc1D2MSeXhX9L87FZ2veu+pRLyYIzDEJ736gtFnt/scegsifq/GpADj/ZMRJO WBxw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=0iG3OeyZHzrG3yesGISMoJf9Tgu3HBuC+KLt23yaEpY=; fh=QjpbeGVwognWl3PIZE4AWsCuylyHvllwVo1MB9wPxTE=; b=VD9Fb3o/zOk1CFqCdn5X4khv/hGy9lOpBBrZ46zQtk1ZDj+tcp2CIOYN8hto1wfdEP MnA0DhP5bNUvC6jUgHegZh71GJYuyGXSythtz6XQLEflocvfXkjNcxOypxwn5HJga2y1 cWiJW2qIQeXJ3Kn69GHtxuvR17XIuxg2UUn5qUu/W97eeaiKvlz60Eyir6DWLGNH1Ew9 fAHNotb0+eWIlykAmfloMmDYMobW6elNFIahdkT0xk1ABs6u7qvhy9d8eUrac8ARres4 eciSy8ci7hbsU/8LvXPrzsgzpczK/RORhtyk3r3FziZiGH8z9jKYnmRLuegjU9RVwU3W +MOg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=DqxVsMmP; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-113091-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-113091-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id l8-20020a1709065a8800b00a469a59d984si1976870ejq.469.2024.03.24.16.19.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Mar 2024 16:19:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-113091-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=DqxVsMmP; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-113091-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-113091-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id C40A41F2154A for ; Sun, 24 Mar 2024 23:19:58 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 834A8153515; Sun, 24 Mar 2024 22:38:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DqxVsMmP" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B95A1534F2; Sun, 24 Mar 2024 22:38:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711319899; cv=none; b=o3JDsWT0NoJ0xCm+W4Pkiv1tTe5wE5KgF18Suucehs1Msj/bVgz7SU3xFTGSbPnWQdGgxCWwSWw1O2CEKJA3we+i3HLgtmIaib3BF046IcKrflpnIdO3LtLQdAhdFqqTY4u8t9iAQlbrGqRjco7Cay5FEDimJPkfOXrVwqHV0II= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711319899; c=relaxed/simple; bh=l00MORsq8btbIiz1muHBw899LKnbLxaZxGNj39NOsa4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=QVCFNZQKU3TOHoxBNndw16N+Zqz3OMP7Ufne29TahotHzSTgyPnU/Ciy1ctW6Ph7ux2vG8aabNAFV3MkeDMrEsQ9X59cYSE3DyEY21jO1R9kXOQEauUeDrmZFSWjliwf+SO/7YLPNtM7YIYbROHQshYhSbonFF5xDh/iZnCgn0A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DqxVsMmP; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7C218C433C7; Sun, 24 Mar 2024 22:38:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711319899; bh=l00MORsq8btbIiz1muHBw899LKnbLxaZxGNj39NOsa4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DqxVsMmPewPPHtpEt76e0o1wOQc7GM/7L1NgOVQzCX9JlK2kV/mAw68PQ/qoE01U2 CDJPUCSYHof/UyNQ0cx6yHntayjehVr+M4ZMPJrLfK0cmuTkVBTO3K4Sij5lgCmK8x dLczbkcz9zdpLTDR1JO70zvFEBP/+6UrMIM1P6zPjjWplVwgfHsj3Uy1qo16MO+QRN /71xV5E2eZGSiN2ivE4LEOOozB0xxLD1n5dM0eljuPLMCPnfWai5L6VRoQiCUClKjA BAAfC4m2CTAokoqTyggrQ5Q0FHFmSa9ArUZ4J1LhHyz1SnV4bhDeOfvsAHgKQL3Bjr iGm6dGYzKZ39A== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: =?UTF-8?q?Alexis=20Lothor=C3=A9?= , Kalle Valo , Sasha Levin Subject: [PATCH 6.8 204/715] wifi: wilc1000: prevent use-after-free on vif when cleaning up all interfaces Date: Sun, 24 Mar 2024 18:26:23 -0400 Message-ID: <20240324223455.1342824-205-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240324223455.1342824-1-sashal@kernel.org> References: <20240324223455.1342824-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Alexis Lothoré [ Upstream commit cb5942b77c05d54310a0420cac12935e9b6aa21c ] wilc_netdev_cleanup currently triggers a KASAN warning, which can be observed on interface registration error path, or simply by removing the module/unbinding device from driver: echo spi0.1 > /sys/bus/spi/drivers/wilc1000_spi/unbind ================================================================== BUG: KASAN: slab-use-after-free in wilc_netdev_cleanup+0x508/0x5cc Read of size 4 at addr c54d1ce8 by task sh/86 CPU: 0 PID: 86 Comm: sh Not tainted 6.8.0-rc1+ #117 Hardware name: Atmel SAMA5 unwind_backtrace from show_stack+0x18/0x1c show_stack from dump_stack_lvl+0x34/0x58 dump_stack_lvl from print_report+0x154/0x500 print_report from kasan_report+0xac/0xd8 kasan_report from wilc_netdev_cleanup+0x508/0x5cc wilc_netdev_cleanup from wilc_bus_remove+0xc8/0xec wilc_bus_remove from spi_remove+0x8c/0xac spi_remove from device_release_driver_internal+0x434/0x5f8 device_release_driver_internal from unbind_store+0xbc/0x108 unbind_store from kernfs_fop_write_iter+0x398/0x584 kernfs_fop_write_iter from vfs_write+0x728/0xf88 vfs_write from ksys_write+0x110/0x1e4 ksys_write from ret_fast_syscall+0x0/0x1c [...] Allocated by task 1: kasan_save_track+0x30/0x5c __kasan_kmalloc+0x8c/0x94 __kmalloc_node+0x1cc/0x3e4 kvmalloc_node+0x48/0x180 alloc_netdev_mqs+0x68/0x11dc alloc_etherdev_mqs+0x28/0x34 wilc_netdev_ifc_init+0x34/0x8ec wilc_cfg80211_init+0x690/0x910 wilc_bus_probe+0xe0/0x4a0 spi_probe+0x158/0x1b0 really_probe+0x270/0xdf4 __driver_probe_device+0x1dc/0x580 driver_probe_device+0x60/0x140 __driver_attach+0x228/0x5d4 bus_for_each_dev+0x13c/0x1a8 bus_add_driver+0x2a0/0x608 driver_register+0x24c/0x578 do_one_initcall+0x180/0x310 kernel_init_freeable+0x424/0x484 kernel_init+0x20/0x148 ret_from_fork+0x14/0x28 Freed by task 86: kasan_save_track+0x30/0x5c kasan_save_free_info+0x38/0x58 __kasan_slab_free+0xe4/0x140 kfree+0xb0/0x238 device_release+0xc0/0x2a8 kobject_put+0x1d4/0x46c netdev_run_todo+0x8fc/0x11d0 wilc_netdev_cleanup+0x1e4/0x5cc wilc_bus_remove+0xc8/0xec spi_remove+0x8c/0xac device_release_driver_internal+0x434/0x5f8 unbind_store+0xbc/0x108 kernfs_fop_write_iter+0x398/0x584 vfs_write+0x728/0xf88 ksys_write+0x110/0x1e4 ret_fast_syscall+0x0/0x1c [...] David Mosberger-Tan initial investigation [1] showed that this use-after-free is due to netdevice unregistration during vif list traversal. When unregistering a net device, since the needs_free_netdev has been set to true during registration, the netdevice object is also freed, and as a consequence, the corresponding vif object too, since it is attached to it as private netdevice data. The next occurrence of the loop then tries to access freed vif pointer to the list to move forward in the list. Fix this use-after-free thanks to two mechanisms: - navigate in the list with list_for_each_entry_safe, which allows to safely modify the list as we go through each element. For each element, remove it from the list with list_del_rcu - make sure to wait for RCU grace period end after each vif removal to make sure it is safe to free the corresponding vif too (through unregister_netdev) Since we are in a RCU "modifier" path (not a "reader" path), and because such path is expected not to be concurrent to any other modifier (we are using the vif_mutex lock), we do not need to use RCU list API, that's why we can benefit from list_for_each_entry_safe. [1] https://lore.kernel.org/linux-wireless/ab077dbe58b1ea5de0a3b2ca21f275a07af967d2.camel@egauge.net/ Fixes: 8399918f3056 ("staging: wilc1000: use RCU list to maintain vif interfaces list") Signed-off-by: Alexis Lothoré Signed-off-by: Kalle Valo Link: https://msgid.link/20240212-wilc_rework_deinit-v1-1-9203ae56c27f@bootlin.com Signed-off-by: Sasha Levin --- .../net/wireless/microchip/wilc1000/netdev.c | 28 +++++-------------- 1 file changed, 7 insertions(+), 21 deletions(-) diff --git a/drivers/net/wireless/microchip/wilc1000/netdev.c b/drivers/net/wireless/microchip/wilc1000/netdev.c index 6c1058e5299c7..6068699e44109 100644 --- a/drivers/net/wireless/microchip/wilc1000/netdev.c +++ b/drivers/net/wireless/microchip/wilc1000/netdev.c @@ -890,8 +890,7 @@ static const struct net_device_ops wilc_netdev_ops = { void wilc_netdev_cleanup(struct wilc *wilc) { - struct wilc_vif *vif; - int srcu_idx, ifc_cnt = 0; + struct wilc_vif *vif, *vif_tmp; if (!wilc) return; @@ -901,32 +900,19 @@ void wilc_netdev_cleanup(struct wilc *wilc) wilc->firmware = NULL; } - srcu_idx = srcu_read_lock(&wilc->srcu); - list_for_each_entry_rcu(vif, &wilc->vif_list, list) { + list_for_each_entry_safe(vif, vif_tmp, &wilc->vif_list, list) { + mutex_lock(&wilc->vif_mutex); + list_del_rcu(&vif->list); + wilc->vif_num--; + mutex_unlock(&wilc->vif_mutex); + synchronize_srcu(&wilc->srcu); if (vif->ndev) unregister_netdev(vif->ndev); } - srcu_read_unlock(&wilc->srcu, srcu_idx); wilc_wfi_deinit_mon_interface(wilc, false); destroy_workqueue(wilc->hif_workqueue); - while (ifc_cnt < WILC_NUM_CONCURRENT_IFC) { - mutex_lock(&wilc->vif_mutex); - if (wilc->vif_num <= 0) { - mutex_unlock(&wilc->vif_mutex); - break; - } - vif = wilc_get_wl_to_vif(wilc); - if (!IS_ERR(vif)) - list_del_rcu(&vif->list); - - wilc->vif_num--; - mutex_unlock(&wilc->vif_mutex); - synchronize_srcu(&wilc->srcu); - ifc_cnt++; - } - wilc_wlan_cfg_deinit(wilc); wlan_deinit_locks(wilc); wiphy_unregister(wilc->wiphy); -- 2.43.0