From: Daniel Phillips <phillips@phunq.net>
To: Alasdair G Kergon <agk@redhat.com>
Subject: Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocked_ioctl
Date: Thu, 10 Jan 2008 01:49:15 -0800
User-Agent: KMail/1.9.5
Cc: Matt Mackall <mpm@selenic.com>,
       Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com>,
       Andi Kleen <andi@firstfloor.org>, linux-kernel@vger.kernel.org,
       kernel-janitors@vger.kernel.org, gorcunov@gmail.com
References: <20080108164015.GC31504@one.firstfloor.org> <1199909560.6245.67.camel@cinder.waste.org> <20080109224026.GA4039@agk.fab.redhat.com>
In-Reply-To: <20080109224026.GA4039@agk.fab.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200801100149.16301.phillips@phunq.net>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 737
Lines: 21

Hi Alasdair,

On Wednesday 09 January 2008 14:40, Alasdair G Kergon wrote:
> Device-mapper for example in dm_blk_ioctl(), has no need for BKL so
> drops it immediately, but it does need the inode parameter, so it is
> unable to switch as things stand.

So what stops you from changing to unlocked_ioctl for the main device 
mapper ctl_ioctl?  You aren't using the inode parameter, or the file 
parameter:

   http://lxr.linux.no/linux+v2.6.23.12/drivers/md/dm-ioctl.c#L1402

Regards,

Daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/