Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp2374766lqp; Sun, 24 Mar 2024 16:30:49 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCX63vJ0f37kvE5QjNydWBVS9vWAgtFU9RHdEoPf0hGkJUbBCU9Gq38zvzcADJwQqMh2NeS7qyyebdDSviOCSDe14rK50t4yCBbdzgULrQ== X-Google-Smtp-Source: AGHT+IFtzXu3HPecShY4FEe1RNV/yQK2d+3OrLAQUIkM8EQw2+DyZPB9jbyOj1yVP8xikVwXG6cu X-Received: by 2002:a17:902:e748:b0:1e0:3084:6cb4 with SMTP id p8-20020a170902e74800b001e030846cb4mr7130381plf.17.1711323049301; Sun, 24 Mar 2024 16:30:49 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711323049; cv=pass; d=google.com; s=arc-20160816; b=vpxvqqAu3ZI3phyOnO/EtNvh0XpJI9RZt6tN0aU6CQcecZoRj6LxqLIrJU5x61AYku CFgXIr/2UefjToXlphBxkW0vjLxnm9heuC4Lutt4CGEzcoPDLSUDh98re416Cy4XcaAB 6Ox7rqbdevyhzE9csQKRKyPmiHOsBFII/M1P9WJ//rRfjNjvWLSuxxUyZT1/6HGBmOe9 UPQfN8tB39/oHCI07A5cuU1bdGVSQDDEFe84735JfH8vmk5H3mpRA3m1MSfxLJrsAA7h dADRSnndECEJw2nSLbUcn++oEhwBb7GeGvhMxVCPVTbASOt7lrifyUxiCwDf5pt994Um bnGQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=iySPbq835gyAmg/pxnzcLWTRusa6ekEIi+UD5Z1GiOw=; fh=T4PpRYHpxqTIxfmMopkAzq3N3N2LBxQFKMvy79VZCv8=; b=mpq1k5rcqMVew9rEWJYO/egTIwm9VoJB6ggYz43KQUhxf9CsMe8Ofn5nTRw7OEOISc ShYSskYvjIEM0fF0dnRctGA/0Knc85v0pAXNqmu/+Uk7WJo9yEyFES47NeBKMqNU9b0c a6VOgXpZU5vzCpptNWIpWS6EykNY3WNwHNF8YDdUTZZjjTUcG1Yy4kQQzn2+tijEuGp7 b1O1fciVaRUujynOphULrzgu7ItAISv3i5Q7RGmRLlZds0BPqS0F4lQKrrYawcP6UVdJ Cnr4Lvg/DvjgUUK3q4WeezMDEmigAA9HHL0T8+xjF4mBx1TaS153JqL5A82K6nTwmB/g E5ug==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tKgvWbIJ; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-113090-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-113090-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id lk4-20020a17090308c400b001e0648e2349si716249plb.183.2024.03.24.16.30.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Mar 2024 16:30:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-113090-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tKgvWbIJ; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-113090-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-113090-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id A0396286ED2 for ; Sun, 24 Mar 2024 23:19:42 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4D1CD1534EF; Sun, 24 Mar 2024 22:38:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="tKgvWbIJ" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60577152E14; Sun, 24 Mar 2024 22:38:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711319898; cv=none; b=KF70yuTTP2hCI6RMLYnuT3DZAMV2FWX2vXgFMSCtVyH6959O/n3g/guz4sPDAK7umdsZIHTI/Ei/Jl/ccUxfi0e4pz4wZRlQpMxNUcCyGP07thrzA14oyxJSwX5aF74OwD+59KZf8LaoAGkKYs0eA4jXMT/zv2SxrCrtBIwsdwY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711319898; c=relaxed/simple; bh=qkyyFxehdzwxsIPB2u6hGwdn4DIIGZjJoaAfpK7eZzw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=f4/HQ+JG3uZ2UD/O2Q50gXkvBk2h3anSjebb46m2gugls1V215WUCwzpo6ZSw+Q5pe23QIdKWM3ZAKKPVTMtgALuYcVrz6M1dS4t8TbGEyWJ+tfD1Ma3ameOLvV7IyTMxrrY2LmOSGTVKLHh993mJm/DiUx8KLBDcbKIagI25ko= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=tKgvWbIJ; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 94856C43399; Sun, 24 Mar 2024 22:38:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711319898; bh=qkyyFxehdzwxsIPB2u6hGwdn4DIIGZjJoaAfpK7eZzw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tKgvWbIJFpLxfklYqX5XfJi1WtQzt6EAAdzTXCYofEn5rJLnKp+F5x7BB4+rsnkbZ cbEVq2WXwtGkW4Pe37Oq7LNf1j4wwMUX3a8+HobhWTGd9u1ge99SrKb6OlyCBNPnVi dnE/d7wNwYhgfY0fTeYz/gS04DrrsPH9w9eAqsjTdokadL6+ODpnlABqz5PTYa0Rus MSSrvVho0GgOL1q4QYyItkze3Hkjs4mjhpNrOvssalW7kZQue4MKNZyhApFf7pGQAA tA7+zTXiNOY8qFbbAKmOM2k171UklgFyDhhj6OckS4H0V/5hu/fcHfqgFf4hRE7tcs 4EOdxtUMrxv4A== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Arnd Bergmann , Viresh Kumar , Sasha Levin Subject: [PATCH 6.8 203/715] cpufreq: qcom-hw: add CONFIG_COMMON_CLK dependency Date: Sun, 24 Mar 2024 18:26:22 -0400 Message-ID: <20240324223455.1342824-204-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240324223455.1342824-1-sashal@kernel.org> References: <20240324223455.1342824-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Arnd Bergmann [ Upstream commit 3093fa33539b54db77171d2919352ad4f044a1c5 ] It is still possible to compile-test a kernel without CONFIG_COMMON_CLK for some ancient ARM boards or other architectures, but this causes a link failure in the qcom-cpufreq-hw driver: ERROR: modpost: "devm_clk_hw_register" [drivers/cpufreq/qcom-cpufreq-hw.ko] undefined! ERROR: modpost: "devm_of_clk_add_hw_provider" [drivers/cpufreq/qcom-cpufreq-hw.ko] undefined! ERROR: modpost: "of_clk_hw_onecell_get" [drivers/cpufreq/qcom-cpufreq-hw.ko] undefined! Add a Kconfig dependency here to make sure this always work. Apparently this bug has been in the kernel for a while without me running into it on randconfig builds as COMMON_CLK is almost always enabled. I have cross-checked by building an allmodconfig kernel with COMMON_CLK disabled, which showed no other driver having this problem. Fixes: 4370232c727b ("cpufreq: qcom-hw: Add CPU clock provider support") Signed-off-by: Arnd Bergmann Signed-off-by: Viresh Kumar Signed-off-by: Sasha Levin --- drivers/cpufreq/Kconfig.arm | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm index f911606897b8d..a0ebad77666e3 100644 --- a/drivers/cpufreq/Kconfig.arm +++ b/drivers/cpufreq/Kconfig.arm @@ -173,6 +173,7 @@ config ARM_QCOM_CPUFREQ_NVMEM config ARM_QCOM_CPUFREQ_HW tristate "QCOM CPUFreq HW driver" depends on ARCH_QCOM || COMPILE_TEST + depends on COMMON_CLK help Support for the CPUFreq HW driver. Some QCOM chipsets have a HW engine to offload the steps -- 2.43.0