Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp2391240lqp; Sun, 24 Mar 2024 17:22:27 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUY105rylo7BlZJ8wwhTQra77EmRZgfYztgHlZna+CgWyVOOIs6eRNkndpCrD2mf95FdG0Rne0mJp0EW03+9x5X4W5VnaadRRp6GWJZNQ== X-Google-Smtp-Source: AGHT+IEP24WsUBq8UrJSvfiMPVzurtBa3KnWUNoTU06w+SmTgA8gzcIOU8xN/ydiI6FLpXj1WlT0 X-Received: by 2002:a17:90a:c907:b0:29c:7536:bdec with SMTP id v7-20020a17090ac90700b0029c7536bdecmr5361550pjt.34.1711326147572; Sun, 24 Mar 2024 17:22:27 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711326147; cv=pass; d=google.com; s=arc-20160816; b=JTuUO8OaBQWZyZFT8IJxPSdN0BWIFepxzyKUajxe8m5stPnk2Djl4KfuGnaAKn/us5 6pF4BE5Op5spxci0UQZuusnIBHbJ8YFdfq4MGCzuh+qUAUGFo3T/yPvtF0DINWoRdD7/ sfNXO+f/AA4FK6LR+rDbm74mPy7N/bgOqk75QV3dNk900PySwB5fadH6RSqDASU9L6Bt O8btEjsHU0XxvYd4fwHIFkGImyQeHBbnhonYd2mLcizvOFAxV4B/eGtaV9xvFFDwxVTf DzNxCZlFU0HzH2P9Pm4WR0xQ66xcGQOEEqHh82fnOu0Zj3NMU8z8nhU2Or/mrIgD+Qu6 4nNQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=sTaHfHWkwEYtMqjU80nuzBjmusMaEornrpsRtKHWPA8=; fh=mcwsZsVr3lKblFkr14MVCDIX3OKqJ1Mtt4jrDo0UHLg=; b=EORj9rR6YaZXm3bA5xDAzcNPYf8eybN/YCfDqB52nWQh08pCqNcqm+Cisrjo4jYMxR DGL63chZ7Qu9NLM4RoDqHOq6ep5nYc4vOUVvGigKiDE2TUS94Er42w/Ia7J7x5sYf427 mGGljOzNWZB0rUZHKjpd2sjZZNnfMF6jUqVGrQ7RiHsphvArcWFVvFoWHuVKacirGSxN TFrBQ/Y6oaR/hpDk6+sfpj/95/yUMkxHquV+p3ujgLbKieKZytDg2sMBzH8JQHt/h1Uj SEPhWRgcJJeTJxMtIJ9Q2vJ18wcViBgSUsWr2JGlx2tdosSI5XSqol8LvYdmwmkdZ7ou NZrg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GkmJ4MJy; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-113379-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-113379-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id t21-20020a17090ad15500b0029969ee2a08si10054006pjw.52.2024.03.24.17.22.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Mar 2024 17:22:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-113379-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GkmJ4MJy; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-113379-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-113379-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 38B8E2833E7 for ; Mon, 25 Mar 2024 00:22:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CE7066EB78; Sun, 24 Mar 2024 22:43:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GkmJ4MJy" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E29E119FD82; Sun, 24 Mar 2024 22:43:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711320181; cv=none; b=g1PtUiyVVBD4+yZQAhsldRVd18pd8L76+zdiaOR+AG6feQiz49jJyXejDjNNSQ91KOfIq3NSIOanx+FCvMjfYiP4eWOehCttmaJGekcFm0ID5QJH2HC0+Z2bRgYv0s8axXOOApW1dJpN5m69y8RkLR9fKh98IMQdk1JjRCFPwB4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711320181; c=relaxed/simple; bh=QKC9+Re7sEtL0gom4oBbG8bBk7rzUVifjFxB/JrvpDI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=dW3OTGZS1t2/TdqM1tCKBfshCW1OE6ZWWP7WOAl4bfL6+gEUIVbG5b6g54c4wfpSOc0vC7n5fFGCXdqXoprbpDW4oHpCywEC3XM5Nabfp6mvh8DzhrHJTVKHUTkaiaxBEepAlh87kIkmMH2uY8xTPLBKVlsG5EXGmPvNBuW7Lo8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=GkmJ4MJy; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id AFD57C43394; Sun, 24 Mar 2024 22:42:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711320180; bh=QKC9+Re7sEtL0gom4oBbG8bBk7rzUVifjFxB/JrvpDI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GkmJ4MJyP3mDQSIY+Ktp2zaLuW3745jJjk9BhTUBH6QE/pewENESQ28OdBvxhDb5W MnDSV3WXdnsD0eYAphGli17lGbjCkBtEelXVIidq/4p5+CB/BlMgdOZmka2wp4bHIJ Z5ohLgG/e74/KmK/iTSdAoRMAYTFEiRSygLlwQVrqp05Z+Mw/WPVKQ9IInb24W4ec3 5XKiFD1m/4X+AX5P1ZHOld1hSrMXPV0URnlyZThwYSXQGTJPHqI4+xWAdABm7Fifax dZxp9KfmqjvTeiDLZcz8dbJ28tPR5M2mrW+MsT3sisy1TZoydRfrvaPgKWZt7O/lUn iJmOw2gQw6FZQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Srinivasan Shanmugam , Jammy Zhou , =?UTF-8?q?Christian=20K=C3=B6nig?= , Alex Deucher , Sasha Levin Subject: [PATCH 6.8 488/715] drm/amdgpu: Fix missing break in ATOM_ARG_IMM Case of atom_get_src_int() Date: Sun, 24 Mar 2024 18:31:07 -0400 Message-ID: <20240324223455.1342824-489-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240324223455.1342824-1-sashal@kernel.org> References: <20240324223455.1342824-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Srinivasan Shanmugam [ Upstream commit 7cf1ad2fe10634238b38442a851d89514cb14ea2 ] Missing break statement in the ATOM_ARG_IMM case of a switch statement, adds the missing break statement, ensuring that the program's control flow is as intended. Fixes the below: drivers/gpu/drm/amd/amdgpu/atom.c:323 atom_get_src_int() warn: ignoring unreachable code. Fixes: d38ceaf99ed0 ("drm/amdgpu: add core driver (v4)") Cc: Jammy Zhou Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/amdgpu/atom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/atom.c b/drivers/gpu/drm/amd/amdgpu/atom.c index a33e890c70d90..ac51d19b518ca 100644 --- a/drivers/gpu/drm/amd/amdgpu/atom.c +++ b/drivers/gpu/drm/amd/amdgpu/atom.c @@ -313,7 +313,7 @@ static uint32_t atom_get_src_int(atom_exec_context *ctx, uint8_t attr, DEBUG("IMM 0x%02X\n", val); return val; } - return 0; + break; case ATOM_ARG_PLL: idx = U8(*ptr); (*ptr)++; -- 2.43.0