Received: by 2002:ab2:6857:0:b0:1ef:ffd0:ce49 with SMTP id l23csp2391415lqp; Sun, 24 Mar 2024 17:23:05 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWC70V7xFRToVVP8eMGrTrsdtfTn4/i+Qmgs0leu/bmqRAEWAWnEL4U1DtQqKd4zz3r9jaRz8r21OXoOZ0C71e1x9b8bjE6fAPJJAETAw== X-Google-Smtp-Source: AGHT+IGJ6sBWqgS7ZilAm5cDBwDT8d/3RKij0C1LP2HuvpW4cAIXpysB3og2vA4Px45SIDDEZmyD X-Received: by 2002:a17:90a:dd86:b0:29f:cbd8:ea11 with SMTP id l6-20020a17090add8600b0029fcbd8ea11mr3783507pjv.15.1711326185678; Sun, 24 Mar 2024 17:23:05 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711326185; cv=pass; d=google.com; s=arc-20160816; b=jWv6+lHT6V9oBgUOkqnOogP/txsANXFTLdyZtu8OMZTTjIdaHnCP6FUSMSy0zIm5XI NMCV0y89OBlJ+od9JqphydZsqKdNvtWPLYu6qR2i9+OJMsF2LX+5Z1b5X0/arW7bIi5v Bm30GfVh+9kCKrZnaZMGvhZufJfLss7Sp/GuV1sPqWJ0q0ZcaCikijYlZKHts0J+7fs4 FlMJYSGDZuBXFIipH2o3Wf0ZRpnnJ0hpplVnIW9ytF824uy61/4AlpbQoEk8m17Zfp+X gDobHpWxwayEdZIyCZKbdMcPyTf1YJuKYb10ruF08Y+1cfAIUYGVbsAVLO9v7aDXLmoU aOqw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=x4IYBuXo1MlZtDOD37RRV8xCf2J8MGCW8h5QK+uMAJw=; fh=GY+rq80PW5p4AjzPu5MN1xhO32CWE0M2ydDybaxr8po=; b=zHJnn8dUsfvXSo6wFDPUD8BQL3tpF0AQ7C73WVQmH6rpL4NTFmGvG7i5F78Auo207E 897m8KEtICkwFFWwk60pRH/QH3lr/W0ZtZ+lI7d4xYoDtjPpiSBiGZsn/TxApbnI74Dr KZ8yGn04D0P6GkbUOx9ELUDZbDzaCFYUXFxVqD6BaBaU9jfBJXYoy1B9RxPTw4qXxqBE gay6tiFywLCGvkPaKOIWrlM9L6Zit1uoU035ERfpBkWVu0b4poMBxqhgD9ConQjD149C uSc7ur0IP869Mti5SOdAmFrrWDfXywLL3x4Hej3Fellj69vPIQtulxAj+OiVsrT1PwGP 8BvA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WlnzaLY9; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-113339-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-113339-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id e3-20020a17090a6f8300b0029bb32706b9si10200188pjk.47.2024.03.24.17.23.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Mar 2024 17:23:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-113339-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WlnzaLY9; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-113339-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-113339-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 1E725B23B31 for ; Mon, 25 Mar 2024 00:13:17 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6D53F198302; Sun, 24 Mar 2024 22:42:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WlnzaLY9" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8AF0E197CAB; Sun, 24 Mar 2024 22:42:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711320140; cv=none; b=RbOpGVNw8ASGHhXnEhNzZNp19ffxbVbSL4jsfW+o6ke20Kbyubk5FTY2h7l8dsCdYAC1pj6ZklhQWpAhzTKV/8IpSaOdlgFGTX6VlFPi/H6FmH6hU+A6jsY5FD1IHsK/9jm4BcuAE+HSjB8pWoYJX1HNo31Bdbf/zKFENmZbBHo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711320140; c=relaxed/simple; bh=03PMzaGnZQiUzLPb/Zjij3vJldyv3GiCMg42UjCblhk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=nrsUq+BIaH4Hs2O2/sZj8azknKc6vhfd+3/s02YeAppX1dHfX2Mz6chEUypxDoLCP/i0HW3p3GnP+eNBb790WY/lJAGr1GZj+yb40FFAZiJFQR+N9vgzRiUmUTk8FNYzYd+9ssXjJTiDDoKJ7+r2jsUlfPopGDyWXvDoUBlEPzc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WlnzaLY9; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id B9D7EC433C7; Sun, 24 Mar 2024 22:42:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711320140; bh=03PMzaGnZQiUzLPb/Zjij3vJldyv3GiCMg42UjCblhk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WlnzaLY9Na3U0GI9qz9v4ECMmJwAhDapwH6XRuTeC7ULZuiQzL2UqijiYMvF67+Te RKy4vUjg/4/DsssKd8Mqx/4uOKaXBFOkuCRyEhqzWGYUrUyVHFafr6bmmeXgZJ/H5A KWdDA8I4pDReSc9Mk3SjPkOHHJVScVlIgfdIBj7Iy7mU9PG3z+nP+Vug9UZU9FigpQ zTriORl2l5iGZmairhpWBPuVCnSqOlDB8AFMkib6z/F7HnxaQejucBnHV0u1i4BWzw jZ23kUy2rvZPaFM03QpP2VHNZfJxesJanSMKfhS78ili81iDRpFugPC9x0tj6BDBuV Wm/7Ijf7JYQXQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: =?UTF-8?q?J=C3=B6rg=20Wedekind?= , Bjorn Helgaas , Sasha Levin Subject: [PATCH 6.8 448/715] PCI: Mark 3ware-9650SE Root Port Extended Tags as broken Date: Sun, 24 Mar 2024 18:30:27 -0400 Message-ID: <20240324223455.1342824-449-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240324223455.1342824-1-sashal@kernel.org> References: <20240324223455.1342824-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Jörg Wedekind [ Upstream commit baf67aefbe7d7deafa59ca49612d163f8889934c ] Per PCIe r6.1, sec 2.2.6.2 and 7.5.3.4, a Requester may not use 8-bit Tags unless its Extended Tag Field Enable is set, but all Receivers/Completers must handle 8-bit Tags correctly regardless of their Extended Tag Field Enable. Some devices do not handle 8-bit Tags as Completers, so add a quirk for them. If we find such a device, we disable Extended Tags for the entire hierarchy to make peer-to-peer DMA possible. The 3ware 9650SE seems to have issues with handling 8-bit tags. Mark it as broken. This fixes PCI Parity Errors like : 3w-9xxx: scsi0: ERROR: (0x06:0x000C): PCI Parity Error: clearing. 3w-9xxx: scsi0: ERROR: (0x06:0x000D): PCI Abort: clearing. 3w-9xxx: scsi0: ERROR: (0x06:0x000E): Controller Queue Error: clearing. 3w-9xxx: scsi0: ERROR: (0x06:0x0010): Microcontroller Error: clearing. Link: https://lore.kernel.org/r/20240219132811.8351-1-joerg@wedekind.de Fixes: 60db3a4d8cc9 ("PCI: Enable PCIe Extended Tags if supported") Closes: https://bugzilla.kernel.org/show_bug.cgi?id=202425 Signed-off-by: Jörg Wedekind Signed-off-by: Bjorn Helgaas Signed-off-by: Sasha Levin --- drivers/pci/quirks.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index d797df6e5f3e9..2ebbe51a7efe0 100644 --- a/drivers/pci/quirks.c +++ b/drivers/pci/quirks.c @@ -5527,6 +5527,7 @@ static void quirk_no_ext_tags(struct pci_dev *pdev) pci_walk_bus(bridge->bus, pci_configure_extended_tags, NULL); } +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_3WARE, 0x1004, quirk_no_ext_tags); DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_SERVERWORKS, 0x0132, quirk_no_ext_tags); DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_SERVERWORKS, 0x0140, quirk_no_ext_tags); DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_SERVERWORKS, 0x0141, quirk_no_ext_tags); -- 2.43.0