Received: by 10.223.164.202 with SMTP id h10csp3352667wrb; Tue, 28 Nov 2017 09:56:29 -0800 (PST) X-Google-Smtp-Source: AGs4zMaNzxy7XvinKPq13GNoHrrUJNaWGhvIa8JZN4NMSpSLZuoTzXiUy9D3iCZ49VfbcbD+P8Tm X-Received: by 10.159.197.65 with SMTP id d1mr636plo.58.1511891789778; Tue, 28 Nov 2017 09:56:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1511891789; cv=none; d=google.com; s=arc-20160816; b=xZf05kzJU/dcm6GCy7Wq+xfQv7a3kon1J+zckNznYZJ2NFSyab8/z3niQibeZKJKU6 Y07ii+6DY4NsVo0WhotUfONajbjowjmiM2ip5qIx8dKtyxBD8pEQhcrwRm5aAAw5BUL/ r5IH7TCm2cAIFNh2nm/QNNNo9HIyz/Ok+dVpmTxUtcUtKdtMdj+lVP+UfWPu03KiUdQk R3dKWbJCfB8EYrKg5qOBvWT0HLaXWzL2YIKkrbb4KPWFdFxBISHhTY4YUq45sKZ7L52e QtBDbBa16tphmHS5Ah3lDT2wmyDYvXqhy+FTp8ASsPhq/vexCtRcCmhEzmf9MMM/lgtl 1RXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:spamdiagnosticmetadata :spamdiagnosticoutput:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature:arc-authentication-results; bh=p22eSQ9tUwisLmjz/HeqVq+EL5WckpqLTVbrOpfu6ok=; b=iVZ1z8NgAQA2Apd1AMoQi2j60H6A56PODPt9OND3QLfM9b2eRkVXcLMbfJ4B4Gbsmf 0qIqT1O8EeTP3LQLblwa5//Vgw/IPhjh4OlJ7f8AqleHf8ZyVs/r0FR6u8XuYSIdPBVu VS1FqXU/H3U4CSG4yywKOOCcY0rZeixtOMq2yIh2h0spkSva3VysjcLl+hTSHJSLIJlV zgWgr87F49TaIh7dfinsdkxC8UZ0/vHCgyyHz42NHmi1DRRtCtoawzqkPEGWBTJxAF3B TFaYDtdOI9LNTVIHvjYByuYiwQx8NcqZG0Ap3/BmgloiokTwfjye3ZtWs3VMZS3dULv0 ZWjQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@Mellanox.com header.s=selector1 header.b=M7b+0ZmD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mellanox.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 34si25584174plm.154.2017.11.28.09.56.18; Tue, 28 Nov 2017 09:56:29 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@Mellanox.com header.s=selector1 header.b=M7b+0ZmD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mellanox.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753476AbdK1RzW (ORCPT + 78 others); Tue, 28 Nov 2017 12:55:22 -0500 Received: from mail-he1eur01on0085.outbound.protection.outlook.com ([104.47.0.85]:63473 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752734AbdK1RzU (ORCPT ); Tue, 28 Nov 2017 12:55:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=p22eSQ9tUwisLmjz/HeqVq+EL5WckpqLTVbrOpfu6ok=; b=M7b+0ZmDA9IHIJGYqzBTKOHfeT+XRg9YQ0STOYtAaPTaJ2LnuX7QIXOu+G+iQOAThHdRQIUQz0C208aGMhDn/3S0ZhIRjHrUSGLuLq0Y4mY5NB4+T2AVt69W+y6+k1sdJg+4CSQGfIvrvIYXyR/A+rrux97XuMY4ou7FTVZbh3E= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=leonro@mellanox.com; Received: from localhost (213.57.247.46) by AM0PR0502MB3908.eurprd05.prod.outlook.com (2603:10a6:208:20::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.260.4; Tue, 28 Nov 2017 17:55:14 +0000 Date: Tue, 28 Nov 2017 19:55:09 +0200 From: Leon Romanovsky To: Vasyl Gomonovych Cc: dledford@redhat.com, jgg@ziepe.ca, yishaih@mellanox.com, matanb@mellanox.com, don.hiatt@intel.com, dasaratharaman.chandramouli@intel.com, noaos@mellanox.com, parav@mellanox.com, artemyko@mellanox.com, bodong@mellanox.com, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] IB/core: Use PTR_ERR_OR_ZERO() Message-ID: <20171128175509.GQ29104@mtr-leonro.local> References: <1511882287-450-1-git-send-email-gomonovych@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3xQkynibq3FKlJyM" Content-Disposition: inline In-Reply-To: <1511882287-450-1-git-send-email-gomonovych@gmail.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Originating-IP: [213.57.247.46] X-ClientProxiedBy: HE1P191CA0024.EURP191.PROD.OUTLOOK.COM (2603:10a6:3:cf::34) To AM0PR0502MB3908.eurprd05.prod.outlook.com (2603:10a6:208:20::26) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 8f6dec48-3573-471b-15b9-08d536892dfa X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(48565401081)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603199);SRVR:AM0PR0502MB3908; X-Microsoft-Exchange-Diagnostics: 1;AM0PR0502MB3908;3:WJTnoVmwX41rdvmW/pZNoEqzkveMg2mXE8MNUCTSAb2cJrmZ0bn6+3PZPbpGhhh6Dyxd4UZynE2sqPs5lKUfpFKdFkvXFzCHq94WX59wSFwi/D5SBS9LfiwZs4u8HBcBRujvD/mQqLQjge06S+s7lWu8sekPJk0xz1Ajq5thhQWIlAdkp7GwwfNSxwLEK7ayBuoNEj21yIzWKv3c7PIo+3a8Qbrj/pJvfJBjNGIoXNgbdn7ApvOQ1uHdI5TNiwrI;25:Y9JIl2N7pNpfYX/6EZ9cr62xYp5ely/3ZOTWuB+xYlk5NoAvMXk/IqXMKzFkSZcW3oJRaE1aNClAWpTMH2OprnPCX+ZrlWJwR6IMNKkHXzwx3yuEDoZsxewd4nwK51M6L8M9XgiTYiLFgbOGeR22X9anUJJneLTSV2fnhO04+Cr/7qmHM79v5yMUWmMlA9ddhBa+gxOShWYDEqAZff9IyW8Vq4Vw53MdEQl+WNkNIA+S8igyy40A54Ag7n1P5p53tkBtN/uAPQxGyXTNbv2ROljrKhhVguXyTjUxLKWnz5mo3PFuiLRKd1BByedxY4zi4A9Zb0z7TsBy0X9FPBmnog==;31:6iqQ3qxiphbxJMuwO0+0ZKuX5gjjxH/LHcWFueJVgX3B2QceG9kjTpiaZRfEFK+nOTOz284/JwoL8+Qw4NV0mFfL5KsZtRR2SMXDzMddWLVrzJSSpeX21Ke7wMWRoFyYF5qqvgNpHtG8buizXCCYllQghB8J62U+IwJxjTsUlQgZ0d6dMF688amaPYjzJy/sDMVqEqax260uNvcayBrwkWLnz6IsTlM7xda7ob1e/ZI= X-MS-TrafficTypeDiagnostic: AM0PR0502MB3908: X-Microsoft-Exchange-Diagnostics: 1;AM0PR0502MB3908;20:K7GAHbmLFhQ2wlBYj99qVZN5lJVTz7PElimE4roztnm6V2yuHzoLjDPsYyNbBGDxnsOdHsNL3dOaLScenyiO0aGjLBQVP9/UYyYqvbpst92Dp9TDTQ21nRONzv3n7QX3kD0vZJyz4zL+qk6vitko/EC+SAhPjtSCB+xhf6A7wmHzCJalxAgUgu4KCJR+u6+87n0e+bn8Mei9QeGLPUZFSqNCvko1cHBvPmctzWYopjuhZ9OtreAXi8ODvmSPXaIGn9UTH8yJTB0+8+g2igWbmWlvtsWDNCp779kE9gqtJq/Rk8HIQ8cp9if8uRCnVxFcR1EkrXlTsLewqZoUXkbqzJrjEU1cVT6zZECiaA2Ax0hYUQleSejiXVd93gYX37tJr8o7eW/8IzStEib5hAryCW4G9QMBLCDO2K082RQ7fr2ywlbuH+WzFdAKUEzVkLEipvvIAb9T8XFWJV/unneLK6tHGzsgWep2o8UDj5Aym3J/HC5YAICmAcL1iM3Nj3Ox;4:OkllHXf8WoSbw61/b303gztRJ2do5rh2iRYuW9kLU2dQmI0hUeFXcQkUU0sewYaptfK6DnbCAwAZXUDXhB7fEXrgt5c1IKAQ5Veo6+N6U9QFqeHv6sfKX3f7XKtsQDZZnr7Yb2tonfSQW3atLmM+zZjfSGxtJWIrLDdiq/X7d3WZtvHIM/UU80MA+qtLhSF2DUDVyZQxw3aDrjI111+0n1TZtNMYwA/XZ1m7l3UkG4QzHmWtY3skVw9vV46sBcMtfrypCi50w/R4FaM5ru88qA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(2401047)(8121501046)(5005006)(3002001)(10201501046)(3231022)(93006095)(93001095)(6055026)(6041248)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123564025)(20161123558100)(20161123560025)(6072148)(201708071742011);SRVR:AM0PR0502MB3908;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:AM0PR0502MB3908; X-Forefront-PRVS: 0505147DDB X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(6069001)(366004)(346002)(376002)(39860400002)(199003)(24454002)(189002)(76506005)(50986999)(2950100002)(6666003)(66066001)(98436002)(8676002)(305945005)(7736002)(81156014)(101416001)(81166006)(97736004)(21480400003)(6916009)(83506002)(33656002)(54356999)(76176999)(189998001)(5000100001)(316002)(25786009)(1076002)(6116002)(5660300001)(4326008)(3846002)(6486002)(6496006)(1411001)(52116002)(16586007)(63394003)(53936002)(58126008)(39060400002)(229853002)(6246003)(478600001)(2906002)(86362001)(84326002)(106356001)(8936002)(68736007)(105586002)(16526018)(9686003)(18370500001)(2700100001);DIR:OUT;SFP:1101;SCL:1;SRVR:AM0PR0502MB3908;H:localhost;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;AM0PR0502MB3908;23:XR4Jh6Ml9Z1Uz5NprxVISbYRHDkSepVS6HTfZl8?= =?us-ascii?Q?e7AH20Dyk8+tATz9RZh18Flf+7KQ8j3mAnY98RoeFuUUESYM2xhvgGjDEz5w?= =?us-ascii?Q?mbiDkBKNVyJ4dKQLZ5tdDiuPst15mr4clfkCjKVbszGLTpZy7UOG50Dj04eX?= =?us-ascii?Q?jnzTbao3mQ0dJX7oD75UsvZO3pjldtRgAbFE+AEZ463gX3Em0XxeQrw6AMuP?= =?us-ascii?Q?7IcKSUwYylo1IGXo4FzvCg3zuZjadD5qZIxLZ3beoatWAsXqGh8VSO/pGWnU?= =?us-ascii?Q?CAyLzTS0PjDPWcu7XCIYn1Xdbx42vXnphWGoGg/T/jCliB9aNRZT5VMbtP2j?= =?us-ascii?Q?cqJ5H28IGN6Uw0h1kEuCKcLihl7lreAxo4S7EMPw12VfuwPtJKL3xN6ul4Tn?= =?us-ascii?Q?LEmeO+MA/LMz08F0DueEZrE+/o3f/oROpFvPkmQu6zOYVr6A5f09L/D2r1Rc?= =?us-ascii?Q?Vaz74F11aGXbNVPp9hwelv8pgYXGmNYncq9KjBpIX3UyPopalpP4Cve0pxVH?= =?us-ascii?Q?l1ZzQAl5LNF55bvGBgwh7JJV78xNZvMvTCXv0ehlOiXB8L5tTvOCNqnp1i3z?= =?us-ascii?Q?uTazCDbndeZN7jirxOsKhZn1XZLH7onZMakhq2Byu1BxfbVYFMNh1Sg7BEOo?= =?us-ascii?Q?krYbD/FAm8iwp4P9zGK5iCLaaba40yxlHsWHGva+c9/8zYmZQ9pzEU2WJGDh?= =?us-ascii?Q?sBF6LkTul8Vg/UTCwvirtL+016I3YX+8/OciGrlKDhLGJIkMs3zUIzso+IXy?= =?us-ascii?Q?e8bH4zIiILk9Y1cffdJWaHY+0unOb5Oc5L29rgjqlGT/d9xTRiUzQFSKNHr2?= =?us-ascii?Q?b8fcxNS6OJiy/rYgfN+ZBjGMmExL/FsbTgFUzjtgL3r7QUYKslDbaUihnq1j?= =?us-ascii?Q?yHWH+ZZ4f1TMg1KTiXurGoekXJRyxkf8oG1C/x1Hy9vBQo1rIv7owstUczTg?= =?us-ascii?Q?W+UNsXAuRokItdbje40LksKvMnHnTyvl8sJWgkVyuMRjwn2ydegzDiliKU38?= =?us-ascii?Q?sP7GOrTF5oK1AEOLyJMkDmtlSXcg87D85kkLUe0r3aW28evLvMK3KRal0Dwr?= =?us-ascii?Q?Yq8pjXGEbxuyUYR/blgLL8103iQoaEAYQwys6GzW1pd0qVwiB6Rw1kvOk5LO?= =?us-ascii?Q?tBD3bNV6y+K5KJ2HJN4vNHCC7+bwic2fV1MgSTtKpd8e0gaFgB1WL5yqy+pa?= =?us-ascii?Q?o+XqSpFcuFki7T5l5xwE3IhcGr5aAVF70Y7kluFa7GuYpV2SQQNDmPl/+w15?= =?us-ascii?Q?aOLlrU6cktWacBbn7N67m4EovVJBecZ4K4BXHm0EtQGHGceFJxRzuaAIW/KS?= =?us-ascii?Q?poLbTNWnsCh5eT8h0cBNBVHjJ96KT1XuqAzPCZX9WNk8ssL03YrKvsk31UHq?= =?us-ascii?Q?lOjEqJOkp+HBMZtgzLe/TTZEi8RY=3D?= X-Microsoft-Exchange-Diagnostics: 1;AM0PR0502MB3908;6:PJ0+10FRdGJ2KF/uH7FYjArInfysnVji4mOBpbLtYls6jq4iauaq/cFOaf+MmrSbWrSL+F4KUXHDec5sXDLVP29Ws4aoDhid5Ju4un04Eys6+r/ldRxCTIamCp1R7gI8P4uFBUs6vDkO6L87UVWqKMsIwuuwjQulZPbhiStD0FCB46yq/ekJ7qTaoXPE1kYwN2wjtLzh1MwlPp2Fp51jHbD9V2u1Net+dCBjaE8n9QZYRgQEUSZTucLNV3kczy0kXpietdJ8x29ALPz1EpkTRjsKT2DvDGejNbI8PDXCJnSKKDAZx4hodiSf89RhgUv45mjU7iSDddISXgtjkfxpA8gVwp8dqHq7izSVzGLb4rc=;5:BL6g2aqp0eD0amb8AwE8W7m2Qkiwlc/vRESuUNFXQszjhC3QlCfLecpYESkmHAr2Yw6NGUUKTe+YU+hBSspPAs4NwM5k04yrr7Wo7Zn5Msx45MM+FUxGzMVZAcfE7UFid1a1TP1xZTbUxJ8GA6LmDerS/ziKRp53R2lWkvaLUwU=;24:YdMd9PfbbPhuGoSLzF4b0oyrh67foN3HJAmWbg+CdvcZEnyPktFOwF/DMOjsMZFXJ9T3q3xZI31OHdW6hgl+kFSYNAdMYpo9BInDBsWppDM=;7:C1Dw0gbO+iEpnE6POraqYv5uEybpv4tv9YrV6jf9SSZu4ObB4oqMxeAhemEHGKwwDZ6t1xCqbSi71ih82e8eWUli6rWhLWfO05wbYy1QkOoYRLfiHgHAP1S02oaTYgG37xmgrtfGRc/0DKSuXq7n888DwqsJx+KLa77bIpTIiQbHaXASvkN3C59ycjS3nfziZBQ4wuGWzTaKMnfBmFUCuVD2hpJjEuxDxz9QbDT5tKgAq2Tzt3N6p6YP4NtSfxrE SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2017 17:55:14.9451 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8f6dec48-3573-471b-15b9-08d536892dfa X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3908 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --3xQkynibq3FKlJyM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Nov 28, 2017 at 04:18:07PM +0100, Vasyl Gomonovych wrote: > Fix ptr_ret.cocci warnings: > drivers/infiniband/core/uverbs_cmd.c:1156:1-3: WARNING: PTR_ERR_OR_ZERO can be used > > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR > > Generated by: scripts/coccinelle/api/ptr_ret.cocci > > Signed-off-by: Vasyl Gomonovych > --- > drivers/infiniband/core/uverbs_cmd.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky --3xQkynibq3FKlJyM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkhr/r4Op1/04yqaB5GN7iDZyWKcFAlodov0ACgkQ5GN7iDZy WKfFYhAAhrBAydj11LeB+l5W5mRhhR0ejSigLpTsJzXA06G42XRWavhpPSjcMcyC 7g5PjJu9Ez6ixh9VxSkTiLIrPcuau9meUgHPoe1cnEgI6yQaM/61LJoEQGDWPXRU VTphMcWjXX9P5VfQQGKfiVJ0hevUNae8T3nY1lVEEgH/iV/1zq+R8cS5Dh1TMJNJ gHNVTkG1eWCdFZBrXetMmiet+bqd6duiVeme3sUmGdBqeZUjO3+jIUTAMawXnXaB vOaN+in/LNnDOhA93quRRK0wDR7uskQD1CNYAFJyBOq8As6Ldb8am+tG4O2iB8O+ sza0TZOf5z/qWN03DpBPxW+QROpWwip3Z4CghOwf5TXmGTifiE/bHX/f8OEkunMa 6wq53nOXyCo69+S0dVgGQsE94hYIcNfrEmOpYVxi8aZ604bHV4cSeMC0+0h50Btl DJXU/9PnzHMiPtAGYkRhcCVuJ+4tk8/CJApTjK5WkU+W3c9L6520mCwCLwvOSvP1 BQ9JxNtbLdt/B5ZFHeoOye7o68VDdn/egw06eLONGN2P/M1910IVi4kjy0R6nhtJ 1MBm+glpG/Xn1EeRjeHf+aEeABIeHSvZlYQSFvsl+CJ3jRbL8a7pWdYEb9zEpdmX I4IS7MinyRb0aQEvdFjaDOxT+h7kJfNb4StpggePisZo4FpF8rU= =gPy7 -----END PGP SIGNATURE----- --3xQkynibq3FKlJyM-- From 1585323619464794013@xxx Tue Nov 28 15:20:19 +0000 2017 X-GM-THRID: 1585323619464794013 X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread