Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 0/4] ARM: ep93xx: ts72xx: Add support for BK3 board
To:     Lukasz Majewski <lukma@denx.de>,
        Hartley Sweeten <hsweeten@visionengravers.com>,
        Arnd Bergmann <arnd@arndb.de>, arndbergmann@gmail.com
Cc:     Russell King <linux@armlinux.org.uk>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Olof Johansson <olof@lixom.net>,
        Linus Walleij <linus.walleij@linaro.org>
References: <20171116232239.16823-1-lukma@denx.de>
From:   Alexander Sverdlin <alexander.sverdlin@gmail.com>
Message-ID: <0041277a-f580-1c35-7a6b-5154e676e82f@gmail.com>
Date:   Sun, 19 Nov 2017 22:28:03 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <20171116232239.16823-1-lukma@denx.de>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hello Lukasz!

On 17/11/17 00:22, Lukasz Majewski wrote:
> This patch series adds support for Liebherr's BK3 board, being
> a derivative of TS72XX design.
> 
> This patchset consists of following patches:
> 
> - ts72xx.[c|h] cosmetic cleanup/improvement
> - Move the common code for ts72xx and BK3 to ts72xx-common.c - this
>   code can be reused by other designs build around ts72xx
> - The Liebherr's BK3 board has been added with re-using code of
>   ts72xx.c
> 
> Lukasz Majewski (4):
>   ARM: ep93xx: ts72xx: Use DEFINE_RES_MEM macros where applicable

The patch 3/4 deletes everything added by patch 1/4, so I don't really see the point of it.

>   ARM: ep93xx: ts72xx: Provide include guards for ts72xx.h file
>   ARM: ep93xx: ts72xx: Exclude reusable part of the ts72xx board
>   ARM: ep93xx: ts72xx: Add support for BK3 board - ts72xx derivative

I tend to agree with Hartley, if you'd just add all BK3-related extras to ts72xx.c it would
be less than 60 LoCs, you probably even do not need new Kconfig options.

Alex.

From 1584302819815357443@xxx Fri Nov 17 08:55:08 +0000 2017
X-GM-THRID: 1584302819815357443
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread