Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [RFC PATCH] KVM: x86: Allow Qemu/KVM to use PVH entry point
To:     Paolo Bonzini <pbonzini@redhat.com>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>,
        Juergen Gross <jgross@suse.com>
Cc:     tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
        x86@kernel.org, xen-devel@lists.xenproject.org,
        linux-kernel@vger.kernel.org, rkrcmar@redhat.com,
        JBeulich@suse.com, andrew.cooper3@citrix.com, kvm@vger.kernel.org
References: <1511897682-32060-1-git-send-email-maran.wilson@oracle.com>
 <176188ca-51f9-ef12-6e93-46ab2d8b8cfc@suse.com>
 <20171129085044.kc3yqqdcw3zmp2k2@MacBook-Pro-de-Roger.local>
 <4d213199-ea65-4410-5b7a-63038215e380@oracle.com>
 <0162f2cd-2d9e-1c89-bb8e-7ac0089f0b3a@suse.com>
 <20171129141810.q3s3xflsflpjovdd@MacBook-Pro-de-Roger.local>
 <96f9b4a5-7cb6-19c3-227d-8c48916d5969@oracle.com>
 <25d6db63-a57d-b15c-2d43-e96c506b4824@redhat.com>
From:   Maran Wilson <maran.wilson@oracle.com>
Organization: Oracle Corporation
Message-ID: <ac4c7e15-2715-b889-9ae5-42b3c5baa332@oracle.com>
Date:   Thu, 30 Nov 2017 10:23:17 -0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <25d6db63-a57d-b15c-2d43-e96c506b4824@redhat.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 11/29/2017 6:44 AM, Paolo Bonzini wrote:
> I actually like this patch, except that I'd get the e820 memory map from
> fw_cfg (see the first part of
> https://github.com/bonzini/qboot/blob/master/fw_cfg.c, and extract_e820
> inhttps://github.com/bonzini/qboot/blob/master/main.c) instead of the
> second module.

Hi Paolo,

I want to make sure I understand exactly what you are suggesting...

Are you saying the Linux PVH entry code (such as init_pvh_bootparams()) 
should use the fw_cfg interface to read the e820 memory map data and put 
it into the zeropage? Basically, keeping the patch very much like it 
already is, just extracting the e820 data via the fw_cfg interface 
instead of from the second module of start_info struct?

If that is the case, I guess I'm a bit hesitant to throw the QEMU 
specific fw_cfg interface into the mix on the Linux PVH side when the 
existing PVH ABI already seems to contain an interface for passing 
modules/blobs to the guest. But if you feel there is a compelling reason 
to use the fw_cfg interface here, I'm happy to explore that approach 
further.

Thanks,
-Maran

From 1585425798677103202@xxx Wed Nov 29 18:24:24 +0000 2017
X-GM-THRID: 1585339868639162159
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread