Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761961AbYAJPLq (ORCPT ); Thu, 10 Jan 2008 10:11:46 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758860AbYAJPCN (ORCPT ); Thu, 10 Jan 2008 10:02:13 -0500 Received: from twin.jikos.cz ([213.151.79.26]:53362 "EHLO twin.jikos.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759641AbYAJPCH (ORCPT ); Thu, 10 Jan 2008 10:02:07 -0500 Date: Thu, 10 Jan 2008 16:01:44 +0100 (CET) From: Jiri Kosina To: Alan Cox cc: Matthew Wilcox , Nikanth Karthikesan , grant@torque.net, tim@cyberelk.net, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] Change paride driver to use unlocked_ioctl instead of ioctl In-Reply-To: <20080109165641.668838af@lxorguk.ukuu.org.uk> Message-ID: References: <4785B7BC.5040106@suse.de> <4785C7D8.2020808@suse.de> <20080109123311.GP16309@parisc-linux.org> <20080109165641.668838af@lxorguk.ukuu.org.uk> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 628 Lines: 19 On Wed, 9 Jan 2008, Alan Cox wrote: > > > > default: > > > > printk("%s: Unimplemented ioctl 0x%x\n", tape->name, cmd); > > > > + unlock_kernel(); > > > > return -EINVAL; > > > Surely a bug ... shouldn't this return -ENOTTY? > Agreed - ENOTTY. Just out of curiosity, where does POSIX happen to specify ENOTTY as the correct one for unimplemented ioctl? -- Jiri Kosina -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/