Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 30 Nov 2017 08:07:52 +0100
From:   Alexander Sverdlin <alexander.sverdlin@gmail.com>
To:     Lukasz Majewski <lukma@denx.de>
Cc:     Arnd Bergmann <arnd@arndb.de>, arndbergmann@gmail.com,
        Hartley Sweeten <hsweeten@visionengravers.com>,
        Russell King <linux@armlinux.org.uk>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Olof Johansson <olof@lixom.net>,
        Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v2 6/6] ARM: ep93xx: ts72xx: Add support for BK3 board -
 ts72xx derivative
Message-Id: <20171130080752.f805cbf32704649bf8735385@gmail.com>
In-Reply-To: <20171129230704.68b5ec42@jawa>
References: <20171116232239.16823-1-lukma@denx.de>
        <20171121143204.1839-1-lukma@denx.de>
        <20171121143204.1839-7-lukma@denx.de>
        <86943b7f-be3a-2f41-1ffe-c4d7abfee148@gmail.com>
        <20171129230704.68b5ec42@jawa>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hello Lukasz,

On Wed, 29 Nov 2017 23:07:04 +0100
Lukasz Majewski <lukma@denx.de> wrote:

> > > +/*************************************************************************
> > > + * BK3 support code
> > > +
> > > *************************************************************************/
> > > +static struct mtd_partition bk3_nand_parts[] = {
> > > +	{
> > > +		.name		= "System",
> > > +		.offset	= 0x00000000,  
> > 
> > I see the above and below lines as unaligned
> 
> This is strange.... I'm using emacs with extension to have coding style
> for kernel.
> 
> Probably tabs get unaligned...

Yes, seems that they are.

[...]

> > 
> > > +	.atag_offset	= 0x100,
> > > +	.map_io	= bk3_map_io,  
> > 
> > again, inconsistent alignment...
> 
> Even more..... checkpatch.pl did not complained....

checkpatch.pl wouldn't complain, as there are basically two styles,
some people do not align the individual assignments in the structures at all.
But I was quite confident in the beginning and now even applied your v3 to
the code. And indeed it's unaligned... I even checked with emacs. Still
unaligned.

-- 
Alexander Sverdlin.

From 1585449904375218097@xxx Thu Nov 30 00:47:33 +0000 2017
X-GM-THRID: 1584299915922326607
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread