Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Yinbo Zhu <yinbo.zhu@nxp.com>
To:     Shawn Guo <shawnguo@kernel.org>
CC:     Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        "Catalin Marinas )" <catalin.marinas@arm.com>,
        "Will Deacon )" <will.deacon@arm.com>,
        Harninder Rai <harninder.rai@nxp.com>,
        Raghav Dogra <raghav.dogra@nxp.com>,
        Ashish Kumar <ashish.kumar@nxp.com>,
        Andy Tang <andy.tang@nxp.com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2] arm64: dts: ls1088a: Add USB support
Thread-Topic: [PATCH v2] arm64: dts: ls1088a: Add USB support
Thread-Index: AQHTLHKHig8ljL2d2EGPrDhdGPPl+aLAhoAAgDJtRQA=
Date:   Tue, 24 Oct 2017 09:14:34 +0000
Message-ID: <VI1PR04MB1262D160BA8625330E32CAF9E9470@VI1PR04MB1262.eurprd04.prod.outlook.com>
References: <20170913091009.21448-1-yinbo.zhu@nxp.com>
 <20170922065454.GF26358@dragon>
In-Reply-To: <20170922065454.GF26358@dragon>
Accept-Language: zh-CN, en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 42957620-0693-4848-4f10-08d51abfa4e6
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Oct 2017 09:14:34.9019
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB1197
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


-----Original Message-----
From: Shawn Guo [mailto:shawnguo@kernel.org]=20
Sent: Friday, September 22, 2017 2:55 PM
To: Yinbo Zhu <yinbo.zhu@nxp.com>
Cc: Rob Herring <robh+dt@kernel.org>; Mark Rutland <mark.rutland@arm.com>; =
Catalin Marinas ) <catalin.marinas@arm.com>; Will Deacon ) <will.deacon@arm=
.com>; Harninder Rai <harninder.rai@nxp.com>; Raghav Dogra <raghav.dogra@nx=
p.com>; Ashish Kumar <ashish.kumar@nxp.com>; Andy Tang <andy.tang@nxp.com>;=
 open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS <devicetree@vge=
r.kernel.org>; linux-arm-kernel@lists.infradead.org; open list <linux-kerne=
l@vger.kernel.org>
Subject: Re: [PATCH v2] arm64: dts: ls1088a: Add USB support

On Wed, Sep 13, 2017 at 05:10:09PM +0800, yinbo.zhu@nxp.com wrote:
> From: "yinbo.zhu" <yinbo.zhu@nxp.com>
>=20
> Fix the issue that usb is not detected on ls1088ardb

It's not really about fixing issue but adding support.

The patch had been tested on upstream 4.14 code, it can fix the issue.=20
>=20
> Signed-off-by: yinbo.zhu <yinbo.zhu@nxp.com>
> Signed-off-by: Ran Wang <ran.wang_1@nxp.com>
> ---

You should better have a version history here to tell what's changed betwee=
n version.

I will add a version history on next v3 patch

>  arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts |  8 ++++++++
>  arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi    | 20 +++++++++++++++++=
+++
>  2 files changed, 28 insertions(+)
>=20
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts=20
> b/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
> index 213abb72de93..6c3c3bc4b681 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
> @@ -118,6 +118,14 @@
>  	status =3D "okay";
>  };
> =20
> +&usb0 {
> +	status =3D "okay";
> +};
> +
> +&usb1 {
> +	status =3D "okay";
> +};
> +
>  &esdhc {

Please sort these labeled nodes alphabetically.

Shawn

>  	status =3D "okay";
>  };
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi=20
> b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> index c144d06a6e33..c23fede8cf5d 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> @@ -359,6 +359,26 @@
>  			status =3D "disabled";
>  		};
> =20
> +		usb0: usb3@3100000 {
> +			compatible =3D "snps,dwc3";
> +			reg =3D <0x0 0x3100000 0x0 0x10000>;
> +			interrupts =3D <0 80 IRQ_TYPE_LEVEL_HIGH>;
> +			dr_mode =3D "host";
> +			snps,quirk-frame-length-adjustment =3D <0x20>;
> +			snps,dis_rxdet_inp3_quirk;
> +			status =3D "disabled";
> +		};
> +
> +		usb1: usb3@3110000 {
> +			compatible =3D "snps,dwc3";
> +			reg =3D <0x0 0x3110000 0x0 0x10000>;
> +			interrupts =3D <0 81 IRQ_TYPE_LEVEL_HIGH>;
> +			dr_mode =3D "host";
> +			snps,quirk-frame-length-adjustment =3D <0x20>;
> +			snps,dis_rxdet_inp3_quirk;
> +			status =3D "disabled";
> +		};
> +
>  		sata: sata@3200000 {
>  			compatible =3D "fsl,ls1088a-ahci";
>  			reg =3D <0x0 0x3200000 0x0 0x10000>,
> --
> 2.14.1
>=20

From 1579221902781788488@xxx Fri Sep 22 06:56:08 +0000 2017
X-GM-THRID: 1578416200010337890
X-Gmail-Labels: Inbox,Category Forums