Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <1511947880-21643-1-git-send-email-wanpeng.li@hotmail.com>
References: <1511947880-21643-1-git-send-email-wanpeng.li@hotmail.com>
From:   Jim Mattson <jmattson@google.com>
Date:   Wed, 29 Nov 2017 08:55:13 -0800
Message-ID: <CALMp9eTAUV1JDbz_8deRx4CB_eTk0QNgNsdETpQqFf449FuYew@mail.gmail.com>
Subject: Re: [PATCH v2] KVM: VMX: Cache IA32_DEBUGCTL in memory
To:     Wanpeng Li <kernellwp@gmail.com>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        kvm list <kvm@vger.kernel.org>,
        Paolo Bonzini <pbonzini@redhat.com>,
        =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        Wanpeng Li <wanpeng.li@hotmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Thanks for doing this!

Reviewed-by: Jim Mattson <jmattson@google.com>

On Wed, Nov 29, 2017 at 1:31 AM, Wanpeng Li <kernellwp@gmail.com> wrote:
> From: Wanpeng Li <wanpeng.li@hotmail.com>
>
> MSR_IA32_DEBUGCTLMSR is zeroed on VMEXIT, so it is saved/restored
> each time during world switch. Jim from Google pointed out that
> when running schbench in L2, vmx_vcpu_run will occupy 4% cpu time,
> and the 25% of vmx_vcpu_run cpu time is occupied by get_debugctlmsr().
> This patch caches the host IA32_DEBUGCTL MSR and saves/restores
> the host IA32_DEBUGCTL msr when guest/host switches to avoid to
> save/restore each time during world switch.
>
> Suggested-by: Jim Mattson <jmattson@google.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Radim Kr=C4=8Dm=C3=A1=C5=99 <rkrcmar@redhat.com>
> Cc: Jim Mattson <jmattson@google.com>
> Signed-off-by: Wanpeng Li <wanpeng.li@hotmail.com>
> ---
> v1 ->  v2:
>  * rename to host_debugctlmsr and place it in struct vcpu_struct
>  * update_debugctlmsr stay in vmx_vcpu_run
>
>  arch/x86/kvm/vmx.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index 8c7e816..d293c29 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -658,6 +658,8 @@ struct vcpu_vmx {
>
>         u32 host_pkru;
>
> +       unsigned long host_debugctlmsr;
> +
>         /*
>          * Only bits masked by msr_ia32_feature_control_valid_bits can be=
 set in
>          * msr_ia32_feature_control. FEATURE_CONTROL_LOCKED is always inc=
luded
> @@ -2326,6 +2328,7 @@ static void vmx_vcpu_load(struct kvm_vcpu *vcpu, in=
t cpu)
>
>         vmx_vcpu_pi_load(vcpu, cpu);
>         vmx->host_pkru =3D read_pkru();
> +       vmx->host_debugctlmsr =3D get_debugctlmsr();
>  }
>
>  static void vmx_vcpu_pi_put(struct kvm_vcpu *vcpu)
> @@ -9346,7 +9349,7 @@ static void vmx_arm_hv_timer(struct kvm_vcpu *vcpu)
>  static void __noclone vmx_vcpu_run(struct kvm_vcpu *vcpu)
>  {
>         struct vcpu_vmx *vmx =3D to_vmx(vcpu);
> -       unsigned long debugctlmsr, cr3, cr4;
> +       unsigned long cr3, cr4;
>
>         /* Record the guest's net vcpu time for enforced NMI injections. =
*/
>         if (unlikely(!enable_vnmi &&
> @@ -9399,7 +9402,6 @@ static void __noclone vmx_vcpu_run(struct kvm_vcpu =
*vcpu)
>                 __write_pkru(vcpu->arch.pkru);
>
>         atomic_switch_perf_msrs(vmx);
> -       debugctlmsr =3D get_debugctlmsr();
>
>         vmx_arm_hv_timer(vcpu);
>
> @@ -9510,8 +9512,8 @@ static void __noclone vmx_vcpu_run(struct kvm_vcpu =
*vcpu)
>               );
>
>         /* MSR_IA32_DEBUGCTLMSR is zeroed on vmexit. Restore it if needed=
 */
> -       if (debugctlmsr)
> -               update_debugctlmsr(debugctlmsr);
> +       if (vmx->host_debugctlmsr)
> +               update_debugctlmsr(vmx->host_debugctlmsr);
>
>  #ifndef CONFIG_X86_64
>         /*
> --
> 2.7.4
>

From 1585392396053902302@xxx Wed Nov 29 09:33:29 +0000 2017
X-GM-THRID: 1585379526281584765
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread