Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <b03a351c-764c-5132-7efa-a63328d3e8e4@redhat.com>
References: <1511935673-7371-1-git-send-email-wanpeng.li@hotmail.com>
 <5ce1fb8a-05e1-3122-9194-73194a851da4@redhat.com> <CANRm+CwsNpDwSeDmVUG0dgyRNso2_NVZoo2Vs=05RuC7pkB+ZA@mail.gmail.com>
 <b03a351c-764c-5132-7efa-a63328d3e8e4@redhat.com>
From:   Wanpeng Li <kernellwp@gmail.com>
Date:   Wed, 29 Nov 2017 17:20:40 +0800
Message-ID: <CANRm+Cw4Ac2=i+7g1gDm1hQmYMQAOuqH2o31WtMye6+ojggj0Q@mail.gmail.com>
Subject: Re: [PATCH] KVM: VMX: Cache IA32_DEBUGCTL in memory
To:     Paolo Bonzini <pbonzini@redhat.com>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        kvm <kvm@vger.kernel.org>,
        =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        Wanpeng Li <wanpeng.li@hotmail.com>,
        Jim Mattson <jmattson@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

2017-11-29 17:13 GMT+08:00 Paolo Bonzini <pbonzini@redhat.com>:
> On 29/11/2017 09:51, Wanpeng Li wrote:
>> 2017-11-29 16:48 GMT+08:00 Paolo Bonzini <pbonzini@redhat.com>:
>>> On 29/11/2017 07:07, Wanpeng Li wrote:
>>>> From: Wanpeng Li <wanpeng.li@hotmail.com>
>>>>
>>>> MSR_IA32_DEBUGCTLMSR is zeroed on VMEXIT, so it is saved/restored
>>>> each time during world switch. Jim from Google pointed out that
>>>> when running schbench in L2, vmx_vcpu_run will occupy 4% cpu time,
>>>> and the 25% of vmx_vcpu_run cpu time is occupied by get_debugctlmsr().
>>>> This patch caches the host IA32_DEBUGCTL MSR and saves/restores
>>>> the host IA32_DEBUGCTL msr when guest/host switches to avoid to
>>>> save/restore each time during world switch.
>>>>
>>>> Suggested-by: Jim Mattson <jmattson@google.com>
>>>> Cc: Jim Mattson <jmattson@google.com>
>>>> Cc: Paolo Bonzini <pbonzini@redhat.com>
>>>> Cc: Radim Kr=C4=8Dm=C3=A1=C5=99 <rkrcmar@redhat.com>
>>>> Signed-off-by: Wanpeng Li <wanpeng.li@hotmail.com>
>>>
>>> The update_debugctlmsr should stay in vmx_vcpu_run so that tracing
>>> features work correctly.  However, the get_debugctlmsr indeed can be
>>
>> The tracing can't run except vCPU is schedule out, so why
>> update_debugctlmsr should stay in vmx_vcpu_run?
>
> For example your patch is disabling BTS (branch trace store) after the
> first vmexit, isn't it?

I see. Thanks for pointing out. :)

Regards,
Wanpeng Li

From 1585391334800541789@xxx Wed Nov 29 09:16:37 +0000 2017
X-GM-THRID: 1585379526281584765
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread