Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 1/2] x86,kvm: move qemu/guest FPU switching out to
 vcpu_run
To:     Rik van Riel <riel@redhat.com>,
        "quan.xu04@gmail.com" <quan.xu04@gmail.com>, pbonzini@redhat.com
Cc:     kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
        david@redhat.com, borntraeger@de.ibm.com, tglx@linutronix.de,
        rkrcmar@redhat.com
References: <20171114215424.32214-1-riel@redhat.com>
 <20171114215424.32214-2-riel@redhat.com>
 <2e83dd3f-8f03-03ac-45e0-f2fae1d17013@gmail.com>
 <1510756981.21121.291.camel@redhat.com>
From:   Quan Xu <quan.xu0@gmail.com>
Message-ID: <c331a215-2b7c-3c79-91ce-2b10b1882d36@gmail.com>
Date:   Thu, 16 Nov 2017 10:50:32 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <1510756981.21121.291.camel@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 2017-11-15 22:43, Rik van Riel wrote:
> Can you explain why you believe that?

for example, a vcpu thread is running in kvm mode under cretical
condition to stop. QEMU send an IPI to cause a VM-exit to happen
immediately, and this IPI doesn't make vcpu return to QEMU. IIUC
this vcpu thread will still continue to run in kvm mode when is
waked up at targer machine. with your patch, I don't see a chance
to load guest FPU or XSTATE, until return to QEMU and run kvm mode again.

then the FPU or XSTATE status is inconsistent for a small window, what's 
even
worse is that the vcpu is running.

Did I misunderstand?

Quan
Alibaba Cloud


> Getting the guest FPU or XSTATE is done under the vcpu->mutex.
>
> This patch switches out guest and userspace FPU/XSTATE under the
> vcpu->mutex, and switches it back before releasing the vcpu->mutex.
>
> By the time a KVM_GET_FPU has obtained the vcpu->mutex, the guest
> FPU state will be in vcpu->arch.guest_fpu.state, where you expect
> it to be.
>
> What am I missing?
>


From 1584151822207231380@xxx Wed Nov 15 16:55:06 +0000 2017
X-GM-THRID: 1584017174910331026
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread