Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <1510682877.30057.1.camel@redhat.com>
Subject: Re: [PATCH] x86,kvm: move qemu/guest FPU switching out to vcpu_run
From:   Rik van Riel <riel@redhat.com>
To:     David Hildenbrand <david@redhat.com>, pbonzini@redhat.com
Cc:     kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
        tglx@linutronix.de, rkrcmar@redhat.com, borntraeger@de.ibm.com
Date:   Tue, 14 Nov 2017 13:07:57 -0500
In-Reply-To: <a3c862c2-e5f9-f394-885c-10fde7904f03@redhat.com>
References: <20171114001223.441ea2ca@annuminas.surriel.com>
         <a3c862c2-e5f9-f394-885c-10fde7904f03@redhat.com>
Content-Type: multipart/signed; micalg="pgp-sha256";
        protocol="application/pgp-signature"; boundary="=-09DCwSgiYgl3vGfspZei"
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--=-09DCwSgiYgl3vGfspZei
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, 2017-11-14 at 17:57 +0100, David Hildenbrand wrote:
>=20
> > diff --git a/arch/x86/include/asm/kvm_host.h
> > b/arch/x86/include/asm/kvm_host.h
> > index c73e493adf07..92e66685249e 100644
> > --- a/arch/x86/include/asm/kvm_host.h
> > +++ b/arch/x86/include/asm/kvm_host.h
>=20
> We should also get rid of guest_fpu_loaded now, right?

Indeed, we no longer need that member. I'll get rid of it.

> emulator_get_fpu() does a kvm_load_guest_fpu(). Doesn't that mean
> that
> this is now not needed anymore? (at least when emulator code is
> called
> from inside the loop?)

Now that is a very good question!

When called from inside the loop, it is indeed not
needed.

My question is, can the in-kernel emulator code ever
be called from OUTSIDE the KVM_RUN ioctl loop?

If so, we need to restore the user FPU context before
returning from the emulator code. Given that the current
emulator code does not do that, I suspect this is not
the case. I also see no path from the kvm ioctl into
the emulator code, other than via KVM_RUN.

The FPU and XSAVE ioctls all work on the saved
vcpu->arch.guest_fpu data, and never directly on the
registers.

Looks like we can completely get rid of .get_fpu and
.put_fpu...

Unless Paolo has any objection, I'll go do that :)

> Also, what about preempt_diable() at that point, still needed?

If the guest FPU context is the only FPU context loaded
for the task at that point in time, we should not need
to run with preemption disabled.

After all, if we were to get preempted, the context switch
code would automatically save and restore the guest FPU
context for us.

--=20
All rights reversed
--=-09DCwSgiYgl3vGfspZei
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAABCAAGBQJaCzD9AAoJEM553pKExN6DyK8H/j9+qYqvsquddcqYj/C8jo+1
J+pOjNGODfvW9ZwgCFu9TOkUL1fNYrZ1+m5sMBMnAcPQEhXcP+p8TBWXIQZZXB6y
D6Ay3ns+evE1OEVUPFRQ7/d/8m+lpSDB8cXv+SoguoWwj7ffWYh8Hw0GBkrF5ybs
/+lRfB/jDoHML49QBIaLbBmsp8cLMqpkjQWhz/MyeDf3VkfLXWTPsn7IcoHO9GVQ
0Z6KNd371By/gYbI2E2M7KDjPgmMlWNS7uaLreofaB3pnznVE6src9hkmHmPbq/m
EWNlIiEVGH+TwuiG6nnPOUYhkZZmm9HiI2tV/aEmSYFTPAbnJT+PWNdFFjVyDA4=
=kU3M
-----END PGP SIGNATURE-----

--=-09DCwSgiYgl3vGfspZei--


From 1584066011160084555@xxx Tue Nov 14 18:11:10 +0000 2017
X-GM-THRID: 1584017174910331026
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread