Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <eeb8c609-3fbb-bdd4-5556-d75dec87a6bd@redhat.com>
References: <1511218341-6221-1-git-send-email-wanpeng.li@hotmail.com> <eeb8c609-3fbb-bdd4-5556-d75dec87a6bd@redhat.com>
From:   Wanpeng Li <kernellwp@gmail.com>
Date:   Tue, 21 Nov 2017 08:34:59 +0800
Message-ID: <CANRm+Cx8r5GFwsEHOBv8DVkrcdQHW6CHgD+g5EFXGUTJmysG1Q@mail.gmail.com>
Subject: Re: [PATCH v2] KVM: VMX: Fix rflags cache during vCPU reset
To:     Paolo Bonzini <pbonzini@redhat.com>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        kvm <kvm@vger.kernel.org>,
        =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        Wanpeng Li <wanpeng.li@hotmail.com>,
        Nadav Amit <nadav.amit@gmail.com>,
        Dmitry Vyukov <dvyukov@google.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

2017-11-21 7:09 GMT+08:00 Paolo Bonzini <pbonzini@redhat.com>:
> On 20/11/2017 23:52, Wanpeng Li wrote:
>> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
>> index b348920..131fa1c 100644
>> --- a/arch/x86/kvm/vmx.c
>> +++ b/arch/x86/kvm/vmx.c
>> @@ -5590,6 +5590,7 @@ static void vmx_vcpu_reset(struct kvm_vcpu *vcpu, bool init_event)
>>               vmcs_write64(GUEST_IA32_DEBUGCTL, 0);
>>       }
>>
>> +     kvm_set_rflags(vcpu, 2);
>>       vmcs_writel(GUEST_RFLAGS, 0x02);
>
> I think the vmcs_writel can go, kvm_set_rflags ends up calling
> vmx_set_rflags.

Agreed.

>
>>       kvm_rip_write(vcpu, 0xfff0);
>>
>>
>
> Beautified testcase:
>
>     #include <unistd.h>
>     #include <sys/syscall.h>
>     #include <string.h>
>     #include <stdint.h>
>     #include <linux/kvm.h>
>     #include <fcntl.h>
>     #include <sys/ioctl.h>
>
>     long r[5];
>     int main()
>     {
>         struct kvm_debugregs dr = { 0 };
>
>         r[2] = open("/dev/kvm", O_RDONLY);
>         r[3] = ioctl(r[2], KVM_CREATE_VM, 0);
>         r[4] = ioctl(r[3], KVM_CREATE_VCPU, 7);
>         struct kvm_guest_debug debug = {
>                 .control = 0xf0403,
>                 .arch = {
>                         .debugreg[6] = 0x2,
>                         .debugreg[7] = 0x2
>                 }
>         };
>         ioctl(r[4], KVM_SET_GUEST_DEBUG, &debug);
>         ioctl(r[4], KVM_RUN, 0);
>     }
>
> No need to do anything, I'll handle this patch after -rc1.

Thanks for that. :)

Regards,
Wanpeng Li

From 1584628432536642444@xxx Mon Nov 20 23:10:37 +0000 2017
X-GM-THRID: 1584627435971500807
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread