Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   =?iso-8859-1?Q?Br=FCns=2C_Stefan?= <Stefan.Bruens@rwth-aachen.de>
To:     Bastien Nocera <hadess@hadess.net>
CC:     "platform-driver-x86@vger.kernel.org" 
        <platform-driver-x86@vger.kernel.org>,
        "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/5] Input: add KEY_ROTATE_LOCK_TOGGLE
Thread-Topic: [PATCH v2 3/5] Input: add KEY_ROTATE_LOCK_TOGGLE
Thread-Index: AQHTWbNZFQY7Qw5crkalStznwQwZs6MtQ5EA
Date:   Thu, 30 Nov 2017 17:51:37 +0000
Message-ID: <2845999.tyV6EiPLrg@sbruens-linux>
References: <20171109224436.16472-1-stefan.bruens@rwth-aachen.de>
 <8ebdb255-b0b5-4de2-a680-e7f6713256d0@rwthex-w2-a.rwth-ad.de>
 <1510270493.2624.49.camel@hadess.net>
In-Reply-To: <1510270493.2624.49.camel@hadess.net>
Accept-Language: en-US, de-DE
Content-Language: en-US
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <D052AFA297317F4E88E9A5837555E68F@rwth-ad.de>
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Freitag, 10. November 2017 00:34:53 CET Bastien Nocera wrote:
> On Thu, 2017-11-09 at 23:44 +0100, Stefan Br�ns wrote:
> > The key has the same use as the SW_ROTATE_LOCK, but is used on
> > devices
> > where the state is not tracked by the hardware but has to be handled
> > in software.
> 
> I'll let the input and hid subsystem maintainers have the final say
> here, though I think that sending out Win+O would be easier, as this is
> already something that desktops need to support for those devices that
> send the actual Win+O key combination when those buttons are pressed
> there.
> 
> If we're going with the separate keycode, could you also file bugs
> against xkbd-common and xkeyboard-config to get the key added to the
> list of XF86 keysyms and to the default evdev keymap? Otherwise Wayland
> and X11 based desktops won't be able to use it.

Filed for xkeyboard-config:
https://bugs.freedesktop.org/show_bug.cgi?id=103998

and xkb-common:
https://github.com/xkbcommon/libxkbcommon/issues/55

Regards,

Stefan

From 1583641412668672971@xxx Fri Nov 10 01:42:21 +0000 2017
X-GM-THRID: 1583630354914823275
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread