Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] pata_pdc2027x: Fix coding sytle error
To:     Joe Perches <joe@perches.com>, b.zolnierkie@samsung.com,
        tj@kernel.org, sergei.shtylyov@cogentembedded.com
References: <68e25992911d7c4d6c17b9f31524a614466d9588.1511605703.git.arvind.yadav.cs@gmail.com>
 <1511607744.2503.1.camel@perches.com>
Cc:     linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
From:   arvindY <arvind.yadav.cs@gmail.com>
Message-ID: <5A194F96.2020605@gmail.com>
Date:   Sat, 25 Nov 2017 16:40:14 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <1511607744.2503.1.camel@perches.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Joe,

On Saturday 25 November 2017 04:32 PM, Joe Perches wrote:
> On Sat, 2017-11-25 at 16:04 +0530, Arvind Yadav wrote:
> []
>> diff --git a/drivers/ata/pata_pdc2027x.c b/drivers/ata/pata_pdc2027x.c
> []
>> @@ -84,7 +84,7 @@ static int pdc2027x_set_mode(struct ata_link *link, struct ata_device **r_failed
>>    */
>>   static struct pdc2027x_pio_timing {
>>   	u8 value0, value1, value2;
>> -} pdc2027x_pio_timing_tbl [] = {
>> +} pdc2027x_pio_timing_tbl[] = {
>>   	{ 0xfb, 0x2b, 0xac }, /* PIO mode 0 */
>>   	{ 0x46, 0x29, 0xa4 }, /* PIO mode 1 */
>>   	{ 0x23, 0x26, 0x64 }, /* PIO mode 2 */
> trivia:
>
> It seems all the <foo>_timing_tbl structs should be const
>
Yes, It should be const. I will push anther patch.

~arvind

From 1585035659309339837@xxx Sat Nov 25 11:03:18 +0000 2017
X-GM-THRID: 1585033918245593664
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread