Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 30 Nov 2017 11:09:24 -0800 (PST)
Subject:     Re: [patches] Re: [PATCH] riscv/ftrace: Add basic support
In-Reply-To: <CAOFm3uH0H-12RwoP5OUvBGb-5V-VjdQ58_98RttsyjpS_gtC1g@mail.gmail.com>
CC:     nonerkao@gmail.com, albert@sifive.com, rostedt@goodmis.org,
        patches@groups.riscv.org, mingo@redhat.com,
        linux-kernel@vger.kernel.org, alankao@andestech.com
From:   Palmer Dabbelt <palmer@sifive.com>
To:     pombredanne@nexb.com
Message-ID: <mhng-b93ec5e4-3cd1-4e10-9123-9652ad2938d5@palmer-si-x1c4>
Mime-Version: 1.0 (MHng)
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 30 Nov 2017 03:31:53 PST (-0800), pombredanne@nexb.com wrote:
> On Thu, Nov 30, 2017 at 9:53 AM, Alan Kao <nonerkao@gmail.com> wrote:
> []
>> diff --git a/arch/riscv/include/asm/ftrace.h b/arch/riscv/include/asm/ftrace.h
>> new file mode 100644
>> index 000000000000..38beadb07ad5
>> --- /dev/null
>> +++ b/arch/riscv/include/asm/ftrace.h
>> @@ -0,0 +1,23 @@
>> +/*
>> + * Copyright (C) 2017 Andes Technology Corporation
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License version 2 as
>> + * published by the Free Software Foundation.
>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> + * GNU General Public License for more details.
>> + *
>> + * You should have received a copy of the GNU General Public License
>> + * along with this program.  If not, see <http://www.gnu.org/licenses/>.
>> + */
>
> You may want to use the new SPDX ids here instead?
> e.g.
>> +// SPDX-License-Identifer: GPL-2.0
>> +// Copyright (C) 2017 Andes Technology Corporation
>
> Neater and simpler?
> See Linus posts on the topic of comment styles too BTW

I believe we need to convert all the RISC-V stuff to SPDX headers, that change 
happened between when we got the port reviewed and made it into Linus' tree.  
Do you happen to know if there's some script I can run to do this 
automatically?

From 1585490627568220633@xxx Thu Nov 30 11:34:50 +0000 2017
X-GM-THRID: 1585480628730807362
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread