Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20171130085335.7949-1-alankao@andestech.com>
References: <20171130085335.7949-1-alankao@andestech.com>
From:   Philippe Ombredanne <pombredanne@nexb.com>
Date:   Thu, 30 Nov 2017 12:31:53 +0100
Message-ID: <CAOFm3uH0H-12RwoP5OUvBGb-5V-VjdQ58_98RttsyjpS_gtC1g@mail.gmail.com>
Subject: Re: [PATCH] riscv/ftrace: Add basic support
To:     Alan Kao <nonerkao@gmail.com>
Cc:     Palmer Dabbelt <palmer@sifive.com>, Albert Ou <albert@sifive.com>,
        Steven Rostedt <rostedt@goodmis.org>, patches@groups.riscv.org,
        Ingo Molnar <mingo@redhat.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Alan Kao <alankao@andestech.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Nov 30, 2017 at 9:53 AM, Alan Kao <nonerkao@gmail.com> wrote:
[]
> diff --git a/arch/riscv/include/asm/ftrace.h b/arch/riscv/include/asm/ftrace.h
> new file mode 100644
> index 000000000000..38beadb07ad5
> --- /dev/null
> +++ b/arch/riscv/include/asm/ftrace.h
> @@ -0,0 +1,23 @@
> +/*
> + * Copyright (C) 2017 Andes Technology Corporation
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program.  If not, see <http://www.gnu.org/licenses/>.
> + */

You may want to use the new SPDX ids here instead?
e.g.
> +// SPDX-License-Identifer: GPL-2.0
> +// Copyright (C) 2017 Andes Technology Corporation

Neater and simpler?
See Linus posts on the topic of comment styles too BTW

-- 
Cordially
Philippe Ombredanne

From 1585480628730807362@xxx Thu Nov 30 08:55:54 +0000 2017
X-GM-THRID: 1585480628730807362
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread