Received: by 10.223.164.202 with SMTP id h10csp4389646wrb; Wed, 29 Nov 2017 05:44:42 -0800 (PST) X-Google-Smtp-Source: AGs4zMbEQHvbs4+JelBvCuES3QlfpMaCSB5+nuzgc4n8W6/A1hE249m8pMENTHaft0+zSyPB5Pa5 X-Received: by 10.98.82.3 with SMTP id g3mr3054316pfb.189.1511963082046; Wed, 29 Nov 2017 05:44:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1511963082; cv=none; d=google.com; s=arc-20160816; b=IwNJOjUUrhjMbn1r+jJ5MCrWg1UkiB9cnrCUqCULudOPEFUgwhTadnc3mWjrIJ3ccu ErvMr76XwMRHkuo1IGkkbXP5wwG8UnNoa6St0SfTm2fftZqsq8NxDovGwqevodhYO3ig /6eOt6wb1MjYrOltZSDFibDlsVIwBI6PagXPGKocNSpIiA5RMT1Z7u2syvGiDMrtWhc6 J2uuh0lj2k5PF1T/CZ/9UfJxXKEVupaED8smjEnuYEgFSZyYJalu199KqWWmdM+YfrUQ vV5sII1SubdPi1WhOXvcNJ3m4rhGW0prKIvd7SrNUGSTep0J8A9ylXlz8ZJ9SBkn4CQz iDMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date:from :references:cc:to:subject:arc-authentication-results; bh=ivX4fCrm0JRRTu4QHxazaO+Q4CIXjNxIaDZt6oysDYM=; b=TKe99n3InmpxlfbDLmQRPDwX8IPO9c186/F8hHQLrUNIJfzCO+5PXls40Nr9th2H/F QQvTfXNQYAUiSvNHod4raABH8qXa6kkroJF/TordAVeMUW1qOUzPoTqH+P9BXG7WQDb0 SFoB2M0VaXLrg/CBpZ0+U4JbslSk/B2V98dBoO/284XikjQtKAJE4ujFGd9i2Oo6+Jdt TiMAmNqesWs6n89co32HuQkqERtSRQJw9C5k2Sas98pRfqLx0093SCKDHVf3Bz9oXf+m iZV7BxJA21lzNU9hG3aBMdQAD90r8+edNC3h9EnnDWTR16WRlRv5vHuXR08vk+JYVX/V 6BqA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f10si141334pgu.783.2017.11.29.05.44.31; Wed, 29 Nov 2017 05:44:42 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754603AbdK2LhW (ORCPT + 70 others); Wed, 29 Nov 2017 06:37:22 -0500 Received: from mx0b-001ae601.pphosted.com ([67.231.152.168]:48174 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752363AbdK2LhT (ORCPT ); Wed, 29 Nov 2017 06:37:19 -0500 Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id vATBXm7N012759; Wed, 29 Nov 2017 05:37:02 -0600 Authentication-Results: ppops.net; spf=none smtp.mailfrom=rf@opensource.wolfsonmicro.com Received: from mail3.cirrus.com ([87.246.76.56]) by mx0b-001ae601.pphosted.com with ESMTP id 2egwd9jpd1-1; Wed, 29 Nov 2017 05:37:02 -0600 Received: from EX17.ad.cirrus.com (ex17.ad.cirrus.com [172.20.9.81]) by mail3.cirrus.com (Postfix) with ESMTP id C3217611CE62; Wed, 29 Nov 2017 05:40:58 -0600 (CST) Received: from imbe.wolfsonmicro.main (198.61.95.81) by EX17.ad.cirrus.com (172.20.9.81) with Microsoft SMTP Server id 14.3.301.0; Wed, 29 Nov 2017 11:36:59 +0000 Received: from [198.90.223.54] (edi-sw-dsktp006.ad.cirrus.com [198.90.223.54]) by imbe.wolfsonmicro.main (8.14.4/8.14.4) with ESMTP id vATBawwp016754; Wed, 29 Nov 2017 11:36:58 GMT Subject: Re: [PATCH v6 03/17] mfd: madera: Add common support for Cirrus Logic Madera codecs To: Linus Walleij CC: Lee Jones , Mark Brown , Alexandre Courbot , Rob Herring , Thomas Gleixner , Jason Cooper , , "open list:WOLFSON MICROELECTRONICS DRIVERS" , , , "linux-kernel@vger.kernel.org" , Charles Keepax , Nikesh Oswal References: <20171123171316.10868-1-rf@opensource.wolfsonmicro.com> From: Richard Fitzgerald Date: Wed, 29 Nov 2017 11:36:58 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Message-ID: <1eff5a38-cff3-449b-bda4-047f50a9f1d4@EX17.ad.cirrus.com> X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1711290150 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/11/17 10:18, Linus Walleij wrote: > On Thu, Nov 23, 2017 at 6:13 PM, Richard Fitzgerald > wrote: > >> +config MFD_MADERA_I2C >> + bool "Cirrus Logic Madera codecs with I2C" >> + select MFD_MADERA >> + select REGMAP_I2C >> + depends on I2C >> + depends on PINCTRL >> + help >> + Support for the Cirrus Logic Madera platform audio SoC >> + core functionality controlled via I2C. >> + >> +config MFD_MADERA_SPI >> + bool "Cirrus Logic Madera codecs with SPI" >> + select MFD_MADERA >> + select REGMAP_SPI >> + depends on SPI_MASTER >> + depends on PINCTRL >> + help >> + Support for the Cirrus Logic Madera platform audio SoC >> + core functionality controlled via SPI. > > Why do the I2C and SPI subdrivers depend on PINCTRL? > > They sure don't seem to be using any pinctrl-specific APIs. > They require PINCTRL even if they don't call any functions on it because the chip won't work correctly if there isn't a PINCTRL driver to apply the correct pinmux configuration. > Yours, > Linus Walleij > From 1585395328183954308@xxx Wed Nov 29 10:20:05 +0000 2017 X-GM-THRID: 1584878053866303597 X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread