Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760193AbYAJS5Y (ORCPT ); Thu, 10 Jan 2008 13:57:24 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757642AbYAJS5J (ORCPT ); Thu, 10 Jan 2008 13:57:09 -0500 Received: from one.firstfloor.org ([213.235.205.2]:54258 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756946AbYAJS5H (ORCPT ); Thu, 10 Jan 2008 13:57:07 -0500 Date: Thu, 10 Jan 2008 19:59:44 +0100 From: Andi Kleen To: James Bottomley Cc: Andre Noll , linux-scsi , linux-kernel , kernel-janitors@vger.kernel.org, Andi Kleen , Richard Knutsson Subject: Re: [patch 1/1] Switch ioctl functions of drivers/scsi/sg.c to unlocked_ioctl Message-ID: <20080110185944.GA1690@one.firstfloor.org> References: <20080110180529.GA32640@skl-net.de> <1199991298.3141.75.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1199991298.3141.75.camel@localhost.localdomain> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 677 Lines: 16 > Really, all this is doing is open coding what the ioctl handler is doing > anyway, isn't it? in which case, why bother to change it at all? Because once it's open coded it is visible and can then be eliminated. Does SCSI need the BKL at all? But perhaps for such a long ioctl handler it would be better to move the lock/unlock_kernel()s into the individual case ...: statements; then it could be eliminated step by step. -Andi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/